[GitHub] kafka pull request #3745: [KAFKA-4468] Correctly calculate the window end ti...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3745


---

[GitHub] kafka pull request #3745: [KAFKA-4468] Correctly calculate the window end ti...

[ConcurrencyPractitioner]

GitHub user ConcurrencyPractitioner opened a pull request:

https://github.com/apache/kafka/pull/3745

[KAFKA-4468] Correctly calculate the window end timestamp after read from 
state stores

I have decided to use the following approach to fixing this bug:

1) Since the Window Size in WindowedDeserializer was originally unknown, I 
have initialized
a field _windowSize_ and created a constructor to allow it to be 
instantiated

2) The default size for __windowSize__ is _Long.MAX_VALUE_. If that is the 
case, then the 
deserialize method will return an Unlimited Window, or else will return 
Timed one.

3) Temperature Demo was modified to demonstrate how to use this new 
constructor, given
that the window size is known.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ConcurrencyPractitioner/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3745


commit 7dcf42e110dadd3f257c7ea1a0d10adc60bd0eea
Author: Richard Yu 
Date:   2017-08-26T20:18:48Z

KAFKA-4468 Correctly calculate the window end timestamp after read from 
state stores




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---