Re: [VOTE] - KIP-213 Support non-key joining in KTable

2018-11-26 Thread Jan Filipiak


On 07.11.2018 22:24, Adam Bellemare wrote:
> Bumping this thread, as per convention - 1
>
> On Fri, Nov 2, 2018 at 8:22 AM Adam Bellemare 
> wrote:
>
>> As expected :) But still, thanks none-the-less!
>>
>> On Fri, Nov 2, 2018 at 3:36 AM Jan Filipiak 
>> wrote:
>>
>>> reminder
>>>
>>> On 30.10.2018 15:47, Adam Bellemare wrote:
 Hi All

 I would like to call a vote on

>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-213+Support+non-key+joining+in+KTable
>>> .
 This allows a Kafka Streams DSL user to perform KTable to KTable
 foreign-key joins on their data. I have been using this in production
>>> for
 some time and I have composed a PR that enables this. It is a fairly
 extensive PR, but I believe it will add considerable value to the Kafka
 Streams DSL.

 The PR can be found here:
 https://github.com/apache/kafka/pull/5527

 See
>>> http://mail-archives.apache.org/mod_mbox/kafka-dev/201810.mbox/browser
 for previous discussion thread.

 I would also like to give a shout-out to Jan Filipiak who helped me out
 greatly in this project, and who led the initial work into this problem.
 Without Jan's help and insight I do not think this would have been
>>> possible
 to get to this point.

 Adam

>>>
>>
>


Re: [VOTE] - KIP-213 Support non-key joining in KTable

2018-11-08 Thread Adam Bellemare
Hi John 

By all means, reply how you wish! I am interested in ensuring that everything 
has been addressed.

Thanks

> On Nov 8, 2018, at 4:57 PM, John Roesler  wrote:
> 
> Hey Adam,
> 
> I'm sorry, I haven't been plugged in to your KIP lately. I'll have to read
> it over again. Would it be discouraging if I wound up responding to your
> discussion thread?
> 
> Thanks,
> -John
> 
> On Wed, Nov 7, 2018 at 3:25 PM Adam Bellemare 
> wrote:
> 
>> Bumping this thread, as per convention - 1
>> 
>> On Fri, Nov 2, 2018 at 8:22 AM Adam Bellemare 
>> wrote:
>> 
>>> As expected :) But still, thanks none-the-less!
>>> 
>>> On Fri, Nov 2, 2018 at 3:36 AM Jan Filipiak 
>>> wrote:
>>> 
 reminder
 
> On 30.10.2018 15:47, Adam Bellemare wrote:
> Hi All
> 
> I would like to call a vote on
> 
 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-213+Support+non-key+joining+in+KTable
 .
> This allows a Kafka Streams DSL user to perform KTable to KTable
> foreign-key joins on their data. I have been using this in production
 for
> some time and I have composed a PR that enables this. It is a fairly
> extensive PR, but I believe it will add considerable value to the
>> Kafka
> Streams DSL.
> 
> The PR can be found here:
> https://github.com/apache/kafka/pull/5527
> 
> See
 http://mail-archives.apache.org/mod_mbox/kafka-dev/201810.mbox/browser
> for previous discussion thread.
> 
> I would also like to give a shout-out to Jan Filipiak who helped me
>> out
> greatly in this project, and who led the initial work into this
>> problem.
> Without Jan's help and insight I do not think this would have been
 possible
> to get to this point.
> 
> Adam
> 
 
>>> 
>> 


Re: [VOTE] - KIP-213 Support non-key joining in KTable

2018-11-08 Thread John Roesler
Hey Adam,

I'm sorry, I haven't been plugged in to your KIP lately. I'll have to read
it over again. Would it be discouraging if I wound up responding to your
discussion thread?

Thanks,
-John

On Wed, Nov 7, 2018 at 3:25 PM Adam Bellemare 
wrote:

> Bumping this thread, as per convention - 1
>
> On Fri, Nov 2, 2018 at 8:22 AM Adam Bellemare 
> wrote:
>
> > As expected :) But still, thanks none-the-less!
> >
> > On Fri, Nov 2, 2018 at 3:36 AM Jan Filipiak 
> > wrote:
> >
> >> reminder
> >>
> >> On 30.10.2018 15:47, Adam Bellemare wrote:
> >> > Hi All
> >> >
> >> > I would like to call a vote on
> >> >
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-213+Support+non-key+joining+in+KTable
> >> .
> >> > This allows a Kafka Streams DSL user to perform KTable to KTable
> >> > foreign-key joins on their data. I have been using this in production
> >> for
> >> > some time and I have composed a PR that enables this. It is a fairly
> >> > extensive PR, but I believe it will add considerable value to the
> Kafka
> >> > Streams DSL.
> >> >
> >> > The PR can be found here:
> >> > https://github.com/apache/kafka/pull/5527
> >> >
> >> > See
> >> http://mail-archives.apache.org/mod_mbox/kafka-dev/201810.mbox/browser
> >> > for previous discussion thread.
> >> >
> >> > I would also like to give a shout-out to Jan Filipiak who helped me
> out
> >> > greatly in this project, and who led the initial work into this
> problem.
> >> > Without Jan's help and insight I do not think this would have been
> >> possible
> >> > to get to this point.
> >> >
> >> > Adam
> >> >
> >>
> >
>


Re: [VOTE] - KIP-213 Support non-key joining in KTable

2018-11-07 Thread Adam Bellemare
Bumping this thread, as per convention - 1

On Fri, Nov 2, 2018 at 8:22 AM Adam Bellemare 
wrote:

> As expected :) But still, thanks none-the-less!
>
> On Fri, Nov 2, 2018 at 3:36 AM Jan Filipiak 
> wrote:
>
>> reminder
>>
>> On 30.10.2018 15:47, Adam Bellemare wrote:
>> > Hi All
>> >
>> > I would like to call a vote on
>> >
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-213+Support+non-key+joining+in+KTable
>> .
>> > This allows a Kafka Streams DSL user to perform KTable to KTable
>> > foreign-key joins on their data. I have been using this in production
>> for
>> > some time and I have composed a PR that enables this. It is a fairly
>> > extensive PR, but I believe it will add considerable value to the Kafka
>> > Streams DSL.
>> >
>> > The PR can be found here:
>> > https://github.com/apache/kafka/pull/5527
>> >
>> > See
>> http://mail-archives.apache.org/mod_mbox/kafka-dev/201810.mbox/browser
>> > for previous discussion thread.
>> >
>> > I would also like to give a shout-out to Jan Filipiak who helped me out
>> > greatly in this project, and who led the initial work into this problem.
>> > Without Jan's help and insight I do not think this would have been
>> possible
>> > to get to this point.
>> >
>> > Adam
>> >
>>
>


Re: [VOTE] - KIP-213 Support non-key joining in KTable

2018-11-02 Thread Adam Bellemare
As expected :) But still, thanks none-the-less!

On Fri, Nov 2, 2018 at 3:36 AM Jan Filipiak 
wrote:

> reminder
>
> On 30.10.2018 15:47, Adam Bellemare wrote:
> > Hi All
> >
> > I would like to call a vote on
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-213+Support+non-key+joining+in+KTable
> .
> > This allows a Kafka Streams DSL user to perform KTable to KTable
> > foreign-key joins on their data. I have been using this in production for
> > some time and I have composed a PR that enables this. It is a fairly
> > extensive PR, but I believe it will add considerable value to the Kafka
> > Streams DSL.
> >
> > The PR can be found here:
> > https://github.com/apache/kafka/pull/5527
> >
> > See
> http://mail-archives.apache.org/mod_mbox/kafka-dev/201810.mbox/browser
> > for previous discussion thread.
> >
> > I would also like to give a shout-out to Jan Filipiak who helped me out
> > greatly in this project, and who led the initial work into this problem.
> > Without Jan's help and insight I do not think this would have been
> possible
> > to get to this point.
> >
> > Adam
> >
>


Re: [VOTE] - KIP-213 Support non-key joining in KTable

2018-11-02 Thread Jan Filipiak
reminder

On 30.10.2018 15:47, Adam Bellemare wrote:
> Hi All
>
> I would like to call a vote on
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-213+Support+non-key+joining+in+KTable.
> This allows a Kafka Streams DSL user to perform KTable to KTable
> foreign-key joins on their data. I have been using this in production for
> some time and I have composed a PR that enables this. It is a fairly
> extensive PR, but I believe it will add considerable value to the Kafka
> Streams DSL.
>
> The PR can be found here:
> https://github.com/apache/kafka/pull/5527
>
> See http://mail-archives.apache.org/mod_mbox/kafka-dev/201810.mbox/browser
> for previous discussion thread.
>
> I would also like to give a shout-out to Jan Filipiak who helped me out
> greatly in this project, and who led the initial work into this problem.
> Without Jan's help and insight I do not think this would have been possible
> to get to this point.
>
> Adam
>


Re: [VOTE] - KIP-213 Support non-key joining in KTable

2018-11-02 Thread Jan Filipiak
Hi Adam,

congrats for pulling it of! As I mentioned its not something I can use 
in can / would use in production. So I am throwing a non binding minus 
one in here.

I don't expect it todo any harm for the vote.

Thanks for the credits :)

Best Jan



On 30.10.2018 15:47, Adam Bellemare wrote:
> Hi All
>
> I would like to call a vote on
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-213+Support+non-key+joining+in+KTable.
> This allows a Kafka Streams DSL user to perform KTable to KTable
> foreign-key joins on their data. I have been using this in production for
> some time and I have composed a PR that enables this. It is a fairly
> extensive PR, but I believe it will add considerable value to the Kafka
> Streams DSL.
>
> The PR can be found here:
> https://github.com/apache/kafka/pull/5527
>
> See http://mail-archives.apache.org/mod_mbox/kafka-dev/201810.mbox/browser
> for previous discussion thread.
>
> I would also like to give a shout-out to Jan Filipiak who helped me out
> greatly in this project, and who led the initial work into this problem.
> Without Jan's help and insight I do not think this would have been possible
> to get to this point.
>
> Adam
>


[VOTE] - KIP-213 Support non-key joining in KTable

2018-10-30 Thread Adam Bellemare
Hi All

I would like to call a vote on
https://cwiki.apache.org/confluence/display/KAFKA/KIP-213+Support+non-key+joining+in+KTable.
This allows a Kafka Streams DSL user to perform KTable to KTable
foreign-key joins on their data. I have been using this in production for
some time and I have composed a PR that enables this. It is a fairly
extensive PR, but I believe it will add considerable value to the Kafka
Streams DSL.

The PR can be found here:
https://github.com/apache/kafka/pull/5527

See http://mail-archives.apache.org/mod_mbox/kafka-dev/201810.mbox/browser
for previous discussion thread.

I would also like to give a shout-out to Jan Filipiak who helped me out
greatly in this project, and who led the initial work into this problem.
Without Jan's help and insight I do not think this would have been possible
to get to this point.

Adam