Re: [VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

[Bill Bejeck]

The re-vote has now passed. The votes where:

Binding +1: Sriram, Guozhang, Damian
Non-binding +1: Matthias.

The discussion wrapping up in this PR
https://github.com/apache/kafka/pull/3325

-Bill

On Wed, Jul 26, 2017 at 10:10 AM, Damian Guy  wrote:

> +1
>
> On Tue, 25 Jul 2017 at 18:17 Sriram Subramanian  wrote:
>
> > +1
> >
> > On Fri, Jul 21, 2017 at 12:08 PM, Guozhang Wang 
> > wrote:
> >
> > > +1
> > >
> > > On Thu, Jul 20, 2017 at 11:00 PM, Matthias J. Sax <
> matth...@confluent.io
> > >
> > > wrote:
> > >
> > > > +1
> > > >
> > > > On 7/20/17 4:22 AM, Bill Bejeck wrote:
> > > > > Hi,
> > > > >
> > > > > After working on the PR for this KIP I discovered that we need to
> add
> > > and
> > > > > additional parameter (TopicPartition) to the StateRestoreListener
> > > > interface
> > > > > methods.
> > > > >
> > > > > The addition of the TopicPartition is required as the
> > > > StateRestoreListener
> > > > > is for the entire application, thus all tasks with recovering state
> > > > stores
> > > > > call the same listener instance.  The TopicPartition is needed to
> > > > > disambiguate the progress of the state store recovery.
> > > > >
> > > > > For those that have voted before, please review the updated KIP
> > > > >  > > > 167:+Add+interface+for+the+state+store+restoration+process>
> > > > > and
> > > > > re-vote.
> > > > >
> > > > > Thanks,
> > > > > Bill
> > > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > -- Guozhang
> > >
> >
>

Re: [VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

[Damian Guy]

+1

On Tue, 25 Jul 2017 at 18:17 Sriram Subramanian  wrote:

> +1
>
> On Fri, Jul 21, 2017 at 12:08 PM, Guozhang Wang 
> wrote:
>
> > +1
> >
> > On Thu, Jul 20, 2017 at 11:00 PM, Matthias J. Sax  >
> > wrote:
> >
> > > +1
> > >
> > > On 7/20/17 4:22 AM, Bill Bejeck wrote:
> > > > Hi,
> > > >
> > > > After working on the PR for this KIP I discovered that we need to add
> > and
> > > > additional parameter (TopicPartition) to the StateRestoreListener
> > > interface
> > > > methods.
> > > >
> > > > The addition of the TopicPartition is required as the
> > > StateRestoreListener
> > > > is for the entire application, thus all tasks with recovering state
> > > stores
> > > > call the same listener instance.  The TopicPartition is needed to
> > > > disambiguate the progress of the state store recovery.
> > > >
> > > > For those that have voted before, please review the updated KIP
> > > >  > > 167:+Add+interface+for+the+state+store+restoration+process>
> > > > and
> > > > re-vote.
> > > >
> > > > Thanks,
> > > > Bill
> > > >
> > >
> > >
> >
> >
> > --
> > -- Guozhang
> >
>

Re: [VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

[Sriram Subramanian]

+1

On Fri, Jul 21, 2017 at 12:08 PM, Guozhang Wang  wrote:

> +1
>
> On Thu, Jul 20, 2017 at 11:00 PM, Matthias J. Sax 
> wrote:
>
> > +1
> >
> > On 7/20/17 4:22 AM, Bill Bejeck wrote:
> > > Hi,
> > >
> > > After working on the PR for this KIP I discovered that we need to add
> and
> > > additional parameter (TopicPartition) to the StateRestoreListener
> > interface
> > > methods.
> > >
> > > The addition of the TopicPartition is required as the
> > StateRestoreListener
> > > is for the entire application, thus all tasks with recovering state
> > stores
> > > call the same listener instance.  The TopicPartition is needed to
> > > disambiguate the progress of the state store recovery.
> > >
> > > For those that have voted before, please review the updated KIP
> > >  > 167:+Add+interface+for+the+state+store+restoration+process>
> > > and
> > > re-vote.
> > >
> > > Thanks,
> > > Bill
> > >
> >
> >
>
>
> --
> -- Guozhang
>

Re: [VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

[Guozhang Wang]

+1

On Thu, Jul 20, 2017 at 11:00 PM, Matthias J. Sax 
wrote:

> +1
>
> On 7/20/17 4:22 AM, Bill Bejeck wrote:
> > Hi,
> >
> > After working on the PR for this KIP I discovered that we need to add and
> > additional parameter (TopicPartition) to the StateRestoreListener
> interface
> > methods.
> >
> > The addition of the TopicPartition is required as the
> StateRestoreListener
> > is for the entire application, thus all tasks with recovering state
> stores
> > call the same listener instance.  The TopicPartition is needed to
> > disambiguate the progress of the state store recovery.
> >
> > For those that have voted before, please review the updated KIP
> >  167:+Add+interface+for+the+state+store+restoration+process>
> > and
> > re-vote.
> >
> > Thanks,
> > Bill
> >
>
>


-- 
-- Guozhang

Re: [VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

[Matthias J. Sax]

+1

On 7/20/17 4:22 AM, Bill Bejeck wrote:
> Hi,
> 
> After working on the PR for this KIP I discovered that we need to add and
> additional parameter (TopicPartition) to the StateRestoreListener interface
> methods.
> 
> The addition of the TopicPartition is required as the StateRestoreListener
> is for the entire application, thus all tasks with recovering state stores
> call the same listener instance.  The TopicPartition is needed to
> disambiguate the progress of the state store recovery.
> 
> For those that have voted before, please review the updated KIP
> 
> and
> re-vote.
> 
> Thanks,
> Bill
> 



signature.asc
Description: OpenPGP digital signature

[VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

[Bill Bejeck]

Hi,

After working on the PR for this KIP I discovered that we need to add and
additional parameter (TopicPartition) to the StateRestoreListener interface
methods.

The addition of the TopicPartition is required as the StateRestoreListener
is for the entire application, thus all tasks with recovering state stores
call the same listener instance.  The TopicPartition is needed to
disambiguate the progress of the state store recovery.

For those that have voted before, please review the updated KIP

and
re-vote.

Thanks,
Bill