Re: [VOTE] KIP-247: Add public test utils for Kafka Streams

[Matthias J. Sax]

One minor change to the KIP. The class TopologyTestDriver will be in
package `org.apache.kafka.streams` (instead of `o.a.k.streams.test`).


+1 (binding).


I am closing this vote as accepted with 3 binding votes (Damian,
Guozhang, Matthias) and 2 non-binding votes (Bill, James).

Thanks for the discussion and voting!


-Matthias


On 1/18/18 4:17 PM, Matthias J. Sax wrote:
> I added the new method to the KIP and also updated the PR.
> 
> -Matthias
> 
> On 1/18/18 10:48 AM, Guozhang Wang wrote:
>> @Matthias
>>
>> This comes to me while reviewing another using the test driver: could we
>> add a `Map allStateStores()` to the
>> `TopologyTestDriver` besides all the get-store-by-name functions? This is
>> because some of the internal state stores may be implicitly created but
>> users may still want to check its state.
>>
>>
>> Guozhang
>>
>>
>> On Thu, Jan 18, 2018 at 8:40 AM, James Cheng  wrote:
>>
>>> +1 (non-binding)
>>>
>>> -James
>>>
>>> Sent from my iPhone
>>>
 On Jan 17, 2018, at 6:09 PM, Matthias J. Sax 
>>> wrote:

 Hi,

 I would like to start the vote for KIP-247:
 https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>>> 247%3A+Add+public+test+utils+for+Kafka+Streams


 -Matthias

>>>
>>
>>
>>
> 



signature.asc
Description: OpenPGP digital signature

Re: [VOTE] KIP-247: Add public test utils for Kafka Streams

[Matthias J. Sax]

I added the new method to the KIP and also updated the PR.

-Matthias

On 1/18/18 10:48 AM, Guozhang Wang wrote:
> @Matthias
> 
> This comes to me while reviewing another using the test driver: could we
> add a `Map allStateStores()` to the
> `TopologyTestDriver` besides all the get-store-by-name functions? This is
> because some of the internal state stores may be implicitly created but
> users may still want to check its state.
> 
> 
> Guozhang
> 
> 
> On Thu, Jan 18, 2018 at 8:40 AM, James Cheng  wrote:
> 
>> +1 (non-binding)
>>
>> -James
>>
>> Sent from my iPhone
>>
>>> On Jan 17, 2018, at 6:09 PM, Matthias J. Sax 
>> wrote:
>>>
>>> Hi,
>>>
>>> I would like to start the vote for KIP-247:
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
>> 247%3A+Add+public+test+utils+for+Kafka+Streams
>>>
>>>
>>> -Matthias
>>>
>>
> 
> 
> 



signature.asc
Description: OpenPGP digital signature

Re: [VOTE] KIP-247: Add public test utils for Kafka Streams

[Guozhang Wang]

@Matthias

This comes to me while reviewing another using the test driver: could we
add a `Map allStateStores()` to the
`TopologyTestDriver` besides all the get-store-by-name functions? This is
because some of the internal state stores may be implicitly created but
users may still want to check its state.


Guozhang


On Thu, Jan 18, 2018 at 8:40 AM, James Cheng  wrote:

> +1 (non-binding)
>
> -James
>
> Sent from my iPhone
>
> > On Jan 17, 2018, at 6:09 PM, Matthias J. Sax 
> wrote:
> >
> > Hi,
> >
> > I would like to start the vote for KIP-247:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 247%3A+Add+public+test+utils+for+Kafka+Streams
> >
> >
> > -Matthias
> >
>



-- 
-- Guozhang

Re: [VOTE] KIP-247: Add public test utils for Kafka Streams

[James Cheng]

+1 (non-binding)

-James

Sent from my iPhone

> On Jan 17, 2018, at 6:09 PM, Matthias J. Sax  wrote:
> 
> Hi,
> 
> I would like to start the vote for KIP-247:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-247%3A+Add+public+test+utils+for+Kafka+Streams
> 
> 
> -Matthias
> 

Re: [VOTE] KIP-247: Add public test utils for Kafka Streams

[Bill Bejeck]

Thanks for the KIP.

+1

-Bill

On Wed, Jan 17, 2018 at 9:09 PM, Matthias J. Sax 
wrote:

> Hi,
>
> I would like to start the vote for KIP-247:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 247%3A+Add+public+test+utils+for+Kafka+Streams
>
>
> -Matthias
>
>

Re: [VOTE] KIP-247: Add public test utils for Kafka Streams

[Damian Guy]

+1

On Thu, 18 Jan 2018 at 15:14 Bill Bejeck  wrote:

> Thanks for the KIP.
>
> +1
>
> -Bill
>
> On Wed, Jan 17, 2018 at 9:09 PM, Matthias J. Sax 
> wrote:
>
> > Hi,
> >
> > I would like to start the vote for KIP-247:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 247%3A+Add+public+test+utils+for+Kafka+Streams
> >
> >
> > -Matthias
> >
> >
>

[VOTE] KIP-247: Add public test utils for Kafka Streams

[Matthias J. Sax]

Hi,

I would like to start the vote for KIP-247:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-247%3A+Add+public+test+utils+for+Kafka+Streams


-Matthias



signature.asc
Description: OpenPGP digital signature