Re: [VOTE] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-05 Thread John Roesler
Thanks everyone,

Voting for KIP-274 has passed with 3 binding and 4 non-binding +1s (and no
objections).

Thanks for your time in considering this KIP,
-John

On Thu, Apr 5, 2018 at 4:48 AM, Damian Guy  wrote:

> +1
>
> On Thu, 5 Apr 2018 at 01:56 Matthias J. Sax  wrote:
>
> > +1 (binding) on the latest proposal.
> >
> >
> > -Matthias
> >
> >
> > On 4/2/18 12:10 PM, Richard Yu wrote:
> > > +1
> > >
> > > On Mon, Apr 2, 2018 at 8:42 AM, Guozhang Wang 
> > wrote:
> > >
> > >> +1 (binding).
> > >>
> > >> On Mon, Apr 2, 2018 at 7:22 AM, Ted Yu  wrote:
> > >>
> > >>> +1
> > >>>
> > >>> On Mon, Apr 2, 2018 at 7:11 AM, Bill Bejeck 
> wrote:
> > >>>
> >  Thanks for the KIP.
> > 
> >  +1
> > 
> >  -Bill
> > 
> >  On Mon, Apr 2, 2018 at 10:09 AM, John Roesler 
> > >> wrote:
> > 
> > > Dear Kafka community,
> > >
> > > I am proposing KIP-274 to improve visibility when Streams skips
> > >> invalid
> > > records.
> > >
> > > The proposal is to simplify the metrics and add warning logs.
> > >
> > > Please find details in the wiki:
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 274%3A+Kafka+Streams+Skipped+Records+Metrics
> > >
> > > Thanks,
> > >
> > > -John
> > >
> > 
> > >>>
> > >>
> > >>
> > >>
> > >> --
> > >> -- Guozhang
> > >>
> > >
> >
> >
>


Re: [VOTE] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-05 Thread Damian Guy
+1

On Thu, 5 Apr 2018 at 01:56 Matthias J. Sax  wrote:

> +1 (binding) on the latest proposal.
>
>
> -Matthias
>
>
> On 4/2/18 12:10 PM, Richard Yu wrote:
> > +1
> >
> > On Mon, Apr 2, 2018 at 8:42 AM, Guozhang Wang 
> wrote:
> >
> >> +1 (binding).
> >>
> >> On Mon, Apr 2, 2018 at 7:22 AM, Ted Yu  wrote:
> >>
> >>> +1
> >>>
> >>> On Mon, Apr 2, 2018 at 7:11 AM, Bill Bejeck  wrote:
> >>>
>  Thanks for the KIP.
> 
>  +1
> 
>  -Bill
> 
>  On Mon, Apr 2, 2018 at 10:09 AM, John Roesler 
> >> wrote:
> 
> > Dear Kafka community,
> >
> > I am proposing KIP-274 to improve visibility when Streams skips
> >> invalid
> > records.
> >
> > The proposal is to simplify the metrics and add warning logs.
> >
> > Please find details in the wiki:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 274%3A+Kafka+Streams+Skipped+Records+Metrics
> >
> > Thanks,
> >
> > -John
> >
> 
> >>>
> >>
> >>
> >>
> >> --
> >> -- Guozhang
> >>
> >
>
>


Re: [VOTE] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-04 Thread Matthias J. Sax
+1 (binding) on the latest proposal.


-Matthias


On 4/2/18 12:10 PM, Richard Yu wrote:
> +1
> 
> On Mon, Apr 2, 2018 at 8:42 AM, Guozhang Wang  wrote:
> 
>> +1 (binding).
>>
>> On Mon, Apr 2, 2018 at 7:22 AM, Ted Yu  wrote:
>>
>>> +1
>>>
>>> On Mon, Apr 2, 2018 at 7:11 AM, Bill Bejeck  wrote:
>>>
 Thanks for the KIP.

 +1

 -Bill

 On Mon, Apr 2, 2018 at 10:09 AM, John Roesler 
>> wrote:

> Dear Kafka community,
>
> I am proposing KIP-274 to improve visibility when Streams skips
>> invalid
> records.
>
> The proposal is to simplify the metrics and add warning logs.
>
> Please find details in the wiki:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 274%3A+Kafka+Streams+Skipped+Records+Metrics
>
> Thanks,
>
> -John
>

>>>
>>
>>
>>
>> --
>> -- Guozhang
>>
> 



signature.asc
Description: OpenPGP digital signature


Re: [VOTE] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-02 Thread Richard Yu
+1

On Mon, Apr 2, 2018 at 8:42 AM, Guozhang Wang  wrote:

> +1 (binding).
>
> On Mon, Apr 2, 2018 at 7:22 AM, Ted Yu  wrote:
>
> > +1
> >
> > On Mon, Apr 2, 2018 at 7:11 AM, Bill Bejeck  wrote:
> >
> > > Thanks for the KIP.
> > >
> > > +1
> > >
> > > -Bill
> > >
> > > On Mon, Apr 2, 2018 at 10:09 AM, John Roesler 
> wrote:
> > >
> > > > Dear Kafka community,
> > > >
> > > > I am proposing KIP-274 to improve visibility when Streams skips
> invalid
> > > > records.
> > > >
> > > > The proposal is to simplify the metrics and add warning logs.
> > > >
> > > > Please find details in the wiki:
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > > 274%3A+Kafka+Streams+Skipped+Records+Metrics
> > > >
> > > > Thanks,
> > > >
> > > > -John
> > > >
> > >
> >
>
>
>
> --
> -- Guozhang
>


Re: [VOTE] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-02 Thread Guozhang Wang
+1 (binding).

On Mon, Apr 2, 2018 at 7:22 AM, Ted Yu  wrote:

> +1
>
> On Mon, Apr 2, 2018 at 7:11 AM, Bill Bejeck  wrote:
>
> > Thanks for the KIP.
> >
> > +1
> >
> > -Bill
> >
> > On Mon, Apr 2, 2018 at 10:09 AM, John Roesler  wrote:
> >
> > > Dear Kafka community,
> > >
> > > I am proposing KIP-274 to improve visibility when Streams skips invalid
> > > records.
> > >
> > > The proposal is to simplify the metrics and add warning logs.
> > >
> > > Please find details in the wiki:
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > > 274%3A+Kafka+Streams+Skipped+Records+Metrics
> > >
> > > Thanks,
> > >
> > > -John
> > >
> >
>



-- 
-- Guozhang


Re: [VOTE] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-02 Thread Ted Yu
+1

On Mon, Apr 2, 2018 at 7:11 AM, Bill Bejeck  wrote:

> Thanks for the KIP.
>
> +1
>
> -Bill
>
> On Mon, Apr 2, 2018 at 10:09 AM, John Roesler  wrote:
>
> > Dear Kafka community,
> >
> > I am proposing KIP-274 to improve visibility when Streams skips invalid
> > records.
> >
> > The proposal is to simplify the metrics and add warning logs.
> >
> > Please find details in the wiki:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 274%3A+Kafka+Streams+Skipped+Records+Metrics
> >
> > Thanks,
> >
> > -John
> >
>


Re: [VOTE] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-02 Thread Bill Bejeck
Thanks for the KIP.

+1

-Bill

On Mon, Apr 2, 2018 at 10:09 AM, John Roesler  wrote:

> Dear Kafka community,
>
> I am proposing KIP-274 to improve visibility when Streams skips invalid
> records.
>
> The proposal is to simplify the metrics and add warning logs.
>
> Please find details in the wiki:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 274%3A+Kafka+Streams+Skipped+Records+Metrics
>
> Thanks,
>
> -John
>


[VOTE] KIP-274: Kafka Streams Skipped Records Metrics

2018-04-02 Thread John Roesler
Dear Kafka community,

I am proposing KIP-274 to improve visibility when Streams skips invalid records.

The proposal is to simplify the metrics and add warning logs.

Please find details in the wiki:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-274%3A+Kafka+Streams+Skipped+Records+Metrics

Thanks,

-John