Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
Hi all, Thanks for participating in the vote. With 3 binding +1 votes (Rajini Sivaram, Mickael Maison, David Jacot) and 2 non-binding +1 votes (Luke Chen, Lucas Bradstreet), the vote passes. I will update the KIP status then raise a PR later. Thanks, 2021年10月20日(水) 20:58 David Jacot : > +1 (binding). Thanks for the KIP! > > Best, > David > > On Wed, Oct 20, 2021 at 12:09 PM Haruki Okada wrote: > > > Currently, KIP-764 got > > +1 binding > > +2 non-binding > > > > votes. Could anyone help checking the KIP and join the vote? > > > > Thanks, > > > > 2021年10月18日(月) 18:21 Haruki Okada : > > > > > Hi Lucas. > > > > > > Thanks for the vote. > > > As far as I understand, it should be enough to adjust > > `net.core.somaxconn` > > > and `net.ipv4.tcp_max_syn_backlog` accordingly for allocating > sufficient > > > backlog size. > > > > > > > > > 2021年10月18日(月) 17:37 Lucas Bradstreet : > > > > > >> The other related kernel config that I can recall is > > >> net.ipv4.tcp_max_syn_backlog. > > >> > > >> On Mon, Oct 18, 2021 at 4:32 PM Lucas Bradstreet > > >> wrote: > > >> > > >> > Thank you for the KIP. +1 (non-binding) > > >> > > > >> > For the implementation can we ensure that any kernel parameters that > > may > > >> > need to also be adjusted are documented in the config documentation > > >> > (e.g. net.core.somaxconn)? > > >> > > > >> > > > >> > On Mon, Oct 18, 2021 at 4:23 PM Haruki Okada > > >> wrote: > > >> > > > >> >> Hi Luke. > > >> >> > > >> >> Thank you for the vote. > > >> >> Updated KIP to link to ServerSocket#bind javadoc. > > >> >> > > >> >> > > >> >> 2021年10月18日(月) 17:00 Luke Chen : > > >> >> > > >> >> > Hi Okada, > > >> >> > Thanks for the KIP. > > >> >> > +1 (non-binding) > > >> >> > > > >> >> > One thing to add is that you should add ServerSocket#bind java > doc > > >> link > > >> >> > into the KIP. > > >> >> > I don't think everyone is familiar with the definition of the > > method > > >> >> > parameters. > > >> >> > > > >> >> > Thank you. > > >> >> > Luke > > >> >> > > > >> >> > On Mon, Oct 18, 2021 at 3:43 PM Haruki Okada < > ocadar...@gmail.com> > > >> >> wrote: > > >> >> > > > >> >> > > Hi Kafka. > > >> >> > > > > >> >> > > Let me bump this VOTE thread for the KIP. > > >> >> > > We applied proposed changes in the KIP to our large Kafka > cluster > > >> by > > >> >> > > building patched Kafka internally and confirmed it's working > > well. > > >> >> > > > > >> >> > > Please feel free to give your feedback if there's any points to > > be > > >> >> > > clarified in the KIP. > > >> >> > > > > >> >> > > Thanks, > > >> >> > > > > >> >> > > 2021年8月9日(月) 11:25 Haruki Okada : > > >> >> > > > > >> >> > > > Thanks for your comment LI-san. > > >> >> > > > > > >> >> > > > Could anyone else review and vote for the KIP? > > >> >> > > > > > >> >> > > > I think the situation described in the KIP's motivation can > > >> happen > > >> >> in > > >> >> > any > > >> >> > > > large-scale Kafka deployment, so may be helpful for many > users > > >> while > > >> >> > the > > >> >> > > > proposed changes are small enough. > > >> >> > > > > > >> >> > > > > > >> >> > > > Thanks, > > >> >> > > > > > >> >> > > > 2021年8月3日(火) 15:49 Xiangyuan LI : > > >> >> > > > > > >> >> > > >> Hi Haruki Okada: > > >> >> > > >> i read your comment, thx for your detail explain! > > >> >> > > >> add backlog parameter is a useful suggestion, hope it > could > > >> >> added to > > >> >> > > >> kafka. > > >> >> > > >> > > >> >> > > >> Haruki Okada 于2021年8月2日周一 上午7:43写道: > > >> >> > > >> > > >> >> > > >> > Hi, Kafka. > > >> >> > > >> > > > >> >> > > >> > I would like to start a vote on KIP that makes > SocketServer > > >> >> > acceptor's > > >> >> > > >> > backlog size configurable. > > >> >> > > >> > > > >> >> > > >> > KIP: > > >> >> > > >> > > > >> >> > > >> > > > >> >> > > >> > > >> >> > > > > >> >> > > > >> >> > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor > > >> >> > > >> > > > >> >> > > >> > Discussion thread: > > >> >> > > >> > > > >> >> > > >> > > > >> >> > > >> > > >> >> > > > > >> >> > > > >> >> > > >> > > > https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E > > >> >> > > >> > > > >> >> > > >> > Thanks, > > >> >> > > >> > > > >> >> > > >> > -- > > >> >> > > >> > > > >> >> > > >> > Okada Haruki > > >> >> > > >> > ocadar...@gmail.com > > >> >> > > >> > > > >> >> > > >> > > > >> >> > > >> > > >> >> > > > > > >> >> > > > > > >> >> > > > -- > > >> >> > > > > > >> >> > > > Okada Haruki > > >> >> > > > ocadar...@gmail.com > > >> >> > > > > > >> >> > > > > > >> >> > > > > >> >> > > > > >> >> > > -- > > >> >> > > > > >> >> > > Okada Haruki > > >> >> > > ocadar...@gmail.com > > >> >> > > > > >> >> > > > > >> >> > > > >> >> > > >> >> > > >> >>
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
+1 (binding). Thanks for the KIP! Best, David On Wed, Oct 20, 2021 at 12:09 PM Haruki Okada wrote: > Currently, KIP-764 got > +1 binding > +2 non-binding > > votes. Could anyone help checking the KIP and join the vote? > > Thanks, > > 2021年10月18日(月) 18:21 Haruki Okada : > > > Hi Lucas. > > > > Thanks for the vote. > > As far as I understand, it should be enough to adjust > `net.core.somaxconn` > > and `net.ipv4.tcp_max_syn_backlog` accordingly for allocating sufficient > > backlog size. > > > > > > 2021年10月18日(月) 17:37 Lucas Bradstreet : > > > >> The other related kernel config that I can recall is > >> net.ipv4.tcp_max_syn_backlog. > >> > >> On Mon, Oct 18, 2021 at 4:32 PM Lucas Bradstreet > >> wrote: > >> > >> > Thank you for the KIP. +1 (non-binding) > >> > > >> > For the implementation can we ensure that any kernel parameters that > may > >> > need to also be adjusted are documented in the config documentation > >> > (e.g. net.core.somaxconn)? > >> > > >> > > >> > On Mon, Oct 18, 2021 at 4:23 PM Haruki Okada > >> wrote: > >> > > >> >> Hi Luke. > >> >> > >> >> Thank you for the vote. > >> >> Updated KIP to link to ServerSocket#bind javadoc. > >> >> > >> >> > >> >> 2021年10月18日(月) 17:00 Luke Chen : > >> >> > >> >> > Hi Okada, > >> >> > Thanks for the KIP. > >> >> > +1 (non-binding) > >> >> > > >> >> > One thing to add is that you should add ServerSocket#bind java doc > >> link > >> >> > into the KIP. > >> >> > I don't think everyone is familiar with the definition of the > method > >> >> > parameters. > >> >> > > >> >> > Thank you. > >> >> > Luke > >> >> > > >> >> > On Mon, Oct 18, 2021 at 3:43 PM Haruki Okada > >> >> wrote: > >> >> > > >> >> > > Hi Kafka. > >> >> > > > >> >> > > Let me bump this VOTE thread for the KIP. > >> >> > > We applied proposed changes in the KIP to our large Kafka cluster > >> by > >> >> > > building patched Kafka internally and confirmed it's working > well. > >> >> > > > >> >> > > Please feel free to give your feedback if there's any points to > be > >> >> > > clarified in the KIP. > >> >> > > > >> >> > > Thanks, > >> >> > > > >> >> > > 2021年8月9日(月) 11:25 Haruki Okada : > >> >> > > > >> >> > > > Thanks for your comment LI-san. > >> >> > > > > >> >> > > > Could anyone else review and vote for the KIP? > >> >> > > > > >> >> > > > I think the situation described in the KIP's motivation can > >> happen > >> >> in > >> >> > any > >> >> > > > large-scale Kafka deployment, so may be helpful for many users > >> while > >> >> > the > >> >> > > > proposed changes are small enough. > >> >> > > > > >> >> > > > > >> >> > > > Thanks, > >> >> > > > > >> >> > > > 2021年8月3日(火) 15:49 Xiangyuan LI : > >> >> > > > > >> >> > > >> Hi Haruki Okada: > >> >> > > >> i read your comment, thx for your detail explain! > >> >> > > >> add backlog parameter is a useful suggestion, hope it could > >> >> added to > >> >> > > >> kafka. > >> >> > > >> > >> >> > > >> Haruki Okada 于2021年8月2日周一 上午7:43写道: > >> >> > > >> > >> >> > > >> > Hi, Kafka. > >> >> > > >> > > >> >> > > >> > I would like to start a vote on KIP that makes SocketServer > >> >> > acceptor's > >> >> > > >> > backlog size configurable. > >> >> > > >> > > >> >> > > >> > KIP: > >> >> > > >> > > >> >> > > >> > > >> >> > > >> > >> >> > > > >> >> > > >> >> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor > >> >> > > >> > > >> >> > > >> > Discussion thread: > >> >> > > >> > > >> >> > > >> > > >> >> > > >> > >> >> > > > >> >> > > >> >> > >> > https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E > >> >> > > >> > > >> >> > > >> > Thanks, > >> >> > > >> > > >> >> > > >> > -- > >> >> > > >> > > >> >> > > >> > Okada Haruki > >> >> > > >> > ocadar...@gmail.com > >> >> > > >> > > >> >> > > >> > > >> >> > > >> > >> >> > > > > >> >> > > > > >> >> > > > -- > >> >> > > > > >> >> > > > Okada Haruki > >> >> > > > ocadar...@gmail.com > >> >> > > > > >> >> > > > > >> >> > > > >> >> > > > >> >> > > -- > >> >> > > > >> >> > > Okada Haruki > >> >> > > ocadar...@gmail.com > >> >> > > > >> >> > > > >> >> > > >> >> > >> >> > >> >> -- > >> >> > >> >> Okada Haruki > >> >> ocadar...@gmail.com > >> >> > >> >> > >> > > >> > > > > > > -- > > > > Okada Haruki > > ocadar...@gmail.com > > > > > > > -- > > Okada Haruki > ocadar...@gmail.com > >
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
Thanks for the KIP! I think the description/doc for the new setting needs some improvements but we can follow that up in the PR. +1 (binding) On Wed, Oct 20, 2021 at 12:09 PM Haruki Okada wrote: > > Currently, KIP-764 got > +1 binding > +2 non-binding > > votes. Could anyone help checking the KIP and join the vote? > > Thanks, > > 2021年10月18日(月) 18:21 Haruki Okada : > > > Hi Lucas. > > > > Thanks for the vote. > > As far as I understand, it should be enough to adjust `net.core.somaxconn` > > and `net.ipv4.tcp_max_syn_backlog` accordingly for allocating sufficient > > backlog size. > > > > > > 2021年10月18日(月) 17:37 Lucas Bradstreet : > > > >> The other related kernel config that I can recall is > >> net.ipv4.tcp_max_syn_backlog. > >> > >> On Mon, Oct 18, 2021 at 4:32 PM Lucas Bradstreet > >> wrote: > >> > >> > Thank you for the KIP. +1 (non-binding) > >> > > >> > For the implementation can we ensure that any kernel parameters that may > >> > need to also be adjusted are documented in the config documentation > >> > (e.g. net.core.somaxconn)? > >> > > >> > > >> > On Mon, Oct 18, 2021 at 4:23 PM Haruki Okada > >> wrote: > >> > > >> >> Hi Luke. > >> >> > >> >> Thank you for the vote. > >> >> Updated KIP to link to ServerSocket#bind javadoc. > >> >> > >> >> > >> >> 2021年10月18日(月) 17:00 Luke Chen : > >> >> > >> >> > Hi Okada, > >> >> > Thanks for the KIP. > >> >> > +1 (non-binding) > >> >> > > >> >> > One thing to add is that you should add ServerSocket#bind java doc > >> link > >> >> > into the KIP. > >> >> > I don't think everyone is familiar with the definition of the method > >> >> > parameters. > >> >> > > >> >> > Thank you. > >> >> > Luke > >> >> > > >> >> > On Mon, Oct 18, 2021 at 3:43 PM Haruki Okada > >> >> wrote: > >> >> > > >> >> > > Hi Kafka. > >> >> > > > >> >> > > Let me bump this VOTE thread for the KIP. > >> >> > > We applied proposed changes in the KIP to our large Kafka cluster > >> by > >> >> > > building patched Kafka internally and confirmed it's working well. > >> >> > > > >> >> > > Please feel free to give your feedback if there's any points to be > >> >> > > clarified in the KIP. > >> >> > > > >> >> > > Thanks, > >> >> > > > >> >> > > 2021年8月9日(月) 11:25 Haruki Okada : > >> >> > > > >> >> > > > Thanks for your comment LI-san. > >> >> > > > > >> >> > > > Could anyone else review and vote for the KIP? > >> >> > > > > >> >> > > > I think the situation described in the KIP's motivation can > >> happen > >> >> in > >> >> > any > >> >> > > > large-scale Kafka deployment, so may be helpful for many users > >> while > >> >> > the > >> >> > > > proposed changes are small enough. > >> >> > > > > >> >> > > > > >> >> > > > Thanks, > >> >> > > > > >> >> > > > 2021年8月3日(火) 15:49 Xiangyuan LI : > >> >> > > > > >> >> > > >> Hi Haruki Okada: > >> >> > > >> i read your comment, thx for your detail explain! > >> >> > > >> add backlog parameter is a useful suggestion, hope it could > >> >> added to > >> >> > > >> kafka. > >> >> > > >> > >> >> > > >> Haruki Okada 于2021年8月2日周一 上午7:43写道: > >> >> > > >> > >> >> > > >> > Hi, Kafka. > >> >> > > >> > > >> >> > > >> > I would like to start a vote on KIP that makes SocketServer > >> >> > acceptor's > >> >> > > >> > backlog size configurable. > >> >> > > >> > > >> >> > > >> > KIP: > >> >> > > >> > > >> >> > > >> > > >> >> > > >> > >> >> > > > >> >> > > >> >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor > >> >> > > >> > > >> >> > > >> > Discussion thread: > >> >> > > >> > > >> >> > > >> > > >> >> > > >> > >> >> > > > >> >> > > >> >> > >> https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E > >> >> > > >> > > >> >> > > >> > Thanks, > >> >> > > >> > > >> >> > > >> > -- > >> >> > > >> > > >> >> > > >> > Okada Haruki > >> >> > > >> > ocadar...@gmail.com > >> >> > > >> > > >> >> > > >> > > >> >> > > >> > >> >> > > > > >> >> > > > > >> >> > > > -- > >> >> > > > > >> >> > > > Okada Haruki > >> >> > > > ocadar...@gmail.com > >> >> > > > > >> >> > > > > >> >> > > > >> >> > > > >> >> > > -- > >> >> > > > >> >> > > Okada Haruki > >> >> > > ocadar...@gmail.com > >> >> > > > >> >> > > > >> >> > > >> >> > >> >> > >> >> -- > >> >> > >> >> Okada Haruki > >> >> ocadar...@gmail.com > >> >> > >> >> > >> > > >> > > > > > > -- > > > > Okada Haruki > > ocadar...@gmail.com > > > > > > > -- > > Okada Haruki > ocadar...@gmail.com >
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
Currently, KIP-764 got +1 binding +2 non-binding votes. Could anyone help checking the KIP and join the vote? Thanks, 2021年10月18日(月) 18:21 Haruki Okada : > Hi Lucas. > > Thanks for the vote. > As far as I understand, it should be enough to adjust `net.core.somaxconn` > and `net.ipv4.tcp_max_syn_backlog` accordingly for allocating sufficient > backlog size. > > > 2021年10月18日(月) 17:37 Lucas Bradstreet : > >> The other related kernel config that I can recall is >> net.ipv4.tcp_max_syn_backlog. >> >> On Mon, Oct 18, 2021 at 4:32 PM Lucas Bradstreet >> wrote: >> >> > Thank you for the KIP. +1 (non-binding) >> > >> > For the implementation can we ensure that any kernel parameters that may >> > need to also be adjusted are documented in the config documentation >> > (e.g. net.core.somaxconn)? >> > >> > >> > On Mon, Oct 18, 2021 at 4:23 PM Haruki Okada >> wrote: >> > >> >> Hi Luke. >> >> >> >> Thank you for the vote. >> >> Updated KIP to link to ServerSocket#bind javadoc. >> >> >> >> >> >> 2021年10月18日(月) 17:00 Luke Chen : >> >> >> >> > Hi Okada, >> >> > Thanks for the KIP. >> >> > +1 (non-binding) >> >> > >> >> > One thing to add is that you should add ServerSocket#bind java doc >> link >> >> > into the KIP. >> >> > I don't think everyone is familiar with the definition of the method >> >> > parameters. >> >> > >> >> > Thank you. >> >> > Luke >> >> > >> >> > On Mon, Oct 18, 2021 at 3:43 PM Haruki Okada >> >> wrote: >> >> > >> >> > > Hi Kafka. >> >> > > >> >> > > Let me bump this VOTE thread for the KIP. >> >> > > We applied proposed changes in the KIP to our large Kafka cluster >> by >> >> > > building patched Kafka internally and confirmed it's working well. >> >> > > >> >> > > Please feel free to give your feedback if there's any points to be >> >> > > clarified in the KIP. >> >> > > >> >> > > Thanks, >> >> > > >> >> > > 2021年8月9日(月) 11:25 Haruki Okada : >> >> > > >> >> > > > Thanks for your comment LI-san. >> >> > > > >> >> > > > Could anyone else review and vote for the KIP? >> >> > > > >> >> > > > I think the situation described in the KIP's motivation can >> happen >> >> in >> >> > any >> >> > > > large-scale Kafka deployment, so may be helpful for many users >> while >> >> > the >> >> > > > proposed changes are small enough. >> >> > > > >> >> > > > >> >> > > > Thanks, >> >> > > > >> >> > > > 2021年8月3日(火) 15:49 Xiangyuan LI : >> >> > > > >> >> > > >> Hi Haruki Okada: >> >> > > >> i read your comment, thx for your detail explain! >> >> > > >> add backlog parameter is a useful suggestion, hope it could >> >> added to >> >> > > >> kafka. >> >> > > >> >> >> > > >> Haruki Okada 于2021年8月2日周一 上午7:43写道: >> >> > > >> >> >> > > >> > Hi, Kafka. >> >> > > >> > >> >> > > >> > I would like to start a vote on KIP that makes SocketServer >> >> > acceptor's >> >> > > >> > backlog size configurable. >> >> > > >> > >> >> > > >> > KIP: >> >> > > >> > >> >> > > >> > >> >> > > >> >> >> > > >> >> > >> >> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor >> >> > > >> > >> >> > > >> > Discussion thread: >> >> > > >> > >> >> > > >> > >> >> > > >> >> >> > > >> >> > >> >> >> https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E >> >> > > >> > >> >> > > >> > Thanks, >> >> > > >> > >> >> > > >> > -- >> >> > > >> > >> >> > > >> > Okada Haruki >> >> > > >> > ocadar...@gmail.com >> >> > > >> > >> >> > > >> > >> >> > > >> >> >> > > > >> >> > > > >> >> > > > -- >> >> > > > >> >> > > > Okada Haruki >> >> > > > ocadar...@gmail.com >> >> > > > >> >> > > > >> >> > > >> >> > > >> >> > > -- >> >> > > >> >> > > Okada Haruki >> >> > > ocadar...@gmail.com >> >> > > >> >> > > >> >> > >> >> >> >> >> >> -- >> >> >> >> Okada Haruki >> >> ocadar...@gmail.com >> >> >> >> >> > >> > > > -- > > Okada Haruki > ocadar...@gmail.com > > -- Okada Haruki ocadar...@gmail.com
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
Hi Lucas. Thanks for the vote. As far as I understand, it should be enough to adjust `net.core.somaxconn` and `net.ipv4.tcp_max_syn_backlog` accordingly for allocating sufficient backlog size. 2021年10月18日(月) 17:37 Lucas Bradstreet : > The other related kernel config that I can recall is > net.ipv4.tcp_max_syn_backlog. > > On Mon, Oct 18, 2021 at 4:32 PM Lucas Bradstreet > wrote: > > > Thank you for the KIP. +1 (non-binding) > > > > For the implementation can we ensure that any kernel parameters that may > > need to also be adjusted are documented in the config documentation > > (e.g. net.core.somaxconn)? > > > > > > On Mon, Oct 18, 2021 at 4:23 PM Haruki Okada > wrote: > > > >> Hi Luke. > >> > >> Thank you for the vote. > >> Updated KIP to link to ServerSocket#bind javadoc. > >> > >> > >> 2021年10月18日(月) 17:00 Luke Chen : > >> > >> > Hi Okada, > >> > Thanks for the KIP. > >> > +1 (non-binding) > >> > > >> > One thing to add is that you should add ServerSocket#bind java doc > link > >> > into the KIP. > >> > I don't think everyone is familiar with the definition of the method > >> > parameters. > >> > > >> > Thank you. > >> > Luke > >> > > >> > On Mon, Oct 18, 2021 at 3:43 PM Haruki Okada > >> wrote: > >> > > >> > > Hi Kafka. > >> > > > >> > > Let me bump this VOTE thread for the KIP. > >> > > We applied proposed changes in the KIP to our large Kafka cluster by > >> > > building patched Kafka internally and confirmed it's working well. > >> > > > >> > > Please feel free to give your feedback if there's any points to be > >> > > clarified in the KIP. > >> > > > >> > > Thanks, > >> > > > >> > > 2021年8月9日(月) 11:25 Haruki Okada : > >> > > > >> > > > Thanks for your comment LI-san. > >> > > > > >> > > > Could anyone else review and vote for the KIP? > >> > > > > >> > > > I think the situation described in the KIP's motivation can happen > >> in > >> > any > >> > > > large-scale Kafka deployment, so may be helpful for many users > while > >> > the > >> > > > proposed changes are small enough. > >> > > > > >> > > > > >> > > > Thanks, > >> > > > > >> > > > 2021年8月3日(火) 15:49 Xiangyuan LI : > >> > > > > >> > > >> Hi Haruki Okada: > >> > > >> i read your comment, thx for your detail explain! > >> > > >> add backlog parameter is a useful suggestion, hope it could > >> added to > >> > > >> kafka. > >> > > >> > >> > > >> Haruki Okada 于2021年8月2日周一 上午7:43写道: > >> > > >> > >> > > >> > Hi, Kafka. > >> > > >> > > >> > > >> > I would like to start a vote on KIP that makes SocketServer > >> > acceptor's > >> > > >> > backlog size configurable. > >> > > >> > > >> > > >> > KIP: > >> > > >> > > >> > > >> > > >> > > >> > >> > > > >> > > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor > >> > > >> > > >> > > >> > Discussion thread: > >> > > >> > > >> > > >> > > >> > > >> > >> > > > >> > > >> > https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E > >> > > >> > > >> > > >> > Thanks, > >> > > >> > > >> > > >> > -- > >> > > >> > > >> > > >> > Okada Haruki > >> > > >> > ocadar...@gmail.com > >> > > >> > > >> > > >> > > >> > > >> > >> > > > > >> > > > > >> > > > -- > >> > > > > >> > > > Okada Haruki > >> > > > ocadar...@gmail.com > >> > > > > >> > > > > >> > > > >> > > > >> > > -- > >> > > > >> > > Okada Haruki > >> > > ocadar...@gmail.com > >> > > > >> > > > >> > > >> > >> > >> -- > >> > >> Okada Haruki > >> ocadar...@gmail.com > >> > >> > > > -- Okada Haruki ocadar...@gmail.com
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
The other related kernel config that I can recall is net.ipv4.tcp_max_syn_backlog. On Mon, Oct 18, 2021 at 4:32 PM Lucas Bradstreet wrote: > Thank you for the KIP. +1 (non-binding) > > For the implementation can we ensure that any kernel parameters that may > need to also be adjusted are documented in the config documentation > (e.g. net.core.somaxconn)? > > > On Mon, Oct 18, 2021 at 4:23 PM Haruki Okada wrote: > >> Hi Luke. >> >> Thank you for the vote. >> Updated KIP to link to ServerSocket#bind javadoc. >> >> >> 2021年10月18日(月) 17:00 Luke Chen : >> >> > Hi Okada, >> > Thanks for the KIP. >> > +1 (non-binding) >> > >> > One thing to add is that you should add ServerSocket#bind java doc link >> > into the KIP. >> > I don't think everyone is familiar with the definition of the method >> > parameters. >> > >> > Thank you. >> > Luke >> > >> > On Mon, Oct 18, 2021 at 3:43 PM Haruki Okada >> wrote: >> > >> > > Hi Kafka. >> > > >> > > Let me bump this VOTE thread for the KIP. >> > > We applied proposed changes in the KIP to our large Kafka cluster by >> > > building patched Kafka internally and confirmed it's working well. >> > > >> > > Please feel free to give your feedback if there's any points to be >> > > clarified in the KIP. >> > > >> > > Thanks, >> > > >> > > 2021年8月9日(月) 11:25 Haruki Okada : >> > > >> > > > Thanks for your comment LI-san. >> > > > >> > > > Could anyone else review and vote for the KIP? >> > > > >> > > > I think the situation described in the KIP's motivation can happen >> in >> > any >> > > > large-scale Kafka deployment, so may be helpful for many users while >> > the >> > > > proposed changes are small enough. >> > > > >> > > > >> > > > Thanks, >> > > > >> > > > 2021年8月3日(火) 15:49 Xiangyuan LI : >> > > > >> > > >> Hi Haruki Okada: >> > > >> i read your comment, thx for your detail explain! >> > > >> add backlog parameter is a useful suggestion, hope it could >> added to >> > > >> kafka. >> > > >> >> > > >> Haruki Okada 于2021年8月2日周一 上午7:43写道: >> > > >> >> > > >> > Hi, Kafka. >> > > >> > >> > > >> > I would like to start a vote on KIP that makes SocketServer >> > acceptor's >> > > >> > backlog size configurable. >> > > >> > >> > > >> > KIP: >> > > >> > >> > > >> > >> > > >> >> > > >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor >> > > >> > >> > > >> > Discussion thread: >> > > >> > >> > > >> > >> > > >> >> > > >> > >> https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E >> > > >> > >> > > >> > Thanks, >> > > >> > >> > > >> > -- >> > > >> > >> > > >> > Okada Haruki >> > > >> > ocadar...@gmail.com >> > > >> > >> > > >> > >> > > >> >> > > > >> > > > >> > > > -- >> > > > >> > > > Okada Haruki >> > > > ocadar...@gmail.com >> > > > >> > > > >> > > >> > > >> > > -- >> > > >> > > Okada Haruki >> > > ocadar...@gmail.com >> > > >> > > >> > >> >> >> -- >> >> Okada Haruki >> ocadar...@gmail.com >> >> >
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
Thank you for the KIP. +1 (non-binding) For the implementation can we ensure that any kernel parameters that may need to also be adjusted are documented in the config documentation (e.g. net.core.somaxconn)? On Mon, Oct 18, 2021 at 4:23 PM Haruki Okada wrote: > Hi Luke. > > Thank you for the vote. > Updated KIP to link to ServerSocket#bind javadoc. > > > 2021年10月18日(月) 17:00 Luke Chen : > > > Hi Okada, > > Thanks for the KIP. > > +1 (non-binding) > > > > One thing to add is that you should add ServerSocket#bind java doc link > > into the KIP. > > I don't think everyone is familiar with the definition of the method > > parameters. > > > > Thank you. > > Luke > > > > On Mon, Oct 18, 2021 at 3:43 PM Haruki Okada > wrote: > > > > > Hi Kafka. > > > > > > Let me bump this VOTE thread for the KIP. > > > We applied proposed changes in the KIP to our large Kafka cluster by > > > building patched Kafka internally and confirmed it's working well. > > > > > > Please feel free to give your feedback if there's any points to be > > > clarified in the KIP. > > > > > > Thanks, > > > > > > 2021年8月9日(月) 11:25 Haruki Okada : > > > > > > > Thanks for your comment LI-san. > > > > > > > > Could anyone else review and vote for the KIP? > > > > > > > > I think the situation described in the KIP's motivation can happen in > > any > > > > large-scale Kafka deployment, so may be helpful for many users while > > the > > > > proposed changes are small enough. > > > > > > > > > > > > Thanks, > > > > > > > > 2021年8月3日(火) 15:49 Xiangyuan LI : > > > > > > > >> Hi Haruki Okada: > > > >> i read your comment, thx for your detail explain! > > > >> add backlog parameter is a useful suggestion, hope it could added > to > > > >> kafka. > > > >> > > > >> Haruki Okada 于2021年8月2日周一 上午7:43写道: > > > >> > > > >> > Hi, Kafka. > > > >> > > > > >> > I would like to start a vote on KIP that makes SocketServer > > acceptor's > > > >> > backlog size configurable. > > > >> > > > > >> > KIP: > > > >> > > > > >> > > > > >> > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor > > > >> > > > > >> > Discussion thread: > > > >> > > > > >> > > > > >> > > > > > > https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E > > > >> > > > > >> > Thanks, > > > >> > > > > >> > -- > > > >> > > > > >> > Okada Haruki > > > >> > ocadar...@gmail.com > > > >> > > > > >> > > > > >> > > > > > > > > > > > > -- > > > > > > > > Okada Haruki > > > > ocadar...@gmail.com > > > > > > > > > > > > > > > > > -- > > > > > > Okada Haruki > > > ocadar...@gmail.com > > > > > > > > > > > -- > > Okada Haruki > ocadar...@gmail.com > >
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
Hi Haruki Okada, +1 (binding) Thanks for the KIP! Regards, Rajini On Mon, Oct 18, 2021 at 9:23 AM Haruki Okada wrote: > Hi Luke. > > Thank you for the vote. > Updated KIP to link to ServerSocket#bind javadoc. > > > 2021年10月18日(月) 17:00 Luke Chen : > > > Hi Okada, > > Thanks for the KIP. > > +1 (non-binding) > > > > One thing to add is that you should add ServerSocket#bind java doc link > > into the KIP. > > I don't think everyone is familiar with the definition of the method > > parameters. > > > > Thank you. > > Luke > > > > On Mon, Oct 18, 2021 at 3:43 PM Haruki Okada > wrote: > > > > > Hi Kafka. > > > > > > Let me bump this VOTE thread for the KIP. > > > We applied proposed changes in the KIP to our large Kafka cluster by > > > building patched Kafka internally and confirmed it's working well. > > > > > > Please feel free to give your feedback if there's any points to be > > > clarified in the KIP. > > > > > > Thanks, > > > > > > 2021年8月9日(月) 11:25 Haruki Okada : > > > > > > > Thanks for your comment LI-san. > > > > > > > > Could anyone else review and vote for the KIP? > > > > > > > > I think the situation described in the KIP's motivation can happen in > > any > > > > large-scale Kafka deployment, so may be helpful for many users while > > the > > > > proposed changes are small enough. > > > > > > > > > > > > Thanks, > > > > > > > > 2021年8月3日(火) 15:49 Xiangyuan LI : > > > > > > > >> Hi Haruki Okada: > > > >> i read your comment, thx for your detail explain! > > > >> add backlog parameter is a useful suggestion, hope it could added > to > > > >> kafka. > > > >> > > > >> Haruki Okada 于2021年8月2日周一 上午7:43写道: > > > >> > > > >> > Hi, Kafka. > > > >> > > > > >> > I would like to start a vote on KIP that makes SocketServer > > acceptor's > > > >> > backlog size configurable. > > > >> > > > > >> > KIP: > > > >> > > > > >> > > > > >> > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor > > > >> > > > > >> > Discussion thread: > > > >> > > > > >> > > > > >> > > > > > > https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E > > > >> > > > > >> > Thanks, > > > >> > > > > >> > -- > > > >> > > > > >> > Okada Haruki > > > >> > ocadar...@gmail.com > > > >> > > > > >> > > > > >> > > > > > > > > > > > > -- > > > > > > > > Okada Haruki > > > > ocadar...@gmail.com > > > > > > > > > > > > > > > > > -- > > > > > > Okada Haruki > > > ocadar...@gmail.com > > > > > > > > > > > -- > > Okada Haruki > ocadar...@gmail.com > >
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
Hi Luke. Thank you for the vote. Updated KIP to link to ServerSocket#bind javadoc. 2021年10月18日(月) 17:00 Luke Chen : > Hi Okada, > Thanks for the KIP. > +1 (non-binding) > > One thing to add is that you should add ServerSocket#bind java doc link > into the KIP. > I don't think everyone is familiar with the definition of the method > parameters. > > Thank you. > Luke > > On Mon, Oct 18, 2021 at 3:43 PM Haruki Okada wrote: > > > Hi Kafka. > > > > Let me bump this VOTE thread for the KIP. > > We applied proposed changes in the KIP to our large Kafka cluster by > > building patched Kafka internally and confirmed it's working well. > > > > Please feel free to give your feedback if there's any points to be > > clarified in the KIP. > > > > Thanks, > > > > 2021年8月9日(月) 11:25 Haruki Okada : > > > > > Thanks for your comment LI-san. > > > > > > Could anyone else review and vote for the KIP? > > > > > > I think the situation described in the KIP's motivation can happen in > any > > > large-scale Kafka deployment, so may be helpful for many users while > the > > > proposed changes are small enough. > > > > > > > > > Thanks, > > > > > > 2021年8月3日(火) 15:49 Xiangyuan LI : > > > > > >> Hi Haruki Okada: > > >> i read your comment, thx for your detail explain! > > >> add backlog parameter is a useful suggestion, hope it could added to > > >> kafka. > > >> > > >> Haruki Okada 于2021年8月2日周一 上午7:43写道: > > >> > > >> > Hi, Kafka. > > >> > > > >> > I would like to start a vote on KIP that makes SocketServer > acceptor's > > >> > backlog size configurable. > > >> > > > >> > KIP: > > >> > > > >> > > > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor > > >> > > > >> > Discussion thread: > > >> > > > >> > > > >> > > > https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E > > >> > > > >> > Thanks, > > >> > > > >> > -- > > >> > > > >> > Okada Haruki > > >> > ocadar...@gmail.com > > >> > > > >> > > > >> > > > > > > > > > -- > > > > > > Okada Haruki > > > ocadar...@gmail.com > > > > > > > > > > > > -- > > > > Okada Haruki > > ocadar...@gmail.com > > > > > -- Okada Haruki ocadar...@gmail.com
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
Hi Okada, Thanks for the KIP. +1 (non-binding) One thing to add is that you should add ServerSocket#bind java doc link into the KIP. I don't think everyone is familiar with the definition of the method parameters. Thank you. Luke On Mon, Oct 18, 2021 at 3:43 PM Haruki Okada wrote: > Hi Kafka. > > Let me bump this VOTE thread for the KIP. > We applied proposed changes in the KIP to our large Kafka cluster by > building patched Kafka internally and confirmed it's working well. > > Please feel free to give your feedback if there's any points to be > clarified in the KIP. > > Thanks, > > 2021年8月9日(月) 11:25 Haruki Okada : > > > Thanks for your comment LI-san. > > > > Could anyone else review and vote for the KIP? > > > > I think the situation described in the KIP's motivation can happen in any > > large-scale Kafka deployment, so may be helpful for many users while the > > proposed changes are small enough. > > > > > > Thanks, > > > > 2021年8月3日(火) 15:49 Xiangyuan LI : > > > >> Hi Haruki Okada: > >> i read your comment, thx for your detail explain! > >> add backlog parameter is a useful suggestion, hope it could added to > >> kafka. > >> > >> Haruki Okada 于2021年8月2日周一 上午7:43写道: > >> > >> > Hi, Kafka. > >> > > >> > I would like to start a vote on KIP that makes SocketServer acceptor's > >> > backlog size configurable. > >> > > >> > KIP: > >> > > >> > > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor > >> > > >> > Discussion thread: > >> > > >> > > >> > https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E > >> > > >> > Thanks, > >> > > >> > -- > >> > > >> > Okada Haruki > >> > ocadar...@gmail.com > >> > > >> > > >> > > > > > > -- > > > > Okada Haruki > > ocadar...@gmail.com > > > > > > > -- > > Okada Haruki > ocadar...@gmail.com > >
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
Hi Kafka. Let me bump this VOTE thread for the KIP. We applied proposed changes in the KIP to our large Kafka cluster by building patched Kafka internally and confirmed it's working well. Please feel free to give your feedback if there's any points to be clarified in the KIP. Thanks, 2021年8月9日(月) 11:25 Haruki Okada : > Thanks for your comment LI-san. > > Could anyone else review and vote for the KIP? > > I think the situation described in the KIP's motivation can happen in any > large-scale Kafka deployment, so may be helpful for many users while the > proposed changes are small enough. > > > Thanks, > > 2021年8月3日(火) 15:49 Xiangyuan LI : > >> Hi Haruki Okada: >> i read your comment, thx for your detail explain! >> add backlog parameter is a useful suggestion, hope it could added to >> kafka. >> >> Haruki Okada 于2021年8月2日周一 上午7:43写道: >> >> > Hi, Kafka. >> > >> > I would like to start a vote on KIP that makes SocketServer acceptor's >> > backlog size configurable. >> > >> > KIP: >> > >> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor >> > >> > Discussion thread: >> > >> > >> https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E >> > >> > Thanks, >> > >> > -- >> > >> > Okada Haruki >> > ocadar...@gmail.com >> > >> > >> > > > -- > > Okada Haruki > ocadar...@gmail.com > > -- Okada Haruki ocadar...@gmail.com
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
Thanks for your comment LI-san. Could anyone else review and vote for the KIP? I think the situation described in the KIP's motivation can happen in any large-scale Kafka deployment, so may be helpful for many users while the proposed changes are small enough. Thanks, 2021年8月3日(火) 15:49 Xiangyuan LI : > Hi Haruki Okada: > i read your comment, thx for your detail explain! > add backlog parameter is a useful suggestion, hope it could added to > kafka. > > Haruki Okada 于2021年8月2日周一 上午7:43写道: > > > Hi, Kafka. > > > > I would like to start a vote on KIP that makes SocketServer acceptor's > > backlog size configurable. > > > > KIP: > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor > > > > Discussion thread: > > > > > https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E > > > > Thanks, > > > > -- > > > > Okada Haruki > > ocadar...@gmail.com > > > > > -- Okada Haruki ocadar...@gmail.com
Re: [VOTE] KIP-764 Configurable backlog size for creating Acceptor
Hi Haruki Okada: i read your comment, thx for your detail explain! add backlog parameter is a useful suggestion, hope it could added to kafka. Haruki Okada 于2021年8月2日周一 上午7:43写道: > Hi, Kafka. > > I would like to start a vote on KIP that makes SocketServer acceptor's > backlog size configurable. > > KIP: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor > > Discussion thread: > > https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E > > Thanks, > > -- > > Okada Haruki > ocadar...@gmail.com > >
[VOTE] KIP-764 Configurable backlog size for creating Acceptor
Hi, Kafka. I would like to start a vote on KIP that makes SocketServer acceptor's backlog size configurable. KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-764%3A+Configurable+backlog+size+for+creating+Acceptor Discussion thread: https://lists.apache.org/thread.html/rd77469b7de0190d601dd37bd6894e1352a674d08038bcfe7ff68a1e0%40%3Cdev.kafka.apache.org%3E Thanks, -- Okada Haruki ocadar...@gmail.com