[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049123#comment-14049123 ] Jun Rao commented on KAFKA-1308: Jakob, Do you plan to commit the patch to trunk too? Thanks, Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Assignee: Jakob Homan Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-2.patch, KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049520#comment-14049520 ] Jakob Homan commented on KAFKA-1308: Yes, had a merge conflict when I went to do so; will resolve tomorrow and commit. Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Assignee: Jakob Homan Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-2.patch, KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042455#comment-14042455 ] Neha Narkhede commented on KAFKA-1308: -- +1 on KAFKA-1308-v2.patch. Thanks Jakob! Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-2.patch, KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042700#comment-14042700 ] Jakob Homan commented on KAFKA-1308: We're still blocked on the Samza release even with this patch because the snapshots I'm publishing are being cleaned on a daily basis. To get around this I would like to publish the 0.8.1.1 release to the main maven site using this patch: * Use the rc1 tgz that was voted in as 0.8.1.1 as the release (https://people.apache.org/~joestein/kafka-0.8.1.1-candidate1/kafka-0.8.1.1-src.tgz) * Apply the patch, remove the -SNAPSHOT * Run ./gradlew uploadArchivesAll against the main repo, publishing the test jar and all of the original jars. This is ASF-ok since this patch does not change anything about the code that was generated, just publishes an extra jar on top of what was previously published. This will unblock us since we can then pull from the main repo. The alternative is to wait for Kafka to release a 0.8.1.2 (or whatever), which would add an extra week or more for the vote to run. Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-2.patch, KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042744#comment-14042744 ] Joe Stein commented on KAFKA-1308: -- I am +1 to Jakob's suggestion and I can do this in a couple of hours if others agree (not sure we need a vote I think we are good with just the commit and upload release what is there no code change) Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-2.patch, KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042749#comment-14042749 ] Joe Stein commented on KAFKA-1308: -- which patch(s) would apply to the 0.8.1.1 tag? it looks like I would apply KAFKA-1308-8.1.1.patch and then kafka-1308_v2_0.8.1.patch also I don't see the SNAPSHOT change in either patch it looks like only in KAFKA-1308-2.patch just so we are all saying the same thing we are expecting Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-2.patch, KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042755#comment-14042755 ] Neha Narkhede commented on KAFKA-1308: -- I'm also +1 on Jakob's suggestion. Joe, thanks for picking it up. Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-2.patch, KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042775#comment-14042775 ] Jakob Homan commented on KAFKA-1308: Yes, just KAFKA-1308-2.patch (and then manually remove the -SNAPSHOT) designation. This patch has been +1'ed by Neha and I intend to commit it to trunk and the 0.8.1.1 branch. I've been using this patch to publish snapshots and testing those against Samza, so I'm confident the patch itself is good. Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-2.patch, KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042776#comment-14042776 ] Jakob Homan commented on KAFKA-1308: If no one is opposed, I'll go ahead and do it now. Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-2.patch, KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042804#comment-14042804 ] Joe Stein commented on KAFKA-1308: -- Sounds good, I will wait for the commit to the 0.8.1 branch and then push the jar to maven staging , then will post here again for your +1 before shipping to central Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-2.patch, KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042818#comment-14042818 ] Jakob Homan commented on KAFKA-1308: I've committed this to 0.8.1. I had already staged the jars, so I just went ahead and promoted the release to central as well. Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-2.patch, KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039246#comment-14039246 ] Jakob Homan commented on KAFKA-1308: Yes, we need the pom. Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch, kafka-1308_v2_0.8.1.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14037468#comment-14037468 ] Chris Campbell commented on KAFKA-1308: --- For what its worth, the main reason I created a separate jar for the patch was this message, which seemed to imply that it's not useful to ship the test cases: http://mail-archives.apache.org/mod_mbox/kafka-users/201308.mbox/%3ccaoejijgjppc+m+xqeyrninjcmq9vsjfzp3efhvaknbdjndl...@mail.gmail.com%3E If there are other classes that people want to use, it seems better to include them in this separately published jar to help make it clear what is meant to be fit for public consumption, rather than just a wholesale dump of test classes. But it's not a big deal either way :) Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038469#comment-14038469 ] Jakob Homan commented on KAFKA-1308: The patches are identical, just slight differing in line numbers. Git applied the 8.1.1 to trunk with no problems, but still made two patches for clarity. Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038473#comment-14038473 ] Jakob Homan commented on KAFKA-1308: rb: https://reviews.apache.org/r/22802/ Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308-8.1.1.patch, KAFKA-1308.patch, KAFKA-1308.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14035969#comment-14035969 ] Ivan Lyutov commented on KAFKA-1308: +1 Patch looks nice. It might be very useful. Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036961#comment-14036961 ] Jun Rao commented on KAFKA-1308: Thanks for the patch. I am not sure if it's worthwhile to create a separate jar just for TestUtils. There could be other classes that people may want to use. It seems that we just need to publish the test jar to maven. Joe Stein, Do you think you can upload the test jars for 0.8.1.1 to maven? Thanks, Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Priority: Blocker Fix For: 0.8.2 Attachments: KAFKA-1308.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13994880#comment-13994880 ] Mikael Högqvist commented on KAFKA-1308: +1 TestUtils are very useful for us as well. Publish jar of test utilities to Maven -- Key: KAFKA-1308 URL: https://issues.apache.org/jira/browse/KAFKA-1308 Project: Kafka Issue Type: Wish Affects Versions: 0.8.1 Reporter: Martin Kleppmann Fix For: 0.8.2 Attachments: KAFKA-1308.patch For projects that use Kafka, and want to write tests that exercise Kafka (in our case, Samza), it's useful to have access to Kafka's test utility classes such as kafka.zk.EmbeddedZookeeper and kafka.utils.TestUtils. We can use {{./gradlew testJar}} to build jar files that contain those classes, but as far as I know, these are currently not made available in a binary release. At the moment, we have to check those kafka*-test.jar files into the Samza repository. To avoid that, would it be possible to publish those jars of tests to Maven, so that they fit into the normal dependency management? Or perhaps, if publishing the tests themselves is not appropriate, we could move the test utilities into a separate module that is published, and make the tests depend on that module? -- This message was sent by Atlassian JIRA (v6.2#6252)