[jira] [Commented] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050221#comment-14050221 ] Jun Rao commented on KAFKA-1513: Thanks for the patch. Could server be just val? Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: cleanup-kafkaserverstartable-code-v1.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050261#comment-14050261 ] Evgeny Vereshchagin commented on KAFKA-1513: Looks like server could be just val. I changed var to val and run tests. It's ok. But I'm not sure that this change don't break something. I'm reading dependent code. I'll update patch if can understand that change safety. Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: cleanup-kafkaserverstartable-code-v1.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050303#comment-14050303 ] Evgeny Vereshchagin commented on KAFKA-1513: Yes, It's ok. I want to remove type declaration (: KafkaServer) because type it's obvious by constructor name. I can't find in guide recommends about type inference usage. Drop it or explicit better than implicit? Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: cleanup-kafkaserverstartable-code-v1.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050623#comment-14050623 ] Evgeny Vereshchagin commented on KAFKA-1513: Submit new [patch|https://issues.apache.org/jira/secure/attachment/12653670/cleanup-kafkaserverstartable-code-v2.patch] Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: cleanup-kafkaserverstartable-code-v1.patch, cleanup-kafkaserverstartable-code-v2.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1513) Cleanup KafkaServerStartable code
[ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051001#comment-14051001 ] Evgeny Vereshchagin commented on KAFKA-1513: Created reviewboard https://reviews.apache.org/r/23255/diff/ against branch origin/trunk Cleanup KafkaServerStartable code - Key: KAFKA-1513 URL: https://issues.apache.org/jira/browse/KAFKA-1513 Project: Kafka Issue Type: Improvement Components: core Reporter: Evgeny Vereshchagin Priority: Minor Attachments: KAFKA-1513.patch, cleanup-kafkaserverstartable-code-v1.patch, cleanup-kafkaserverstartable-code-v2.patch [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand. Var initialization would be simpler for readers. Patch will be soon. It's my first time:) -- This message was sent by Atlassian JIRA (v6.2#6252)
