[jira] [Commented] (KAFKA-1543) Changing replication factor
[
https://issues.apache.org/jira/browse/KAFKA-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779114#comment-15779114
]
ASF GitHub Bot commented on KAFKA-1543:
---
Github user pono closed the pull request at:
https://github.com/apache/kafka/pull/161
> Changing replication factor
> ---
>
> Key: KAFKA-1543
> URL: https://issues.apache.org/jira/browse/KAFKA-1543
> Project: Kafka
> Issue Type: Improvement
>Reporter: Alexey Ozeritskiy
>Assignee: Alexander Pakulov
> Attachments: can-change-replication.patch
>
>
> It is difficult to change replication factor by manual editing json config.
> I propose to add a key to kafka-reassign-partitions.sh command to
> automatically create json config.
> Example of usage
> {code}
> kafka-reassign-partitions.sh --zookeeper zk --replicas new-replication-factor
> --topics-to-move-json-file topics-file --broker-list 1,2,3,4 --generate >
> output
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1543) Changing replication factor
[
https://issues.apache.org/jira/browse/KAFKA-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15365357#comment-15365357
]
Richard Lee commented on KAFKA-1543:
This jira item seems orphaned. Anyway, I took another stab at this in the
0.10.1.0 branch. See https://github.com/apache/kafka/pull/1596
I decided that kafka-topics.sh might not be the best place to change
replication factor, since it can have a pretty heavy impact on partition
assignment in the cluster. So, left it in kafka-reassign-partitions.sh, but
made it a per-topic config rather than a global command line argument, so that
each topic can specify its own replication factor.
Also, as kafka-reassign-partitions.sh is intended to operate on a running
cluster with --verify feedback of progress, it seems more likely to sidestep
any issues that would require cluster restart.
> Changing replication factor
> ---
>
> Key: KAFKA-1543
> URL: https://issues.apache.org/jira/browse/KAFKA-1543
> Project: Kafka
> Issue Type: Improvement
>Reporter: Alexey Ozeritskiy
>Assignee: Alexander Pakulov
> Attachments: can-change-replication.patch
>
>
> It is difficult to change replication factor by manual editing json config.
> I propose to add a key to kafka-reassign-partitions.sh command to
> automatically create json config.
> Example of usage
> {code}
> kafka-reassign-partitions.sh --zookeeper zk --replicas new-replication-factor
> --topics-to-move-json-file topics-file --broker-list 1,2,3,4 --generate >
> output
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1543) Changing replication factor
[
https://issues.apache.org/jira/browse/KAFKA-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728340#comment-14728340
]
Alexander Pakulov commented on KAFKA-1543:
--
I didn't check for this scenario, I'll keep you posted.
> Changing replication factor
> ---
>
> Key: KAFKA-1543
> URL: https://issues.apache.org/jira/browse/KAFKA-1543
> Project: Kafka
> Issue Type: Improvement
>Reporter: Alexey Ozeritskiy
>Assignee: Alexander Pakulov
> Attachments: can-change-replication.patch
>
>
> It is difficult to change replication factor by manual editing json config.
> I propose to add a key to kafka-reassign-partitions.sh command to
> automatically create json config.
> Example of usage
> {code}
> kafka-reassign-partitions.sh --zookeeper zk --replicas new-replication-factor
> --topics-to-move-json-file topics-file --broker-list 1,2,3,4 --generate >
> output
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1543) Changing replication factor
[
https://issues.apache.org/jira/browse/KAFKA-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728131#comment-14728131
]
Alexander Pakulov commented on KAFKA-1543:
--
Agree, but since I've been working on the previous issue KAFKA-1782 that is
already closed - I've made few minor changes here.
> Changing replication factor
> ---
>
> Key: KAFKA-1543
> URL: https://issues.apache.org/jira/browse/KAFKA-1543
> Project: Kafka
> Issue Type: Improvement
>Reporter: Alexey Ozeritskiy
>Assignee: Alexander Pakulov
> Attachments: can-change-replication.patch
>
>
> It is difficult to change replication factor by manual editing json config.
> I propose to add a key to kafka-reassign-partitions.sh command to
> automatically create json config.
> Example of usage
> {code}
> kafka-reassign-partitions.sh --zookeeper zk --replicas new-replication-factor
> --topics-to-move-json-file topics-file --broker-list 1,2,3,4 --generate >
> output
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1543) Changing replication factor
[
https://issues.apache.org/jira/browse/KAFKA-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708037#comment-14708037
]
Alexey Ozeritskiy commented on KAFKA-1543:
--
I think refactoring should be a separate patch and may be a separate jira-issue.
Changing replication factor
---
Key: KAFKA-1543
URL: https://issues.apache.org/jira/browse/KAFKA-1543
Project: Kafka
Issue Type: Improvement
Reporter: Alexey Ozeritskiy
Assignee: Alexander Pakulov
Attachments: can-change-replication.patch
It is difficult to change replication factor by manual editing json config.
I propose to add a key to kafka-reassign-partitions.sh command to
automatically create json config.
Example of usage
{code}
kafka-reassign-partitions.sh --zookeeper zk --replicas new-replication-factor
--topics-to-move-json-file topics-file --broker-list 1,2,3,4 --generate
output
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1543) Changing replication factor
[
https://issues.apache.org/jira/browse/KAFKA-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708039#comment-14708039
]
Alexey Ozeritskiy commented on KAFKA-1543:
--
A you sure that your aproach will work w/o cluster restart?
AddPartitionsListener only handles new partitions but not new replicas.
Changing replication factor
---
Key: KAFKA-1543
URL: https://issues.apache.org/jira/browse/KAFKA-1543
Project: Kafka
Issue Type: Improvement
Reporter: Alexey Ozeritskiy
Assignee: Alexander Pakulov
Attachments: can-change-replication.patch
It is difficult to change replication factor by manual editing json config.
I propose to add a key to kafka-reassign-partitions.sh command to
automatically create json config.
Example of usage
{code}
kafka-reassign-partitions.sh --zookeeper zk --replicas new-replication-factor
--topics-to-move-json-file topics-file --broker-list 1,2,3,4 --generate
output
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1543) Changing replication factor
[
https://issues.apache.org/jira/browse/KAFKA-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14707713#comment-14707713
]
ASF GitHub Bot commented on KAFKA-1543:
---
GitHub user apakulov opened a pull request:
https://github.com/apache/kafka/pull/161
KAFKA-1543; Changing replication factor
Adding support to change replication-factor via kafka-topics to avoid
additional hassle of defining replicas explicilty. This change will allow to
make this change with one line:
```
kafka-topics.sh --zookeeper host:port --alter --topic name
--replication-factor 3
```
Also, made a small cleanup by replacing old junit.framework.Assert with
org.junit.Assert
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apakulov/kafka KAFKA-1543
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/161.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #161
commit ed276ffdac107afe26e82d051fbeb8fa4f67416f
Author: Alexander Pakulov a.paku...@gmail.com
Date: 2015-08-22T00:46:21Z
KAFKA-1543; Changing replication factor
Changing replication factor
---
Key: KAFKA-1543
URL: https://issues.apache.org/jira/browse/KAFKA-1543
Project: Kafka
Issue Type: Improvement
Reporter: Alexey Ozeritskiy
Assignee: Alexander Pakulov
Attachments: can-change-replication.patch
It is difficult to change replication factor by manual editing json config.
I propose to add a key to kafka-reassign-partitions.sh command to
automatically create json config.
Example of usage
{code}
kafka-reassign-partitions.sh --zookeeper zk --replicas new-replication-factor
--topics-to-move-json-file topics-file --broker-list 1,2,3,4 --generate
output
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1543) Changing replication factor
[
https://issues.apache.org/jira/browse/KAFKA-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065616#comment-14065616
]
Jay Kreps commented on KAFKA-1543:
--
I wonder if it would make more sense to have the alter topic command do this.
Something like:
{code}
bin/kafka-topics.sh --zookeeper host:port --alter --topic name
--replication-factor 3
{code}
Changing replication factor
---
Key: KAFKA-1543
URL: https://issues.apache.org/jira/browse/KAFKA-1543
Project: Kafka
Issue Type: Improvement
Reporter: Alexey Ozeritskiy
Attachments: can-change-replication.patch
It is difficult to change replication factor by manual editing json config.
I propose to add a key to kafka-reassign-partitions.sh command to
automatically create json config.
Example of usage
{code}
kafka-reassign-partitions.sh --zookeeper zk --replicas new-replication-factor
--topics-to-move-json-file topics-file --broker-list 1,2,3,4 --generate
output
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
