[jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14325187#comment-14325187 ] Guozhang Wang commented on KAFKA-1805: -- Thanks for the patch, committed to trunk. Kafka ProducerRecord should implement equals Key: KAFKA-1805 URL: https://issues.apache.org/jira/browse/KAFKA-1805 Project: Kafka Issue Type: Improvement Components: producer Affects Versions: 0.8.2.0 Reporter: Thomas Omans Assignee: Parth Brahmbhatt Priority: Minor Attachments: KAFKA-1805.patch, KAFKA-1805_2014-12-29_16:37:11.patch, KAFKA-1805_2015-02-11_14:30:14.patch, KAFKA-1805_2015-02-11_14:34:28.patch, KAFKA-1805_2015-02-11_14:37:09.patch, KAFKA-1805_2015-02-11_14:37:41.patch, KAFKA-1805_2015-02-11_14:49:10.patch I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality. This makes tests integrating kafka particularly awkward. https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java I can whip up a patch since this is essentially just a value object. Thanks, Thomas Omans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317118#comment-14317118 ] Parth Brahmbhatt commented on KAFKA-1805: - Updated reviewboard https://reviews.apache.org/r/29468/diff/ against branch origin/trunk Kafka ProducerRecord should implement equals Key: KAFKA-1805 URL: https://issues.apache.org/jira/browse/KAFKA-1805 Project: Kafka Issue Type: Improvement Components: producer Affects Versions: 0.8.2.0 Reporter: Thomas Omans Assignee: Thomas Omans Priority: Minor Attachments: KAFKA-1805.patch, KAFKA-1805_2014-12-29_16:37:11.patch, KAFKA-1805_2015-02-11_14:30:14.patch, KAFKA-1805_2015-02-11_14:34:28.patch I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality. This makes tests integrating kafka particularly awkward. https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java I can whip up a patch since this is essentially just a value object. Thanks, Thomas Omans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317108#comment-14317108 ] Parth Brahmbhatt commented on KAFKA-1805: - Updated reviewboard https://reviews.apache.org/r/29468/diff/ against branch origin/trunk Kafka ProducerRecord should implement equals Key: KAFKA-1805 URL: https://issues.apache.org/jira/browse/KAFKA-1805 Project: Kafka Issue Type: Improvement Components: producer Affects Versions: 0.8.2.0 Reporter: Thomas Omans Assignee: Thomas Omans Priority: Minor Attachments: KAFKA-1805.patch, KAFKA-1805_2014-12-29_16:37:11.patch, KAFKA-1805_2015-02-11_14:30:14.patch I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality. This makes tests integrating kafka particularly awkward. https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java I can whip up a patch since this is essentially just a value object. Thanks, Thomas Omans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317124#comment-14317124 ] Parth Brahmbhatt commented on KAFKA-1805: - Updated reviewboard https://reviews.apache.org/r/29468/diff/ against branch origin/trunk Kafka ProducerRecord should implement equals Key: KAFKA-1805 URL: https://issues.apache.org/jira/browse/KAFKA-1805 Project: Kafka Issue Type: Improvement Components: producer Affects Versions: 0.8.2.0 Reporter: Thomas Omans Assignee: Thomas Omans Priority: Minor Attachments: KAFKA-1805.patch, KAFKA-1805_2014-12-29_16:37:11.patch, KAFKA-1805_2015-02-11_14:30:14.patch, KAFKA-1805_2015-02-11_14:34:28.patch, KAFKA-1805_2015-02-11_14:37:09.patch, KAFKA-1805_2015-02-11_14:37:41.patch I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality. This makes tests integrating kafka particularly awkward. https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java I can whip up a patch since this is essentially just a value object. Thanks, Thomas Omans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317123#comment-14317123 ] Parth Brahmbhatt commented on KAFKA-1805: - Updated reviewboard https://reviews.apache.org/r/29468/diff/ against branch origin/trunk Kafka ProducerRecord should implement equals Key: KAFKA-1805 URL: https://issues.apache.org/jira/browse/KAFKA-1805 Project: Kafka Issue Type: Improvement Components: producer Affects Versions: 0.8.2.0 Reporter: Thomas Omans Assignee: Thomas Omans Priority: Minor Attachments: KAFKA-1805.patch, KAFKA-1805_2014-12-29_16:37:11.patch, KAFKA-1805_2015-02-11_14:30:14.patch, KAFKA-1805_2015-02-11_14:34:28.patch, KAFKA-1805_2015-02-11_14:37:09.patch, KAFKA-1805_2015-02-11_14:37:41.patch I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality. This makes tests integrating kafka particularly awkward. https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java I can whip up a patch since this is essentially just a value object. Thanks, Thomas Omans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317145#comment-14317145 ] Parth Brahmbhatt commented on KAFKA-1805: - Updated reviewboard https://reviews.apache.org/r/29468/diff/ against branch origin/trunk Kafka ProducerRecord should implement equals Key: KAFKA-1805 URL: https://issues.apache.org/jira/browse/KAFKA-1805 Project: Kafka Issue Type: Improvement Components: producer Affects Versions: 0.8.2.0 Reporter: Thomas Omans Assignee: Thomas Omans Priority: Minor Attachments: KAFKA-1805.patch, KAFKA-1805_2014-12-29_16:37:11.patch, KAFKA-1805_2015-02-11_14:30:14.patch, KAFKA-1805_2015-02-11_14:34:28.patch, KAFKA-1805_2015-02-11_14:37:09.patch, KAFKA-1805_2015-02-11_14:37:41.patch, KAFKA-1805_2015-02-11_14:49:10.patch I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality. This makes tests integrating kafka particularly awkward. https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java I can whip up a patch since this is essentially just a value object. Thanks, Thomas Omans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311136#comment-14311136 ] Guozhang Wang commented on KAFKA-1805: -- Thanks for the patch [~parth.brahmbhatt], some comments added by Ewen and myself in the RB. Kafka ProducerRecord should implement equals Key: KAFKA-1805 URL: https://issues.apache.org/jira/browse/KAFKA-1805 Project: Kafka Issue Type: Improvement Components: producer Affects Versions: 0.8.2 Reporter: Thomas Omans Assignee: Thomas Omans Priority: Minor Attachments: KAFKA-1805.patch, KAFKA-1805_2014-12-29_16:37:11.patch I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality. This makes tests integrating kafka particularly awkward. https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java I can whip up a patch since this is essentially just a value object. Thanks, Thomas Omans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260520#comment-14260520 ] Parth Brahmbhatt commented on KAFKA-1805: - Created reviewboard https://reviews.apache.org/r/29468/diff/ against branch trunk Kafka ProducerRecord should implement equals Key: KAFKA-1805 URL: https://issues.apache.org/jira/browse/KAFKA-1805 Project: Kafka Issue Type: Improvement Components: producer Affects Versions: 0.8.2 Reporter: Thomas Omans Assignee: Thomas Omans Priority: Minor Attachments: KAFKA-1805.patch I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality. This makes tests integrating kafka particularly awkward. https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java I can whip up a patch since this is essentially just a value object. Thanks, Thomas Omans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14260597#comment-14260597 ] Parth Brahmbhatt commented on KAFKA-1805: - Updated reviewboard https://reviews.apache.org/r/29468/diff/ against branch origin/trunk Kafka ProducerRecord should implement equals Key: KAFKA-1805 URL: https://issues.apache.org/jira/browse/KAFKA-1805 Project: Kafka Issue Type: Improvement Components: producer Affects Versions: 0.8.2 Reporter: Thomas Omans Assignee: Thomas Omans Priority: Minor Attachments: KAFKA-1805.patch, KAFKA-1805_2014-12-29_16:37:11.patch I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality. This makes tests integrating kafka particularly awkward. https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java I can whip up a patch since this is essentially just a value object. Thanks, Thomas Omans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1805) Kafka ProducerRecord should implement equals
[ https://issues.apache.org/jira/browse/KAFKA-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14233450#comment-14233450 ] Guozhang Wang commented on KAFKA-1805: -- Thanks Thomas for pointing this out, looking forward for your patch. Kafka ProducerRecord should implement equals Key: KAFKA-1805 URL: https://issues.apache.org/jira/browse/KAFKA-1805 Project: Kafka Issue Type: Improvement Components: producer Affects Versions: 0.8.2 Reporter: Thomas Omans Assignee: Jun Rao Priority: Minor I was writing some tests to verify that I am calculating my partitions, topics, keys, and values properly in my producer code and discovered that ProducerRecord does not implement equality. This makes tests integrating kafka particularly awkward. https://github.com/apache/kafka/blob/0.8.2-beta/clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java I can whip up a patch since this is essentially just a value object. Thanks, Thomas Omans -- This message was sent by Atlassian JIRA (v6.3.4#6332)
