[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts
[
https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350715#comment-15350715
]
Carlo Alberto Ferraris commented on KAFKA-1889:
---
An additional note about {{-loggc}}: GC logs generated by the JVM
(server-jre-8u60-linux-x64) can not be logrotated (see e.g.
stackoverflow.com/questions/8353401/garbage-collector-log-loggc-file-rotation-with-logrotate-does-not-work-properl)
> Refactor shell wrapper scripts
> --
>
> Key: KAFKA-1889
> URL: https://issues.apache.org/jira/browse/KAFKA-1889
> Project: Kafka
> Issue Type: Improvement
> Components: packaging
>Reporter: Francois Saint-Jacques
>Assignee: Francois Saint-Jacques
>Priority: Minor
> Attachments: refactor-scripts-v1.patch, refactor-scripts-v2.patch
>
>
> Shell scripts in bin/ need love.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts
[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14291967#comment-14291967 ] Francois Saint-Jacques commented on KAFKA-1889: --- Do you think it could make it to 0.8.2? Refactor shell wrapper scripts -- Key: KAFKA-1889 URL: https://issues.apache.org/jira/browse/KAFKA-1889 Project: Kafka Issue Type: Improvement Components: packaging Reporter: Francois Saint-Jacques Assignee: Francois Saint-Jacques Priority: Minor Attachments: refactor-scripts-v1.patch, refactor-scripts-v2.patch Shell scripts in bin/ need love. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts
[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288120#comment-14288120 ] Francois Saint-Jacques commented on KAFKA-1889: --- My goal is to fix the kafka startup script to make it friendlier to package as rpm or deb. I believe it is a disjoint concern than the issue you mentioned. Refactor shell wrapper scripts -- Key: KAFKA-1889 URL: https://issues.apache.org/jira/browse/KAFKA-1889 Project: Kafka Issue Type: Improvement Components: packaging Reporter: Francois Saint-Jacques Assignee: Francois Saint-Jacques Priority: Minor Attachments: refactor-scripts-v1.patch, refactor-scripts-v2.patch Shell scripts in bin/ need love. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts
[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288061#comment-14288061 ] Joe Stein commented on KAFKA-1889: -- Thanks for the patch [~fsaintjacques]. What is the motivation for this? Have you seen the work on the new CLI https://issues.apache.org/jira/browse/KAFKA-1694 and thought how that might be used moving forward? Refactor shell wrapper scripts -- Key: KAFKA-1889 URL: https://issues.apache.org/jira/browse/KAFKA-1889 Project: Kafka Issue Type: Improvement Components: packaging Reporter: Francois Saint-Jacques Assignee: Francois Saint-Jacques Priority: Minor Attachments: refactor-scripts-v1.patch, refactor-scripts-v2.patch Shell scripts in bin/ need love. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts
[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288193#comment-14288193 ] Francois Saint-Jacques commented on KAFKA-1889: --- It's not about working well with rpm and debian, it's about having sane default and behaviour so that packagers won't have to diff/patch said scripts. My patch is not final at all, I just wanted to start the discussion on cleaning the scripts. Refactor shell wrapper scripts -- Key: KAFKA-1889 URL: https://issues.apache.org/jira/browse/KAFKA-1889 Project: Kafka Issue Type: Improvement Components: packaging Reporter: Francois Saint-Jacques Assignee: Francois Saint-Jacques Priority: Minor Attachments: refactor-scripts-v1.patch, refactor-scripts-v2.patch Shell scripts in bin/ need love. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts
[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288152#comment-14288152 ] Joe Stein commented on KAFKA-1889: -- Makes sense. How do we know this works well for rpm and deb? What about having rpm and deb script for folks to make packages that wrap what you did? If we introduce something that doesn't do that we will just generate more questions and issues and have to support that. It would be great to best minimize those things with the changes. Refactor shell wrapper scripts -- Key: KAFKA-1889 URL: https://issues.apache.org/jira/browse/KAFKA-1889 Project: Kafka Issue Type: Improvement Components: packaging Reporter: Francois Saint-Jacques Assignee: Francois Saint-Jacques Priority: Minor Attachments: refactor-scripts-v1.patch, refactor-scripts-v2.patch Shell scripts in bin/ need love. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts
[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14288205#comment-14288205 ] Francois Saint-Jacques commented on KAFKA-1889: --- Also note that this patch keeps the existing behaviour (to some epsilon: var rename + default jmx port which will break multiple process). It is mostly a cleanup of kafka-run-class.sh that acquired technical debts over time. Refactor shell wrapper scripts -- Key: KAFKA-1889 URL: https://issues.apache.org/jira/browse/KAFKA-1889 Project: Kafka Issue Type: Improvement Components: packaging Reporter: Francois Saint-Jacques Assignee: Francois Saint-Jacques Priority: Minor Attachments: refactor-scripts-v1.patch, refactor-scripts-v2.patch Shell scripts in bin/ need love. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts
[
https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286006#comment-14286006
]
Francois Saint-Jacques commented on KAFKA-1889:
---
I have multiple other comments on the scripts that I didn't address and might
be worth talking.
1. There seems to be many way to pass option to kafka-run-class.sh, either by
arguments (-daemon|-loggc|...) or by environment variables
(KAFKA_JMX_OPTS|KAFKA_OPTS|KAFKA_HEAP_OPTS|...). This is inconsistent and needs
to be addressed.
2. Scripts shouldn't bother daemonizing, leave this to packagers, just make
sure you exec correctly.
3. The defaults are not production ready for servers:
-gc log shouldn't be enabled by default
-kafka-request.log to TRACE, this is a silent disk killer on busy cluster
- never do this in non-init script, should be left to packagers: if [ ! -d
${LOG_DIR} ]; then mkdir -p ${LOG_DIR}; fi
Refactor shell wrapper scripts
--
Key: KAFKA-1889
URL: https://issues.apache.org/jira/browse/KAFKA-1889
Project: Kafka
Issue Type: Improvement
Components: packaging
Reporter: Francois Saint-Jacques
Assignee: Francois Saint-Jacques
Priority: Minor
Attachments: refactor-scripts-v1.patch
Shell scripts in bin/ need love.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-1889) Refactor shell wrapper scripts
[ https://issues.apache.org/jira/browse/KAFKA-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14286097#comment-14286097 ] Francois Saint-Jacques commented on KAFKA-1889: --- The second patch should give an overview of what a 'clean' kafka-run-class.sh should look like. Refactor shell wrapper scripts -- Key: KAFKA-1889 URL: https://issues.apache.org/jira/browse/KAFKA-1889 Project: Kafka Issue Type: Improvement Components: packaging Reporter: Francois Saint-Jacques Assignee: Francois Saint-Jacques Priority: Minor Attachments: refactor-scripts-v1.patch, refactor-scripts-v2.patch Shell scripts in bin/ need love. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
