[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317808#comment-14317808 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trunk can't explicitly set replica-assignment when add partitions --- Key: KAFKA-1947 URL: https://issues.apache.org/jira/browse/KAFKA-1947 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.1.1 Environment: Windows Reporter: Honghai Chen Attachments: KAFKA-1947.patch, KAFKA-1947.patch, KAFKA-1947.patch When create topic, the replicaAssignmentOpt should not appear with partitions. But when add partitions, they should can appear together, from the code below, you can see when alter topic, and has partitions in arguments, it try get replica-assignment https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 The root cause is below code: CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt, 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt) https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304 Related: https://issues.apache.org/jira/browse/KAFKA-1052 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317803#comment-14317803 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trunk can't explicitly set replica-assignment when add partitions --- Key: KAFKA-1947 URL: https://issues.apache.org/jira/browse/KAFKA-1947 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.1.1 Environment: Windows Reporter: Honghai Chen Attachments: KAFKA-1947.patch, KAFKA-1947.patch, KAFKA-1947.patch When create topic, the replicaAssignmentOpt should not appear with partitions. But when add partitions, they should can appear together, from the code below, you can see when alter topic, and has partitions in arguments, it try get replica-assignment https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 The root cause is below code: CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt, 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt) https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304 Related: https://issues.apache.org/jira/browse/KAFKA-1052 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317781#comment-14317781 ] Honghai Chen commented on KAFKA-1947: - The fix is quite directly: When has replicaAssignment, the command should only be createTopic or alterTopic When the command is create topic, and replicaAssignment appear, there should no partitions and replica number. The command told me board is ok, but actually no. But patch uploaded. D:\C\Kafka_Updatekafka-patch-review_.py -b origin/trunk -j KAFKA-1947 Configuring reviewboard url to https://reviews.apache.org Updating your remote branches to pull the latest changes Creating diff against origin/trunk and uploading patch to JIRA KAFKA-1947 Created a new reviewboard D:\C\Kafka_Update can't explicitly set replica-assignment when add partitions --- Key: KAFKA-1947 URL: https://issues.apache.org/jira/browse/KAFKA-1947 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.1.1 Environment: Windows Reporter: Honghai Chen Attachments: KAFKA-1947.patch When create topic, the replicaAssignmentOpt should not appear with partitions. But when add partitions, they should can appear together, from the code below, you can see when alter topic, and has partitions in arguments, it try get replica-assignment https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 The root cause is below code: CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt, 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt) https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304 Related: https://issues.apache.org/jira/browse/KAFKA-1052 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317802#comment-14317802 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trunk can't explicitly set replica-assignment when add partitions --- Key: KAFKA-1947 URL: https://issues.apache.org/jira/browse/KAFKA-1947 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.1.1 Environment: Windows Reporter: Honghai Chen Attachments: KAFKA-1947.patch, KAFKA-1947.patch When create topic, the replicaAssignmentOpt should not appear with partitions. But when add partitions, they should can appear together, from the code below, you can see when alter topic, and has partitions in arguments, it try get replica-assignment https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 The root cause is below code: CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt, 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt) https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304 Related: https://issues.apache.org/jira/browse/KAFKA-1052 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317832#comment-14317832 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trunk can't explicitly set replica-assignment when add partitions --- Key: KAFKA-1947 URL: https://issues.apache.org/jira/browse/KAFKA-1947 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.1.1 Environment: Windows Reporter: Honghai Chen Attachments: KAFKA-1947.patch, KAFKA-1947.patch, KAFKA-1947.patch, KAFKA-1947.patch, KAFKA-1947.patch When create topic, the replicaAssignmentOpt should not appear with partitions. But when add partitions, they should can appear together, from the code below, you can see when alter topic, and has partitions in arguments, it try get replica-assignment https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 The root cause is below code: CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt, 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt) https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304 Related: https://issues.apache.org/jira/browse/KAFKA-1052 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317775#comment-14317775 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trunk can't explicitly set replica-assignment when add partitions --- Key: KAFKA-1947 URL: https://issues.apache.org/jira/browse/KAFKA-1947 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.1.1 Environment: Windows Reporter: Honghai Chen Attachments: KAFKA-1947.patch When create topic, the replicaAssignmentOpt should not appear with partitions. But when add partitions, they should can appear together, from the code below, you can see when alter topic, and has partitions in arguments, it try get replica-assignment https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 The root cause is below code: CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt, 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt) https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304 Related: https://issues.apache.org/jira/browse/KAFKA-1052 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317822#comment-14317822 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trunk can't explicitly set replica-assignment when add partitions --- Key: KAFKA-1947 URL: https://issues.apache.org/jira/browse/KAFKA-1947 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.1.1 Environment: Windows Reporter: Honghai Chen Attachments: KAFKA-1947.patch, KAFKA-1947.patch, KAFKA-1947.patch, KAFKA-1947.patch When create topic, the replicaAssignmentOpt should not appear with partitions. But when add partitions, they should can appear together, from the code below, you can see when alter topic, and has partitions in arguments, it try get replica-assignment https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 The root cause is below code: CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt, 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt) https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304 Related: https://issues.apache.org/jira/browse/KAFKA-1052 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317821#comment-14317821 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trunk can't explicitly set replica-assignment when add partitions --- Key: KAFKA-1947 URL: https://issues.apache.org/jira/browse/KAFKA-1947 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.1.1 Environment: Windows Reporter: Honghai Chen Attachments: KAFKA-1947.patch, KAFKA-1947.patch, KAFKA-1947.patch When create topic, the replicaAssignmentOpt should not appear with partitions. But when add partitions, they should can appear together, from the code below, you can see when alter topic, and has partitions in arguments, it try get replica-assignment https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 The root cause is below code: CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt, 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt) https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304 Related: https://issues.apache.org/jira/browse/KAFKA-1052 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317835#comment-14317835 ] Honghai Chen commented on KAFKA-1947: - Submit review ... https://reviews.apache.org/r/30919/ https://reviews.apache.org/r/30919/diff/ can't explicitly set replica-assignment when add partitions --- Key: KAFKA-1947 URL: https://issues.apache.org/jira/browse/KAFKA-1947 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.1.1 Environment: Windows Reporter: Honghai Chen Attachments: KAFKA-1947.patch When create topic, the replicaAssignmentOpt should not appear with partitions. But when add partitions, they should can appear together, from the code below, you can see when alter topic, and has partitions in arguments, it try get replica-assignment https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 The root cause is below code: CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt, 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt) https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304 Related: https://issues.apache.org/jira/browse/KAFKA-1052 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317824#comment-14317824 ] Honghai Chen commented on KAFKA-1947: - Created reviewboard against branch origin/trunk can't explicitly set replica-assignment when add partitions --- Key: KAFKA-1947 URL: https://issues.apache.org/jira/browse/KAFKA-1947 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.1.1 Environment: Windows Reporter: Honghai Chen Attachments: KAFKA-1947.patch, KAFKA-1947.patch, KAFKA-1947.patch, KAFKA-1947.patch, KAFKA-1947.patch When create topic, the replicaAssignmentOpt should not appear with partitions. But when add partitions, they should can appear together, from the code below, you can see when alter topic, and has partitions in arguments, it try get replica-assignment https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 The root cause is below code: CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt, 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt) https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304 Related: https://issues.apache.org/jira/browse/KAFKA-1052 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1947) can't explicitly set replica-assignment when add partitions
[ https://issues.apache.org/jira/browse/KAFKA-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14317513#comment-14317513 ] Honghai Chen commented on KAFKA-1947: - After fix the command line, the command still not work, seemly more bugs in it. Try below command bin\kafka.cmd topiccmd --create --topic mvlogs --partition 1 --replication-factor 2 --zookeeper localhost bin\kafka.cmd topiccmd --alter --topic mvlogs --partitions 2 --replica-assignment 2:3 --zookeeper localhost The log say: [2015-02-11 19:18:30,791] INFO zookeeper state changed (SyncConnected) (org.I0It ec.zkclient.ZkClient) WARNING: If partitions are increased for a topic that has a key, the partition l ogic or ordering of the messages will be affected [2015-02-11 19:18:31,427] INFO Add partition list for mvlogs is Map() (kafka.adm in.AdminUtils$) [2015-02-11 19:18:31,470] INFO Topic update {version:1,partitions:{0:[3,1]}} (kafka.admin.AdminUtils$) Adding partitions succeeded! [2015-02-11 19:18:31,479] INFO Terminate ZkClient event thread. (org.I0Itec.zkcl ient.ZkEventThread) Seemly the JSON string is wrong! Will continue check it. can't explicitly set replica-assignment when add partitions --- Key: KAFKA-1947 URL: https://issues.apache.org/jira/browse/KAFKA-1947 Project: Kafka Issue Type: Bug Components: core Affects Versions: 0.8.1.1 Environment: Windows Reporter: Honghai Chen When create topic, the replicaAssignmentOpt should not appear with partitions. But when add partitions, they should can appear together, from the code below, you can see when alter topic, and has partitions in arguments, it try get replica-assignment https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l114 The root cause is below code: CommandLineUtils.checkInvalidArgs(parser, options, replicaAssignmentOpt, 305 allTopicLevelOpts -- Set(alterOpt, createOpt) + partitionsOpt + replicationFactorOpt) https://git1-us-west.apache.org/repos/asf?p=kafka.git;a=blob;f=core/src/main/scala/kafka/admin/TopicCommand.scala;h=285c0333ff43543d3e46444c1cd9374bb883bb59;hb=HEAD#l304 Related: https://issues.apache.org/jira/browse/KAFKA-1052 -- This message was sent by Atlassian JIRA (v6.3.4#6332)