[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2017-02-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856324#comment-15856324
 ] 

ASF GitHub Bot commented on KAFKA-2122:
---

Github user soenkeliebau closed the pull request at:

https://github.com/apache/kafka/pull/2512


> Remove controller.message.queue.size Config
> ---
>
> Key: KAFKA-2122
> URL: https://issues.apache.org/jira/browse/KAFKA-2122
> Project: Kafka
>  Issue Type: Bug
>Reporter: Onur Karaman
>Assignee: Sriharsha Chintalapani
> Fix For: 0.9.0.0
>
> Attachments: KAFKA-2122_2015-04-19_12:44:41.patch, KAFKA-2122.patch
>
>
> A deadlock can happen during a delete topic if controller.message.queue.size 
> is overridden to a custom value. Details are here: 
> https://issues.apache.org/jira/browse/KAFKA-2046?focusedCommentId=14380776=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380776
> Given that KAFKA-1993 is enabling delete topic by default, it would be unsafe 
> to simultaneously allow a configurable controller.message.queue.size



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2017-02-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856134#comment-15856134
 ] 

ASF GitHub Bot commented on KAFKA-2122:
---

GitHub user soenkeliebau opened a pull request:

https://github.com/apache/kafka/pull/2512

Removed obsolete parameter form example config in docs.

Parameter controller.message.queue.size was removed in 0.9 (KAFKA-2122) but 
is still listed in an example broker configuration in the documentation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/soenkeliebau/kafka 
remove-controller.message.queue.size

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2512.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2512






> Remove controller.message.queue.size Config
> ---
>
> Key: KAFKA-2122
> URL: https://issues.apache.org/jira/browse/KAFKA-2122
> Project: Kafka
>  Issue Type: Bug
>Reporter: Onur Karaman
>Assignee: Sriharsha Chintalapani
> Fix For: 0.9.0.0
>
> Attachments: KAFKA-2122_2015-04-19_12:44:41.patch, KAFKA-2122.patch
>
>
> A deadlock can happen during a delete topic if controller.message.queue.size 
> is overridden to a custom value. Details are here: 
> https://issues.apache.org/jira/browse/KAFKA-2046?focusedCommentId=14380776=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380776
> Given that KAFKA-1993 is enabling delete topic by default, it would be unsafe 
> to simultaneously allow a configurable controller.message.queue.size



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2017-02-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856115#comment-15856115
 ] 

ASF GitHub Bot commented on KAFKA-2122:
---

Github user soenkeliebau closed the pull request at:

https://github.com/apache/kafka/pull/2183


> Remove controller.message.queue.size Config
> ---
>
> Key: KAFKA-2122
> URL: https://issues.apache.org/jira/browse/KAFKA-2122
> Project: Kafka
>  Issue Type: Bug
>Reporter: Onur Karaman
>Assignee: Sriharsha Chintalapani
> Fix For: 0.9.0.0
>
> Attachments: KAFKA-2122_2015-04-19_12:44:41.patch, KAFKA-2122.patch
>
>
> A deadlock can happen during a delete topic if controller.message.queue.size 
> is overridden to a custom value. Details are here: 
> https://issues.apache.org/jira/browse/KAFKA-2046?focusedCommentId=14380776=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380776
> Given that KAFKA-1993 is enabling delete topic by default, it would be unsafe 
> to simultaneously allow a configurable controller.message.queue.size



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2016-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703408#comment-15703408
 ] 

ASF GitHub Bot commented on KAFKA-2122:
---

GitHub user soenkeliebau opened a pull request:

https://github.com/apache/kafka/pull/2183

Removed obsolete parameter form example config in docs. 

Parameter controller.message.queue.size was removed in 0.9 (KAFKA-2122) but 
is still listed in an example broker configuration in the documentation.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/soenkeliebau/kafka 
controller.message.queue.size

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2183


commit 72b066d7b24413b8617378edae16faa98907c06d
Author: Sönke Liebau 
Date:   2016-11-28T22:52:47Z

Removed obsolete parameter form example config in docs. Parameter 
controller.message.queue.size was removed in 0.9 (KAFKA-2122)




> Remove controller.message.queue.size Config
> ---
>
> Key: KAFKA-2122
> URL: https://issues.apache.org/jira/browse/KAFKA-2122
> Project: Kafka
>  Issue Type: Bug
>Reporter: Onur Karaman
>Assignee: Sriharsha Chintalapani
> Fix For: 0.9.0.0
>
> Attachments: KAFKA-2122.patch, KAFKA-2122_2015-04-19_12:44:41.patch
>
>
> A deadlock can happen during a delete topic if controller.message.queue.size 
> is overridden to a custom value. Details are here: 
> https://issues.apache.org/jira/browse/KAFKA-2046?focusedCommentId=14380776=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380776
> Given that KAFKA-1993 is enabling delete topic by default, it would be unsafe 
> to simultaneously allow a configurable controller.message.queue.size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2015-04-20 Thread Colin Clark 
unsubscribe
 On Apr 20, 2015, at 8:09 AM, Sriharsha Chintalapani (JIRA) j...@apache.org 
 wrote:
 
 
[ 
 https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502761#comment-14502761
  ] 
 
 Sriharsha Chintalapani commented on KAFKA-2122:
 ---
 
 [~wangbo23] This is for trunk. But this patch just removes the config if you 
 want similar behavior from 0.8.2.1 just remove the config from 
 server.properties.
 
 Remove controller.message.queue.size Config
 ---
 
Key: KAFKA-2122
URL: https://issues.apache.org/jira/browse/KAFKA-2122
Project: Kafka
 Issue Type: Bug
   Reporter: Onur Karaman
   Assignee: Sriharsha Chintalapani
Attachments: KAFKA-2122.patch, KAFKA-2122_2015-04-19_12:44:41.patch
 
 
 A deadlock can happen during a delete topic if controller.message.queue.size 
 is overridden to a custom value. Details are here: 
 https://issues.apache.org/jira/browse/KAFKA-2046?focusedCommentId=14380776page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380776
 Given that KAFKA-1993 is enabling delete topic by default, it would be 
 unsafe to simultaneously allow a configurable controller.message.queue.size
 
 
 
 --
 This message was sent by Atlassian JIRA
 (v6.3.4#6332)



smime.p7s
Description: S/MIME cryptographic signature

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2015-04-20 Thread Sriharsha Chintalapani (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502761#comment-14502761
 ] 

Sriharsha Chintalapani commented on KAFKA-2122:
---

[~wangbo23] This is for trunk. But this patch just removes the config if you 
want similar behavior from 0.8.2.1 just remove the config from 
server.properties.

 Remove controller.message.queue.size Config
 ---

 Key: KAFKA-2122
 URL: https://issues.apache.org/jira/browse/KAFKA-2122
 Project: Kafka
  Issue Type: Bug
Reporter: Onur Karaman
Assignee: Sriharsha Chintalapani
 Attachments: KAFKA-2122.patch, KAFKA-2122_2015-04-19_12:44:41.patch


 A deadlock can happen during a delete topic if controller.message.queue.size 
 is overridden to a custom value. Details are here: 
 https://issues.apache.org/jira/browse/KAFKA-2046?focusedCommentId=14380776page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380776
 Given that KAFKA-1993 is enabling delete topic by default, it would be unsafe 
 to simultaneously allow a configurable controller.message.queue.size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2015-04-20 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502583#comment-14502583
 ] 

王博 commented on KAFKA-2122:
---

 Which version this patch is based on? I found KAFKA-2122_2015-04-19_12: 44: 
41.patch is not based on 0.8.2.1?

 Remove controller.message.queue.size Config
 ---

 Key: KAFKA-2122
 URL: https://issues.apache.org/jira/browse/KAFKA-2122
 Project: Kafka
  Issue Type: Bug
Reporter: Onur Karaman
Assignee: Sriharsha Chintalapani
 Attachments: KAFKA-2122.patch, KAFKA-2122_2015-04-19_12:44:41.patch


 A deadlock can happen during a delete topic if controller.message.queue.size 
 is overridden to a custom value. Details are here: 
 https://issues.apache.org/jira/browse/KAFKA-2046?focusedCommentId=14380776page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380776
 Given that KAFKA-1993 is enabling delete topic by default, it would be unsafe 
 to simultaneously allow a configurable controller.message.queue.size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2015-04-19 Thread Sriharsha Chintalapani (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502082#comment-14502082
 ] 

Sriharsha Chintalapani commented on KAFKA-2122:
---

Updated reviewboard https://reviews.apache.org/r/33342/diff/
 against branch origin/trunk

 Remove controller.message.queue.size Config
 ---

 Key: KAFKA-2122
 URL: https://issues.apache.org/jira/browse/KAFKA-2122
 Project: Kafka
  Issue Type: Bug
Reporter: Onur Karaman
Assignee: Sriharsha Chintalapani
 Attachments: KAFKA-2122.patch, KAFKA-2122_2015-04-19_12:44:41.patch


 A deadlock can happen during a delete topic if controller.message.queue.size 
 is overridden to a custom value. Details are here: 
 https://issues.apache.org/jira/browse/KAFKA-2046?focusedCommentId=14380776page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380776
 Given that KAFKA-1993 is enabling delete topic by default, it would be unsafe 
 to simultaneously allow a configurable controller.message.queue.size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2015-04-19 Thread Sriharsha Chintalapani (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502083#comment-14502083
 ] 

Sriharsha Chintalapani commented on KAFKA-2122:
---

Thanks for the quick review [~junrao] [~onurkaraman]

 Remove controller.message.queue.size Config
 ---

 Key: KAFKA-2122
 URL: https://issues.apache.org/jira/browse/KAFKA-2122
 Project: Kafka
  Issue Type: Bug
Reporter: Onur Karaman
Assignee: Sriharsha Chintalapani
 Attachments: KAFKA-2122.patch, KAFKA-2122_2015-04-19_12:44:41.patch


 A deadlock can happen during a delete topic if controller.message.queue.size 
 is overridden to a custom value. Details are here: 
 https://issues.apache.org/jira/browse/KAFKA-2046?focusedCommentId=14380776page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380776
 Given that KAFKA-1993 is enabling delete topic by default, it would be unsafe 
 to simultaneously allow a configurable controller.message.queue.size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-2122) Remove controller.message.queue.size Config

2015-04-19 Thread Sriharsha Chintalapani (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14502039#comment-14502039
 ] 

Sriharsha Chintalapani commented on KAFKA-2122:
---

Created reviewboard https://reviews.apache.org/r/33342/diff/
 against branch origin/trunk

 Remove controller.message.queue.size Config
 ---

 Key: KAFKA-2122
 URL: https://issues.apache.org/jira/browse/KAFKA-2122
 Project: Kafka
  Issue Type: Bug
Reporter: Onur Karaman
Assignee: Sriharsha Chintalapani
 Attachments: KAFKA-2122.patch


 A deadlock can happen during a delete topic if controller.message.queue.size 
 is overridden to a custom value. Details are here: 
 https://issues.apache.org/jira/browse/KAFKA-2046?focusedCommentId=14380776page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14380776
 Given that KAFKA-1993 is enabling delete topic by default, it would be unsafe 
 to simultaneously allow a configurable controller.message.queue.size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)