[jira] [Commented] (KAFKA-2276) Initial patch for KIP-25
[ https://issues.apache.org/jira/browse/KAFKA-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742602#comment-14742602 ] Ewen Cheslack-Postava commented on KAFKA-2276: -- [~jkreps] Take a look at the author of KAFKA-1468, where the code was initially ported into Java for use in ProducerPerformance :) This just refactored it back into a reusable form instead of being embedded directly as duplicate code in ProducerPerformance.java. But agreed, it's be better to get rid of the duplicated code. > Initial patch for KIP-25 > > > Key: KAFKA-2276 > URL: https://issues.apache.org/jira/browse/KAFKA-2276 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Geoff Anderson > Fix For: 0.9.0.0 > > > Submit initial patch for KIP-25 > (https://cwiki.apache.org/confluence/display/KAFKA/KIP-25+-+System+test+improvements) > This patch should contain a few Service classes and a few tests which can > serve as examples -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2276) Initial patch for KIP-25
[ https://issues.apache.org/jira/browse/KAFKA-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742715#comment-14742715 ] Geoff Anderson commented on KAFKA-2276: --- [~jkreps] [~ewencp] Agreed, better to reuse one class, thanks for alerting me to the existence of Throttler.scala. Opened https://issues.apache.org/jira/browse/KAFKA-2542 > Initial patch for KIP-25 > > > Key: KAFKA-2276 > URL: https://issues.apache.org/jira/browse/KAFKA-2276 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Geoff Anderson > Fix For: 0.9.0.0 > > > Submit initial patch for KIP-25 > (https://cwiki.apache.org/confluence/display/KAFKA/KIP-25+-+System+test+improvements) > This patch should contain a few Service classes and a few tests which can > serve as examples -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2276) Initial patch for KIP-25
[ https://issues.apache.org/jira/browse/KAFKA-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741211#comment-14741211 ] Geoff Anderson commented on KAFKA-2276: --- Hey [~jkreps] - if we're ok with adding Kafka core as a dependency of the tools jar, then no we don't need both. I suspect this logic was copy-pasted into clients (to avoid dragging in core dependency there), and then apparently I recreated the original class when I created the tools jar :) > Initial patch for KIP-25 > > > Key: KAFKA-2276 > URL: https://issues.apache.org/jira/browse/KAFKA-2276 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Geoff Anderson > Fix For: 0.8.3 > > > Submit initial patch for KIP-25 > (https://cwiki.apache.org/confluence/display/KAFKA/KIP-25+-+System+test+improvements) > This patch should contain a few Service classes and a few tests which can > serve as examples -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2276) Initial patch for KIP-25
[ https://issues.apache.org/jira/browse/KAFKA-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741225#comment-14741225 ] Jay Kreps commented on KAFKA-2276: -- [~granders] This is common code so it should go under clients/o.a.k.common, I think. That won't change any of the dependencies. Cut-and-paste isn't the right answer. > Initial patch for KIP-25 > > > Key: KAFKA-2276 > URL: https://issues.apache.org/jira/browse/KAFKA-2276 > Project: Kafka > Issue Type: Bug >Reporter: Geoff Anderson >Assignee: Geoff Anderson > Fix For: 0.8.3 > > > Submit initial patch for KIP-25 > (https://cwiki.apache.org/confluence/display/KAFKA/KIP-25+-+System+test+improvements) > This patch should contain a few Service classes and a few tests which can > serve as examples -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2276) Initial patch for KIP-25
[ https://issues.apache.org/jira/browse/KAFKA-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645265#comment-14645265 ] ASF GitHub Bot commented on KAFKA-2276: --- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/70 Initial patch for KIP-25 Key: KAFKA-2276 URL: https://issues.apache.org/jira/browse/KAFKA-2276 Project: Kafka Issue Type: Bug Reporter: Geoffrey Anderson Assignee: Geoffrey Anderson Fix For: 0.8.3 Submit initial patch for KIP-25 (https://cwiki.apache.org/confluence/display/KAFKA/KIP-25+-+System+test+improvements) This patch should contain a few Service classes and a few tests which can serve as examples -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2276) Initial patch for KIP-25
[ https://issues.apache.org/jira/browse/KAFKA-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645268#comment-14645268 ] Guozhang Wang commented on KAFKA-2276: -- Thanks for the patch [~granders], it is committed to trunk. Initial patch for KIP-25 Key: KAFKA-2276 URL: https://issues.apache.org/jira/browse/KAFKA-2276 Project: Kafka Issue Type: Bug Reporter: Geoffrey Anderson Assignee: Geoffrey Anderson Fix For: 0.9.0 Submit initial patch for KIP-25 (https://cwiki.apache.org/confluence/display/KAFKA/KIP-25+-+System+test+improvements) This patch should contain a few Service classes and a few tests which can serve as examples -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-2276) Initial patch for KIP-25
[ https://issues.apache.org/jira/browse/KAFKA-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14596624#comment-14596624 ] Geoffrey Anderson commented on KAFKA-2276: -- Pull request is here: https://github.com/apache/kafka/pull/70 Initial patch for KIP-25 Key: KAFKA-2276 URL: https://issues.apache.org/jira/browse/KAFKA-2276 Project: Kafka Issue Type: Bug Reporter: Geoffrey Anderson Assignee: Geoffrey Anderson Submit initial patch for KIP-25 (https://cwiki.apache.org/confluence/display/KAFKA/KIP-25+-+System+test+improvements) This patch should contain a few Service classes and a few tests which can serve as examples -- This message was sent by Atlassian JIRA (v6.3.4#6332)
