[ https://issues.apache.org/jira/browse/KAFKA-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653095#comment-14653095 ]
ASF GitHub Bot commented on KAFKA-2402: --------------------------------------- GitHub user becketqin opened a pull request: https://github.com/apache/kafka/pull/108 KAFKA-2402: Create IsrChangeNotificationPath when server statrs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/becketqin/kafka KAFKA-2402 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/108.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #108 ---- commit 37e423066c5ff8a695a8fcde4f0c2e51832aa6b5 Author: Jiangjie Qin <becket....@gmail.com> Date: 2015-08-04T05:36:20Z KAFKA-2402: Create IsrChangeNotificationPath when start the server. ---- > Broker should create zkpath /isr_change_notification if it does not exist > when updating ISR. > -------------------------------------------------------------------------------------------- > > Key: KAFKA-2402 > URL: https://issues.apache.org/jira/browse/KAFKA-2402 > Project: Kafka > Issue Type: Bug > Reporter: Jiangjie Qin > Assignee: Jiangjie Qin > > This is a follow up patch for KAFKA-1367. > When broker update ISR of partitions, it should ensure zkPath > /isr_change_notification exist. This does not matter when users do a clean > deploy of Kafka cluster because controller will always create the cluster. > But it matters when users are doing a rolling upgrade since the controller > could still be running on a old version broker. In that case, > ZkNoNodeException will be thrown and replica fetching will fail. > We can either document the upgrade process to ask user create the zk path > manually before upgrade or preferably we can handle it in the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)