[jira] [Commented] (KAFKA-2446) KAFKA-2205 causes existing Topic config changes to be lost

2015-08-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704103#comment-14704103
 ] 

ASF GitHub Bot commented on KAFKA-2446:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/152


> KAFKA-2205 causes existing Topic config changes to be lost
> --
>
> Key: KAFKA-2446
> URL: https://issues.apache.org/jira/browse/KAFKA-2446
> Project: Kafka
>  Issue Type: Bug
>Reporter: Aditya Auradkar
>Assignee: Aditya Auradkar
>
> The path was changed from "/config/topics/" to "/config/topic". This causes 
> existing config overrides to not get read



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-2446) KAFKA-2205 causes existing Topic config changes to be lost

2015-08-19 Thread Aditya Auradkar (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704037#comment-14704037
 ] 

Aditya Auradkar commented on KAFKA-2446:


[~junrao][~jjkoshy] - Can one of you review this quickly?
https://github.com/apache/kafka/pull/152/



> KAFKA-2205 causes existing Topic config changes to be lost
> --
>
> Key: KAFKA-2446
> URL: https://issues.apache.org/jira/browse/KAFKA-2446
> Project: Kafka
>  Issue Type: Bug
>Reporter: Aditya Auradkar
>Assignee: Aditya Auradkar
>
> The path was changed from "/config/topics/" to "/config/topic". This causes 
> existing config overrides to not get read



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-2446) KAFKA-2205 causes existing Topic config changes to be lost

2015-08-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704033#comment-14704033
 ] 

ASF GitHub Bot commented on KAFKA-2446:
---

GitHub user auradkar opened a pull request:

https://github.com/apache/kafka/pull/152

Fix for KAFKA-2446

This bug was introduced while committing KAFKA-2205. Basically, the path 
for topic overrides was renamed to "topic" from "topics". However, this causes 
existing topic config overrides to break because they will not be read from ZK 
anymore since the path is different.

https://reviews.apache.org/r/34554/

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/auradkar/kafka 2446

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #152


commit 4bb7adeb27673145dcb735f9e2039a05d94faea8
Author: Aditya Auradkar 
Date:   2015-08-20T00:12:04Z

Fix for 2446




> KAFKA-2205 causes existing Topic config changes to be lost
> --
>
> Key: KAFKA-2446
> URL: https://issues.apache.org/jira/browse/KAFKA-2446
> Project: Kafka
>  Issue Type: Bug
>Reporter: Aditya Auradkar
>Assignee: Aditya Auradkar
>
> The path was changed from "/config/topics/" to "/config/topic". This causes 
> existing config overrides to not get read



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)