[jira] [Commented] (KAFKA-2839) Kafka connect log test failing

[jin xing (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048431#comment-15048431
 ] 

jin xing commented on KAFKA-2839:
-

[~ewencp]
No problem, hope to have chance to contribute to Kafka : )

> Kafka connect log test failing
> --
>
> Key: KAFKA-2839
> URL: https://issues.apache.org/jira/browse/KAFKA-2839
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Gwen Shapira
>Assignee: jin xing
> Fix For: 0.9.1.0
>
>
> org.apache.kafka.connect.util.KafkaBasedLogTest > testSendAndReadToEnd FAILED
> org.junit.ComparisonFailure: expected: but was:
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at 
> org.apache.kafka.connect.util.KafkaBasedLogTest.testSendAndReadToEnd(KafkaBasedLogTest.java:312)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-2839) Kafka connect log test failing

[jin xing (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15031299#comment-15031299
 ] 

jin xing commented on KAFKA-2839:
-

I believe there is a bug in KafkaBasedLogTest implementation;
Records are appended to "KafkaBasedLog" by :
consumer.addRecord(new ConsumerRecord<>(TOPIC, 0, 0, TP0_KEY, TP0_VALUE));
consumer.addRecord(new ConsumerRecord<>(TOPIC, 0, 1, TP0_KEY, TP0_VALUE_NEW));
consumer.addRecord(new ConsumerRecord<>(TOPIC, 1, 0, TP1_KEY, TP1_VALUE));
consumer.addRecord(new ConsumerRecord<>(TOPIC, 1, 1, TP1_KEY, TP1_VALUE_NEW));
and achieved by "consumedRecords";
Inside of "ConsumerRecords", in order to turn "records", which is a HashMap>>, 
into Iterator>;
We can just guarantee the sequence underneath same key, while we cannot assure 
the sequence under different keys;
Am I wrong?
I already make a pull request for this fix;
[~gwenshap]

> Kafka connect log test failing
> --
>
> Key: KAFKA-2839
> URL: https://issues.apache.org/jira/browse/KAFKA-2839
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Gwen Shapira
>
> org.apache.kafka.connect.util.KafkaBasedLogTest > testSendAndReadToEnd FAILED
> org.junit.ComparisonFailure: expected: but was:
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at 
> org.apache.kafka.connect.util.KafkaBasedLogTest.testSendAndReadToEnd(KafkaBasedLogTest.java:312)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)