[jira] [Commented] (KAFKA-2972) ControlledShutdownResponse always deserialises `partitionsRemaining` as empty

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048976#comment-15048976
 ] 

ASF GitHub Bot commented on KAFKA-2972:
---

GitHub user ijuma opened a pull request:

https://github.com/apache/kafka/pull/649

KAFKA-2972; Add missing `partitionsRemaingList.add` in 
`ControlledShutdownResponse` constructor



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ijuma/kafka 
KAFKA-2972-controlled-shutdown-response-bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/649.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #649


commit 82eb116122637e05221a8afbceae12d97cc1463d
Author: Ismael Juma 
Date:   2015-12-09T16:57:56Z

Add missing `partitionsRemaingList.add` in `ControlledShutdownResponse` 
constructor




> ControlledShutdownResponse always deserialises `partitionsRemaining` as empty
> -
>
> Key: KAFKA-2972
> URL: https://issues.apache.org/jira/browse/KAFKA-2972
> Project: Kafka
>  Issue Type: Bug
>  Components: network
>Affects Versions: 0.9.0.0
>Reporter: Ismael Juma
>Assignee: Ismael Juma
> Fix For: 0.9.0.1
>
>
> This was a regression introduced when moving to Java request/response classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-2972) ControlledShutdownResponse always deserialises `partitionsRemaining` as empty

[Ismael Juma (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049292#comment-15049292
 ] 

Ismael Juma commented on KAFKA-2972:


Changed fix version as the Java instance of the response is not used to 
serialise the data in 0.9.0 and the problem is at serialisation time.

> ControlledShutdownResponse always deserialises `partitionsRemaining` as empty
> -
>
> Key: KAFKA-2972
> URL: https://issues.apache.org/jira/browse/KAFKA-2972
> Project: Kafka
>  Issue Type: Bug
>  Components: network
>Affects Versions: 0.9.0.0
>Reporter: Ismael Juma
>Assignee: Ismael Juma
> Fix For: 0.9.1.0
>
>
> This was a regression introduced when moving to Java request/response classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)