[jira] [Commented] (KAFKA-2974) `==` is used incorrectly in a few places in Java code

2015-12-09 Thread Ismael Juma (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049437#comment-15049437
 ] 

Ismael Juma commented on KAFKA-2974:


https://github.com/apache/kafka/pull/652

> `==` is used incorrectly in a few places in Java code
> -
>
> Key: KAFKA-2974
> URL: https://issues.apache.org/jira/browse/KAFKA-2974
> Project: Kafka
>  Issue Type: Bug
>Affects Versions: 0.9.0.0
>Reporter: Ismael Juma
>Assignee: Ismael Juma
>
> Unlike Scala, `==` is reference equality in Java and one normally wants to 
> use `equals`. We should fix the cases where `==` is used incorrectly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-2974) `==` is used incorrectly in a few places in Java code

2015-12-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050039#comment-15050039
 ] 

ASF GitHub Bot commented on KAFKA-2974:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/652


> `==` is used incorrectly in a few places in Java code
> -
>
> Key: KAFKA-2974
> URL: https://issues.apache.org/jira/browse/KAFKA-2974
> Project: Kafka
>  Issue Type: Bug
>Affects Versions: 0.9.0.0
>Reporter: Ismael Juma
>Assignee: Ismael Juma
>
> Unlike Scala, `==` is reference equality in Java and one normally wants to 
> use `equals`. We should fix the cases where `==` is used incorrectly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)