[jira] [Commented] (KAFKA-3046) add ByteBuffer Serializer

[Guozhang Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247174#comment-15247174
 ] 

Guozhang Wang commented on KAFKA-3046:
--

[~vesense] I'm currently working on KAFKA-3499 and I'm considering adding 
another Bytes class wrapping immutable byte arrays for serde 
(https://github.com/apache/kafka/pull/1229/files/9302bc18c8fa400b1fb7d4b36f29c8f0c812785c#r60079246).

Since your addition of ByteBufferSerde is not included in any releases yet, I'm 
wondering if I can just replace these classes with BytesSerializer and 
BytesDeserializer, since having both Bytes and ByteBuffer for serde sounds 
duplicates. What's your usage in spark-sql? Does that must require a mutable 
ByteBuffer, or does immutable Bytes work for you? Please let me know your 
thoughts.

> add ByteBuffer Serializer
> --
>
> Key: KAFKA-3046
> URL: https://issues.apache.org/jira/browse/KAFKA-3046
> Project: Kafka
>  Issue Type: New Feature
>  Components: clients
>Reporter: Xin Wang
> Fix For: 0.10.0.0
>
>
> ByteBuffer is widely used in many scenarios. (eg: storm-sql can specify kafka 
> as the external data Source, we can use ByteBuffer for value serializer.) 
> Adding ByteBuffer Serializer officially will be convenient for 
> users to use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3046) add ByteBuffer Serializer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159831#comment-15159831
 ] 

ASF GitHub Bot commented on KAFKA-3046:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/718


> add ByteBuffer Serializer
> --
>
> Key: KAFKA-3046
> URL: https://issues.apache.org/jira/browse/KAFKA-3046
> Project: Kafka
>  Issue Type: New Feature
>  Components: clients
>Reporter: Xin Wang
> Fix For: 0.10.0.0
>
>
> ByteBuffer is widely used in many scenarios. (eg: storm-sql can specify kafka 
> as the external data Source, we can use ByteBuffer for value serializer.) 
> Adding ByteBuffer Serializer officially will be convenient for 
> users to use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3046) add ByteBuffer Serializer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073536#comment-15073536
 ] 

ASF GitHub Bot commented on KAFKA-3046:
---

GitHub user vesense opened a pull request:

https://github.com/apache/kafka/pull/718

KAFKA-3046: add ByteBuffer Serializer

https://issues.apache.org/jira/browse/KAFKA-3046

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vesense/kafka patch-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/718.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #718


commit 0f39db647e2a1a3189aba6d2fa96aa4c1156bf86
Author: Xin Wang 
Date:   2015-12-29T05:57:13Z

add bytebuffer ser

commit 711a8b594bd7a2a5eacb958b74ab85ba10d97158
Author: Xin Wang 
Date:   2015-12-29T05:58:49Z

add bytebuffer deser




> add ByteBuffer Serializer
> --
>
> Key: KAFKA-3046
> URL: https://issues.apache.org/jira/browse/KAFKA-3046
> Project: Kafka
>  Issue Type: New Feature
>  Components: clients
>Reporter: Xin Wang
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)