[jira] [Commented] (KAFKA-3106) After PUT a connector config from REST API, GET a connector config will fail
[ https://issues.apache.org/jira/browse/KAFKA-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819889#comment-15819889 ] ASF GitHub Bot commented on KAFKA-3106: --- Github user jinxing64 closed the pull request at: https://github.com/apache/kafka/pull/783 > After PUT a connector config from REST API, GET a connector config will fail > - > > Key: KAFKA-3106 > URL: https://issues.apache.org/jira/browse/KAFKA-3106 > Project: Kafka > Issue Type: Bug > Components: KafkaConnect >Reporter: jin xing >Assignee: jin xing >Priority: Minor > > If there is already a connector in Connect, and we PUT a connector config by > REST API, the assignment.offset of DistributedHerder will below the > configStat.offset, thus GET connector config though REST API will fail > because of failed to pass "checkConfigSynced"; > The failed message is "Cannot get config data because config is not in sync > and this is not the leader"; > There need to be a rebalance process for PUT to update the assignment.offset; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3106) After PUT a connector config from REST API, GET a connector config will fail
[ https://issues.apache.org/jira/browse/KAFKA-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101417#comment-15101417 ] jin xing commented on KAFKA-3106: - [~ewencp] I agree with you that rebalance is a pretty expensive process, and there is no need to invoke a rebalance if updating an existing connector config; But by updating an existing connector config, it will update the configState's offset in DistributedHerder, thus the assignment's offset may fall behind the configState's offset; So we cannot judge if the config is in sync by "configState.offset() != assignment.offset()"; > After PUT a connector config from REST API, GET a connector config will fail > - > > Key: KAFKA-3106 > URL: https://issues.apache.org/jira/browse/KAFKA-3106 > Project: Kafka > Issue Type: Bug > Components: copycat >Reporter: jin xing >Assignee: jin xing > > If there is already a connector in Connect, and we PUT a connector config by > REST API, the assignment.offset of DistributedHerder will below the > configStat.offset, thus GET connector config though REST API will fail > because of failed to pass "checkConfigSynced"; > The failed message is "Cannot get config data because config is not in sync > and this is not the leader"; > There need to be a rebalance process for PUT to update the assignment.offset; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3106) After PUT a connector config from REST API, GET a connector config will fail
[ https://issues.apache.org/jira/browse/KAFKA-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098458#comment-15098458 ] Ewen Cheslack-Postava commented on KAFKA-3106: -- Rebalances are going to be pretty expensive since all the connectors need to flush, commit offsets, and be stopped before you can safely rebalance if you don't want to lose any work you've already done. Therefore we should be very careful to only rebalance when absolutely necessary. So, generally you should *not* rebalance if you're updating an existing connector config since the connector can pick up the config change without a rebalance and depending on what changed, the change may never even need to trigger a rebalance. > After PUT a connector config from REST API, GET a connector config will fail > - > > Key: KAFKA-3106 > URL: https://issues.apache.org/jira/browse/KAFKA-3106 > Project: Kafka > Issue Type: Bug > Components: copycat >Reporter: jin xing >Assignee: jin xing > > If there is already a connector in Connect, and we PUT a connector config by > REST API, the assignment.offset of DistributedHerder will below the > configStat.offset, thus GET connector config though REST API will fail > because of failed to pass "checkConfigSynced"; > The failed message is "Cannot get config data because config is not in sync > and this is not the leader"; > There need to be a rebalance process for PUT to update the assignment.offset; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-3106) After PUT a connector config from REST API, GET a connector config will fail
[ https://issues.apache.org/jira/browse/KAFKA-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097951#comment-15097951 ] jin xing commented on KAFKA-3106: - [~ewencp] Is is appropriate to call a rebalance by "member.reqeustRejoin()" in DistributedHerder::tick() no matter the config is for a new connector config or updating an existing one; > After PUT a connector config from REST API, GET a connector config will fail > - > > Key: KAFKA-3106 > URL: https://issues.apache.org/jira/browse/KAFKA-3106 > Project: Kafka > Issue Type: Bug > Components: copycat >Reporter: jin xing >Assignee: jin xing > > If there is already a connector in Connect, and we PUT a connector config by > REST API, the assignment.offset of DistributedHerder will below the > configStat.offset, thus GET connector config though REST API will fail > because of failed to pass "checkConfigSynced"; > The failed message is "Cannot get config data because config is not in sync > and this is not the leader"; > There is a rebalance process for PUT a connector to update the > assignment.offset; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
