[jira] [Commented] (KAFKA-3226) Replicas collections should use List instead of Set in order to maintain order

2016-02-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141460#comment-15141460
 ] 

ASF GitHub Bot commented on KAFKA-3226:
---

GitHub user granthenke opened a pull request:

https://github.com/apache/kafka/pull/900

KAFKA-3226: Replicas collections should use List instead of Set in or…

…der to maintain order

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/granthenke/kafka replicas-list

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/900.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #900






> Replicas collections should use List instead of Set in order to maintain order
> --
>
> Key: KAFKA-3226
> URL: https://issues.apache.org/jira/browse/KAFKA-3226
> Project: Kafka
>  Issue Type: Bug
>Affects Versions: 0.9.0.0
>Reporter: Grant Henke
>Assignee: Grant Henke
> Fix For: 0.9.0.1
>
>
> Found an issue where LeaderAndIsrRequest and UpdateMetadataRequest store the 
> replicas in a Set. This potentially changes the order of the replicas list, 
> which is important because the first replica is the "preferred" replica. 
> The question is, do these requests need to go through a 
> deprecation/compatibility cycle, or are they considered internal messages?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-3226) Replicas collections should use List instead of Set in order to maintain order

2016-02-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141858#comment-15141858
 ] 

ASF GitHub Bot commented on KAFKA-3226:
---

Github user granthenke closed the pull request at:

https://github.com/apache/kafka/pull/900


> Replicas collections should use List instead of Set in order to maintain order
> --
>
> Key: KAFKA-3226
> URL: https://issues.apache.org/jira/browse/KAFKA-3226
> Project: Kafka
>  Issue Type: Bug
>Affects Versions: 0.9.0.0
>Reporter: Grant Henke
>Assignee: Grant Henke
> Fix For: 0.9.0.1
>
>
> Found an issue where LeaderAndIsrRequest and UpdateMetadataRequest store the 
> replicas in a Set. This potentially changes the order of the replicas list, 
> which is important because the first replica is the "preferred" replica. 
> The question is, do these requests need to go through a 
> deprecation/compatibility cycle, or are they considered internal messages?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)