[ 
https://issues.apache.org/jira/browse/KAFKA-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189199#comment-15189199
 ] 

ASF GitHub Bot commented on KAFKA-3375:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/1042

    KAFKA-3375; Suppress deprecated warnings where reasonable and tweak 
compiler settings

    * Fix and suppress number of unchecked warnings (except for Kafka Streams)
    * Add `@SafeVarargs` annotation to fix warnings
    * Suppress unfixable deprecation warnings
    * Replace deprecated by non-deprecated usage where possible
    * Avoid reflective calls via structural types in Scala
    * Tweak compiler settings for scalac and javac
    
    Once we drop Java 7 and Scala 2.10, we can tweak the compiler settings 
further so that they warn us about more things.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka 
kafka-3375-suppress-depreccated-tweak-compiler

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1042.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1042
    
----
commit bdb6bf5b6c1b95c2166126de10704801abde03f4
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2016-03-10T11:56:47Z

    Fix and suppress number of unchecked warnings
    
    Ignored Kafka Streams on this iteration.

commit 3973c010111b7c0d69c558311548ebbc33992a47
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2016-03-10T11:57:18Z

    Add `@SafeVarargs` annotation to fix warning

commit afb96c7b3fb423cc34d86d69a3e906d65a753ff9
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2016-03-10T11:58:02Z

    Suppress unfixable deprecation warnings

commit 1db45ac43c88beb8949849b4ae2e04b21c698b7f
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2016-03-10T11:58:25Z

    Replace deprecated by non-deprecated usage

commit 08542a0c007b5a12dcc8a59a34f81215e8a6c1bd
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2016-03-10T11:58:57Z

    Avoid reflective calls via structural types in Scala

commit 5667ff91d80c8c94a5d30a520c088b211b5bfe0b
Author: Ismael Juma <ism...@juma.me.uk>
Date:   2016-03-10T11:59:57Z

    Tweak compiler settings for scalac and javac

----


> Suppress deprecated warnings where reasonable and tweak compiler settings
> -------------------------------------------------------------------------
>
>                 Key: KAFKA-3375
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3375
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Ismael Juma
>            Assignee: Ismael Juma
>             Fix For: 0.10.0.0
>
>
> This will make it easier to do KAFKA-2982.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to