[jira] [Commented] (KAFKA-3500) KafkaOffsetBackingStore set method needs to handle null

2016-07-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15394972#comment-15394972
 ] 

ASF GitHub Bot commented on KAFKA-3500:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/1662


> KafkaOffsetBackingStore set method needs to handle null 
> 
>
> Key: KAFKA-3500
> URL: https://issues.apache.org/jira/browse/KAFKA-3500
> Project: Kafka
>  Issue Type: Bug
>  Components: KafkaConnect
>Affects Versions: 0.10.0.0
>Reporter: Liquan Pei
>Assignee: Ewen Cheslack-Postava
>Priority: Blocker
> Fix For: 0.10.1.0, 0.10.0.1
>
>
> In some cases, the key or value for the offset map can be null. However, it 
> seems that we didn't handle null properly in this case and didn't perform 
> null check when converting the byte buffer back to byte array. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3500) KafkaOffsetBackingStore set method needs to handle null

2016-07-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392696#comment-15392696
 ] 

ASF GitHub Bot commented on KAFKA-3500:
---

GitHub user ewencp opened a pull request:

https://github.com/apache/kafka/pull/1662

KAFKA-3500: Handle null keys and values in KafkaOffsetBackingStore.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ewencp/kafka 
kafka-3500-kafka-offset-backing-store-null

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/1662.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1662


commit 55e1fc1408da05bb443c89a758f3c4f0e09056d6
Author: Ewen Cheslack-Postava 
Date:   2016-07-25T20:57:41Z

KAFKA-3500: Handle null keys and values in KafkaOffsetBackingStore.




> KafkaOffsetBackingStore set method needs to handle null 
> 
>
> Key: KAFKA-3500
> URL: https://issues.apache.org/jira/browse/KAFKA-3500
> Project: Kafka
>  Issue Type: Bug
>  Components: KafkaConnect
>Affects Versions: 0.10.0.0
>Reporter: Liquan Pei
>Assignee: Ewen Cheslack-Postava
>Priority: Critical
> Fix For: 0.10.0.1
>
>
> In some cases, the key or value for the offset map can be null. However, it 
> seems that we didn't handle null properly in this case and didn't perform 
> null check when converting the byte buffer back to byte array. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3500) KafkaOffsetBackingStore set method needs to handle null

2016-07-25 Thread Ewen Cheslack-Postava (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392574#comment-15392574
 ] 

Ewen Cheslack-Postava commented on KAFKA-3500:
--

[~liquanpei] Going to grab this since we wanted to get it fixed and I think 
you've got other stuff on your plate. If you've got something in progress 
already, let me know.

> KafkaOffsetBackingStore set method needs to handle null 
> 
>
> Key: KAFKA-3500
> URL: https://issues.apache.org/jira/browse/KAFKA-3500
> Project: Kafka
>  Issue Type: Bug
>  Components: KafkaConnect
>Affects Versions: 0.10.0.0
>Reporter: Liquan Pei
>Assignee: Liquan Pei
>Priority: Critical
> Fix For: 0.10.0.1
>
>
> In some cases, the key or value for the offset map can be null. However, it 
> seems that we didn't handle null properly in this case and didn't perform 
> null check when converting the byte buffer back to byte array. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)