[jira] [Commented] (KAFKA-3592) System tests - don't hardcode paths to scripts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274486#comment-15274486
 ] 

ASF GitHub Bot commented on KAFKA-3592:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/1245


> System tests - don't hardcode paths to scripts
> --
>
> Key: KAFKA-3592
> URL: https://issues.apache.org/jira/browse/KAFKA-3592
> Project: Kafka
>  Issue Type: Improvement
>  Components: system tests
>Reporter: Geoff Anderson
>Assignee: Geoff Anderson
> Fix For: 0.10.1.0
>
>
> In the various service classes in the kafkatest module (aka python system 
> test code), there are numerous hard-coded paths to bin scripts which make it 
> hard to run tests on anything other than the very specific installation 
> performed in the vagrant provisioning files.
> This change is partially a standard DRY improvement, and also should make it 
> possible to reuse service classes defined in kafkatest without being confined 
> to any particular assumptions about directory layout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3592) System tests - don't hardcode paths to scripts

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250663#comment-15250663
 ] 

ASF GitHub Bot commented on KAFKA-3592:
---

GitHub user granders opened a pull request:

https://github.com/apache/kafka/pull/1245

KAFKA-3592: System test - configurable paths [WIP]

This patch adds logic for the following:
- remove hard-coded paths to various scripts and jars in kafkatest service 
classes
- provide a mechanism for overriding path resolution logic with a 
"pluggable" path resolver class

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/confluentinc/kafka configurable-install-path

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/1245.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1245


commit 1bd1d63e8aeec23bf043774af9aa59f0b038084a
Author: Geoff Anderson 
Date:   2016-04-11T20:09:40Z

First pass on updating path resolution

commit 088e6d1a2e8ea30905d899c8fb1cf60c6fa3f934
Author: Geoff Anderson 
Date:   2016-04-12T00:36:38Z

Moved system test path resolution logic

commit 386f995594d0fb8769d43b5914b43fe7a77085db
Author: Geoff Anderson 
Date:   2016-04-12T01:31:39Z

Renamed kafka system test path resolver

commit c6c764e867450e5b263c66a58f46c735bc0bc622
Author: Geoff Anderson 
Date:   2016-04-14T01:13:49Z

Cleanup of path resolution, moved kafka version to avoid circular imports.

commit 9a0a8bedff68a9998c87c8382f9672abceef7233
Author: Geoff Anderson 
Date:   2016-04-15T00:10:32Z

Updated services to use path resolver

commit a0751503445678b4ae76e1fc33bd1b0fbf374142
Author: Geoff Anderson 
Date:   2016-04-15T23:17:43Z

Refactored path resolver; simplified method definitions

commit 0cb26c7f2b186bbbc0203826f88cf189faf6d1f8
Author: Geoff Anderson 
Date:   2016-04-19T17:56:05Z

Added missing path resolver

commit 293ae1dafa10eef2ff36d08f2877e565ed083ab5
Author: Geoff Anderson 
Date:   2016-04-20T19:44:19Z

Added python unit tests for system test path resolution logic




> System tests - don't hardcode paths to scripts
> --
>
> Key: KAFKA-3592
> URL: https://issues.apache.org/jira/browse/KAFKA-3592
> Project: Kafka
>  Issue Type: Improvement
>  Components: system tests
>Reporter: Geoff Anderson
>Assignee: Geoff Anderson
> Fix For: 0.10.0.0
>
>
> In the various service classes in the kafkatest module (aka python system 
> test code), there are numerous hard-coded paths to bin scripts which make it 
> hard to run tests on anything other than the very specific installation 
> performed in the vagrant provisioning files.
> This change is partially a standard DRY improvement, and also should make it 
> possible to reuse service classes defined in kafkatest without being confined 
> to any particular assumptions about directory layout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)