[jira] [Commented] (KAFKA-3784) TimeWindows#windowsFor misidentifies some windows if TimeWindows#advanceBy is used

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314736#comment-15314736
 ] 

ASF GitHub Bot commented on KAFKA-3784:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/1462


> TimeWindows#windowsFor misidentifies some windows if TimeWindows#advanceBy is 
> used
> --
>
> Key: KAFKA-3784
> URL: https://issues.apache.org/jira/browse/KAFKA-3784
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.0.0
>Reporter: Tom Rybak
>Assignee: Tom Rybak
>Priority: Minor
>  Labels: architecture
> Fix For: 0.10.0.1
>
>
> Using a time window of size 6 minutes with a 5 minute advanceBy results in 
> some of the timestamped data being inserted into the previous overlapping 
> window even though the event's timestamp > that window's end time. 
> The fault lies in TimeWindows#windowsFor which does not check that all the 
> windows it's adding have an endTime > event's timestamp. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3784) TimeWindows#windowsFor misidentifies some windows if TimeWindows#advanceBy is used

[Tom Rybak (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313374#comment-15313374
 ] 

Tom Rybak commented on KAFKA-3784:
--

I made a pull request with the fix, plus a unit test that can be used to verify 
that the problem used to exist. 

https://github.com/apache/kafka/pull/1462

> TimeWindows#windowsFor misidentifies some windows if TimeWindows#advanceBy is 
> used
> --
>
> Key: KAFKA-3784
> URL: https://issues.apache.org/jira/browse/KAFKA-3784
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Affects Versions: 0.10.0.0
>Reporter: Tom Rybak
>Priority: Minor
>
> Using a time window of size 6 minutes with a 5 minute advanceBy results in 
> some of the timestamped data being inserted into the previous overlapping 
> window even though the event's timestamp > that window's end time. 
> The fault lies in TimeWindows#windowsFor which does not check that all the 
> windows it's adding have an endTime > event's timestamp. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-3784) TimeWindows#windowsFor misidentifies some windows if TimeWindows#advanceBy is used

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15313368#comment-15313368
 ] 

ASF GitHub Bot commented on KAFKA-3784:
---

GitHub user trybak opened a pull request:

https://github.com/apache/kafka/pull/1462

KAFKA-3784 TimeWindows#windowsFor misidentifies some windows if 
TimeWindows#advanceBy is used

- Fixed the logic calculating the windows that are affected by a new …event 
in the case of hopping windows and a small overlap.
- Added a unit test that tests for the issue

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/trybak/kafka 
bugfix/KAFKA-3784-TimeWindows#windowsFor-false-positives

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/1462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1462


commit 6705e3167b548e6e4457b5c99e4fe271f6726501
Author: Tom Rybak 
Date:   2016-06-03T00:10:21Z

- Fixed the logic calculating the windows that are affected by a new event 
in the case of hopping windows and a small overlap.
- Added a unit test that tests for the issue




> TimeWindows#windowsFor misidentifies some windows if TimeWindows#advanceBy is 
> used
> --
>
> Key: KAFKA-3784
> URL: https://issues.apache.org/jira/browse/KAFKA-3784
> Project: Kafka
>  Issue Type: Bug
>  Components: core
>Affects Versions: 0.10.0.0
>Reporter: Tom Rybak
>Priority: Minor
>
> Using a time window of size 6 minutes with a 5 minute advanceBy results in 
> some of the timestamped data being inserted into the previous overlapping 
> window even though the event's timestamp > that window's end time. 
> The fault lies in TimeWindows#windowsFor which does not check that all the 
> windows it's adding have an endTime > event's timestamp. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)