[jira] [Commented] (KAFKA-4459) rat license check not running in Jenkins
[
https://issues.apache.org/jira/browse/KAFKA-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033264#comment-16033264
]
ASF GitHub Bot commented on KAFKA-4459:
---
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/3186
> rat license check not running in Jenkins
>
>
> Key: KAFKA-4459
> URL: https://issues.apache.org/jira/browse/KAFKA-4459
> Project: Kafka
> Issue Type: Bug
>Reporter: Ismael Juma
>Assignee: Ewen Cheslack-Postava
> Fix For: 0.11.0.0, 0.11.1.0
>
>
> The following commit introduced files without a license, which causes rat to
> fail when run locally:
> https://github.com/apache/kafka/commit/e035fc039598127e88f31739458f705290b1fdba
> However, the build passed in Jenkins:
> https://builds.apache.org/job/kafka-trunk-jdk7/1710/
> Not sure why, but a potential culprit is the check for `.git` in the build:
> {code}
> if (new File('.git').exists()) {
> apply from: file('gradle/rat.gradle')
> rat {
> // Exclude everything under the directory that git should be ignoring via
> .gitignore or that isn't checked in. These
> // restrict us only to files that are checked in or are staged.
> def repo = Grgit.open(project.file('.'))
> excludes = new ArrayList(repo.clean(ignore: false, directories:
> true, dryRun: true))
> // And some of the files that we have checked in should also be excluded
> from this check
> excludes.addAll([
> '**/.git/**',
> '**/build/**',
> 'CONTRIBUTING.md',
> 'gradlew',
> 'gradlew.bat',
> '**/README.md'
> ])
> }
> }
> {code}
> If the current directory in Jenkins is not the repo directory, it could fail.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (KAFKA-4459) rat license check not running in Jenkins
[
https://issues.apache.org/jira/browse/KAFKA-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15793651#comment-15793651
]
Ismael Juma commented on KAFKA-4459:
[~ewencp], the command for the job I linked to is:
{code}
./gradlew --no-daemon -Dorg.gradle.project.maxParallelForks=1
-Dorg.gradle.project.testLoggingEvents=started,passed,skipped,failed clean
testAll
{code}
It hasn't changed recently. I only changed the PR jobs.
> rat license check not running in Jenkins
>
>
> Key: KAFKA-4459
> URL: https://issues.apache.org/jira/browse/KAFKA-4459
> Project: Kafka
> Issue Type: Bug
>Reporter: Ismael Juma
> Fix For: 0.10.2.0
>
>
> The following commit introduced files without a license, which causes rat to
> fail when run locally:
> https://github.com/apache/kafka/commit/e035fc039598127e88f31739458f705290b1fdba
> However, the build passed in Jenkins:
> https://builds.apache.org/job/kafka-trunk-jdk7/1710/
> Not sure why, but a potential culprit is the check for `.git` in the build:
> {code}
> if (new File('.git').exists()) {
> apply from: file('gradle/rat.gradle')
> rat {
> // Exclude everything under the directory that git should be ignoring via
> .gitignore or that isn't checked in. These
> // restrict us only to files that are checked in or are staged.
> def repo = Grgit.open(project.file('.'))
> excludes = new ArrayList(repo.clean(ignore: false, directories:
> true, dryRun: true))
> // And some of the files that we have checked in should also be excluded
> from this check
> excludes.addAll([
> '**/.git/**',
> '**/build/**',
> 'CONTRIBUTING.md',
> 'gradlew',
> 'gradlew.bat',
> '**/README.md'
> ])
> }
> }
> {code}
> If the current directory in Jenkins is not the repo directory, it could fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-4459) rat license check not running in Jenkins
[
https://issues.apache.org/jira/browse/KAFKA-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15793625#comment-15793625
]
Ewen Cheslack-Postava commented on KAFKA-4459:
--
[~ijuma] Seems like the build logs have been deleted, so hard to tell what's
going on here. What is the build command that's running on jenkins? And has
that changed recently with the new builders for jenkins using different JVMs &
targets? Various targets manage to skip the tests such that the rat tests
attached to them won't run; seems like the key issue here is making sure that
the full set of tests that the rat tests are attached to are always executed as
part of the jenkins tests.
> rat license check not running in Jenkins
>
>
> Key: KAFKA-4459
> URL: https://issues.apache.org/jira/browse/KAFKA-4459
> Project: Kafka
> Issue Type: Bug
>Reporter: Ismael Juma
> Fix For: 0.10.2.0
>
>
> The following commit introduced files without a license, which causes rat to
> fail when run locally:
> https://github.com/apache/kafka/commit/e035fc039598127e88f31739458f705290b1fdba
> However, the build passed in Jenkins:
> https://builds.apache.org/job/kafka-trunk-jdk7/1710/
> Not sure why, but a potential culprit is the check for `.git` in the build:
> {code}
> if (new File('.git').exists()) {
> apply from: file('gradle/rat.gradle')
> rat {
> // Exclude everything under the directory that git should be ignoring via
> .gitignore or that isn't checked in. These
> // restrict us only to files that are checked in or are staged.
> def repo = Grgit.open(project.file('.'))
> excludes = new ArrayList(repo.clean(ignore: false, directories:
> true, dryRun: true))
> // And some of the files that we have checked in should also be excluded
> from this check
> excludes.addAll([
> '**/.git/**',
> '**/build/**',
> 'CONTRIBUTING.md',
> 'gradlew',
> 'gradlew.bat',
> '**/README.md'
> ])
> }
> }
> {code}
> If the current directory in Jenkins is not the repo directory, it could fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
