[jira] [Commented] (KAFKA-4831) Extract WindowedSerde to public APIs

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047003#comment-16047003
 ] 

ASF GitHub Bot commented on KAFKA-4831:
---

GitHub user vitaly-pushkar opened a pull request:

https://github.com/apache/kafka/pull/3307

KAFKA-4831: Extract WindowedSerde to public APIs

Now that we have augmented WindowSerde with non-arg parameters, extract it 
out as part of the public APIs so that users who want to I/O windowed streams 
can use it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vitaly-pushkar/kafka public-windowed-serde

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3307


commit 1ca0b72b7e119979b4bfe9d05b00295ac9f30ab3
Author: Vitaly Pushkar 
Date:   2017-06-04T22:34:40Z

Extract Windowed Serde into the public package API

commit 131b273675a773faa1f79eadd1715a1239e7aa6f
Author: Vitaly Pushkar 
Date:   2017-06-12T19:54:08Z

Extract Windowed Serde tests into public package




> Extract WindowedSerde to public APIs
> 
>
> Key: KAFKA-4831
> URL: https://issues.apache.org/jira/browse/KAFKA-4831
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Reporter: Guozhang Wang
>Assignee: Vitaly Pushkar
>  Labels: newbie, user-experience
>
> Now that we have augmented WindowSerde with non-arg parameters, the next step 
> is to extract it out as part of the public APIs so that users who wants to 
> I/O windowed streams can use it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-4831) Extract WindowedSerde to public APIs

[Vitaly Pushkar (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960362#comment-15960362
 ] 

Vitaly Pushkar commented on KAFKA-4831:
---

I see! Thank you [~mjsax]

> Extract WindowedSerde to public APIs
> 
>
> Key: KAFKA-4831
> URL: https://issues.apache.org/jira/browse/KAFKA-4831
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Reporter: Guozhang Wang
>Assignee: Vitaly Pushkar
>  Labels: newbie, user-experience
>
> Now that we have augmented WindowSerde with non-arg parameters, the next step 
> is to extract it out as part of the public APIs so that users who wants to 
> I/O windowed streams can use it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (KAFKA-4831) Extract WindowedSerde to public APIs

[Matthias J. Sax (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959761#comment-15959761
 ] 

Matthias J. Sax commented on KAFKA-4831:


The classes `WindowSerializer` and `WindowDeserializer` are in package 
`internals` and should be added to public API. We might also want to have a 
`Serde` class for windows.

> Extract WindowedSerde to public APIs
> 
>
> Key: KAFKA-4831
> URL: https://issues.apache.org/jira/browse/KAFKA-4831
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Reporter: Guozhang Wang
>Assignee: Vitaly Pushkar
>  Labels: newbie, user-experience
>
> Now that we have augmented WindowSerde with non-arg parameters, the next step 
> is to extract it out as part of the public APIs so that users who wants to 
> I/O windowed streams can use it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (KAFKA-4831) Extract WindowedSerde to public APIs

[Vitaly Pushkar (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959568#comment-15959568
 ] 

Vitaly Pushkar commented on KAFKA-4831:
---

Hello [~guozhang],

could you elaborate on this one, please?

What exactly do you mean should be extracted?

Thank you.

> Extract WindowedSerde to public APIs
> 
>
> Key: KAFKA-4831
> URL: https://issues.apache.org/jira/browse/KAFKA-4831
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Reporter: Guozhang Wang
>Assignee: Vitaly Pushkar
>  Labels: newbie, user-experience
>
> Now that we have augmented WindowSerde with non-arg parameters, the next step 
> is to extract it out as part of the public APIs so that users who wants to 
> I/O windowed streams can use it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)