[jira] [Commented] (KAFKA-4859) Transient test failure: org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion (again)
[ https://issues.apache.org/jira/browse/KAFKA-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15929446#comment-15929446 ] ASF GitHub Bot commented on KAFKA-4859: --- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/2682 > Transient test failure: > org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion > (again) > --- > > Key: KAFKA-4859 > URL: https://issues.apache.org/jira/browse/KAFKA-4859 > Project: Kafka > Issue Type: Sub-task > Components: streams >Reporter: Armin Braun >Assignee: Armin Braun > Fix For: 0.11.0.0 > > > Slightly different than KAFKA-3874 in terms of the way it fails. > Now we have: > {code} > Error Message > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > Stacktrace > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:257) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:206) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:175) > at > org.apache.kafka.streams.integration.KStreamKTableJoinIntegrationTest.shouldCountClicksPerRegion(KStreamKTableJoinIntegrationTest.java:297) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > {code} > e.g. here https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2032/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-4859) Transient test failure: org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion (again)
[ https://issues.apache.org/jira/browse/KAFKA-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925072#comment-15925072 ] ASF GitHub Bot commented on KAFKA-4859: --- Github user original-brownbear closed the pull request at: https://github.com/apache/kafka/pull/2680 > Transient test failure: > org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion > (again) > --- > > Key: KAFKA-4859 > URL: https://issues.apache.org/jira/browse/KAFKA-4859 > Project: Kafka > Issue Type: Sub-task > Components: streams >Reporter: Armin Braun >Assignee: Armin Braun > > Slightly different than KAFKA-3874 in terms of the way it fails. > Now we have: > {code} > Error Message > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > Stacktrace > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:257) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:206) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:175) > at > org.apache.kafka.streams.integration.KStreamKTableJoinIntegrationTest.shouldCountClicksPerRegion(KStreamKTableJoinIntegrationTest.java:297) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > {code} > e.g. here https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2032/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-4859) Transient test failure: org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion (again)
[ https://issues.apache.org/jira/browse/KAFKA-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923614#comment-15923614 ] ASF GitHub Bot commented on KAFKA-4859: --- GitHub user guozhangwang opened a pull request: https://github.com/apache/kafka/pull/2682 KAFKA-4859: Set shorter commit interval for integration tests with caching You can merge this pull request into a Git repository by running: $ git pull https://github.com/guozhangwang/kafka K4859-cache-commit-interval Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2682.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2682 commit 733ef40cbd698f8533cf888629f159a3e3168099 Author: Guozhang WangDate: 2017-03-14T05:24:59Z use shorter commit interval and also doubling on waiting conditions commit a486cebdfbbf7b833387b62800671d238fee2521 Author: Guozhang Wang Date: 2017-03-14T05:39:29Z use more conservative wait time > Transient test failure: > org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion > (again) > --- > > Key: KAFKA-4859 > URL: https://issues.apache.org/jira/browse/KAFKA-4859 > Project: Kafka > Issue Type: Sub-task > Components: streams >Reporter: Armin Braun >Assignee: Armin Braun > > Slightly different than KAFKA-3874 in terms of the way it fails. > Now we have: > {code} > Error Message > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > Stacktrace > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:257) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:206) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:175) > at > org.apache.kafka.streams.integration.KStreamKTableJoinIntegrationTest.shouldCountClicksPerRegion(KStreamKTableJoinIntegrationTest.java:297) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > {code} > e.g. here https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2032/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-4859) Transient test failure: org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion (again)
[ https://issues.apache.org/jira/browse/KAFKA-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923105#comment-15923105 ] ASF GitHub Bot commented on KAFKA-4859: --- GitHub user original-brownbear opened a pull request: https://github.com/apache/kafka/pull/2680 KAFKA-4859: Raised Timeout This fixes https://issues.apache.org/jira/browse/KAFKA-4859 for me over hundreds of iterations while I could easily reproduce it with less than ~30-40 iterations without the increased timeout. Also raising the timeout (at least on my setup) looks like a valid approach looking at test runtimes being consistently slightly above those 30s default timeout coming from `org.apache.kafka.streams.integration.utils.IntegrationTestUtils#DEFAULT_TIMEOUT`. ![byregion](https://cloud.githubusercontent.com/assets/6490959/23878174/1eac8154-0846-11e7-82a7-9e04f235630f.png) You can merge this pull request into a Git repository by running: $ git pull https://github.com/original-brownbear/kafka KAFKA-4859 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2680.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2680 commit 7f2d8854e369ced5c3a6e44da9042a84712601a1 Author: Armin BraunDate: 2017-03-13T22:35:06Z KAFKA-4859 Raised Timeout > Transient test failure: > org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion > (again) > --- > > Key: KAFKA-4859 > URL: https://issues.apache.org/jira/browse/KAFKA-4859 > Project: Kafka > Issue Type: Sub-task > Components: streams >Reporter: Armin Braun >Assignee: Armin Braun > > Slightly different than KAFKA-3874 in terms of the way it fails. > Now we have: > {code} > Error Message > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > Stacktrace > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:257) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:206) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:175) > at > org.apache.kafka.streams.integration.KStreamKTableJoinIntegrationTest.shouldCountClicksPerRegion(KStreamKTableJoinIntegrationTest.java:297) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > {code} > e.g. here https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2032/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-4859) Transient test failure: org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion (again)
[ https://issues.apache.org/jira/browse/KAFKA-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923095#comment-15923095 ] Armin Braun commented on KAFKA-4859: [~guozhang] so basically this can just be resolved by setting a higher timeout on the waiting before the last assert at the end of the test. {code:java} final List> actualClicksPerRegion = IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(consumerConfig, outputTopic, expectedClicksPerRegion.size(), 2 * IntegrationTestUtils.DEFAULT_TIMEOUT); assertThat(actualClicksPerRegion, equalTo(expectedClicksPerRegion)); } {code} Tested this over 200+ iterations just now, while I get to less than 30 without this adjustment. What I find interesting though is that the runtime for this test is always very close to 30s. Always kind of between 30.4s - 30.6s. Is this just a coincidence or is that 30s maybe coming from some place I missed and would allow expressing the timeout a little cleaner (i.e. as some constant + x)? If not I'd just put in a PR with the raised timeout? > Transient test failure: > org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion > (again) > --- > > Key: KAFKA-4859 > URL: https://issues.apache.org/jira/browse/KAFKA-4859 > Project: Kafka > Issue Type: Sub-task > Components: streams >Reporter: Armin Braun >Assignee: Armin Braun > > Slightly different than KAFKA-3874 in terms of the way it fails. > Now we have: > {code} > Error Message > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > Stacktrace > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:257) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:206) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:175) > at > org.apache.kafka.streams.integration.KStreamKTableJoinIntegrationTest.shouldCountClicksPerRegion(KStreamKTableJoinIntegrationTest.java:297) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > {code} > e.g. here https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2032/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-4859) Transient test failure: org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion (again)
[ https://issues.apache.org/jira/browse/KAFKA-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922979#comment-15922979 ] Armin Braun commented on KAFKA-4859: [~guozhang] zeroing in on it :) Should have a PR in either ~ 2h or ~ 12h :) > Transient test failure: > org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion > (again) > --- > > Key: KAFKA-4859 > URL: https://issues.apache.org/jira/browse/KAFKA-4859 > Project: Kafka > Issue Type: Sub-task > Components: streams >Reporter: Armin Braun >Assignee: Armin Braun > > Slightly different than KAFKA-3874 in terms of the way it fails. > Now we have: > {code} > Error Message > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > Stacktrace > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:257) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:206) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:175) > at > org.apache.kafka.streams.integration.KStreamKTableJoinIntegrationTest.shouldCountClicksPerRegion(KStreamKTableJoinIntegrationTest.java:297) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > {code} > e.g. here https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2032/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-4859) Transient test failure: org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion (again)
[ https://issues.apache.org/jira/browse/KAFKA-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922772#comment-15922772 ] Guozhang Wang commented on KAFKA-4859: -- [~original-brownbear] Thanks a lot for picking this up! Any good new on this investigation so far? It seems to be a high frequent transient failure in Jenkins and hence we'd like to fix it sooner. > Transient test failure: > org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion > (again) > --- > > Key: KAFKA-4859 > URL: https://issues.apache.org/jira/browse/KAFKA-4859 > Project: Kafka > Issue Type: Sub-task > Components: streams >Reporter: Armin Braun >Assignee: Armin Braun > > Slightly different than KAFKA-3874 in terms of the way it fails. > Now we have: > {code} > Error Message > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > Stacktrace > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:257) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:206) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:175) > at > org.apache.kafka.streams.integration.KStreamKTableJoinIntegrationTest.shouldCountClicksPerRegion(KStreamKTableJoinIntegrationTest.java:297) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > {code} > e.g. here https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2032/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (KAFKA-4859) Transient test failure: org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion (again)
[ https://issues.apache.org/jira/browse/KAFKA-4859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898873#comment-15898873 ] Armin Braun commented on KAFKA-4859: Looking into this one, can easily reproduce it at least. > Transient test failure: > org.apache.kafka.streams.integration.JoinIntegrationTest.shouldCountClicksPerRegion > (again) > --- > > Key: KAFKA-4859 > URL: https://issues.apache.org/jira/browse/KAFKA-4859 > Project: Kafka > Issue Type: Sub-task >Reporter: Armin Braun >Assignee: Armin Braun > > Slightly different than KAFKA-3874 in terms of the way it fails. > Now we have: > {code} > Error Message > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > Stacktrace > java.lang.AssertionError: Condition not met within timeout 3. Expecting 3 > records from topic output-topic-2 while only received 0: [] > at org.apache.kafka.test.TestUtils.waitForCondition(TestUtils.java:257) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:206) > at > org.apache.kafka.streams.integration.utils.IntegrationTestUtils.waitUntilMinKeyValueRecordsReceived(IntegrationTestUtils.java:175) > at > org.apache.kafka.streams.integration.KStreamKTableJoinIntegrationTest.shouldCountClicksPerRegion(KStreamKTableJoinIntegrationTest.java:297) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > {code} > e.g. here https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2032/ -- This message was sent by Atlassian JIRA (v6.3.15#6346)