[jira] [Commented] (KAFKA-724) Allow automatic socket.send.buffer from operating system

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15317541#comment-15317541
 ] 

ASF GitHub Bot commented on KAFKA-724:
--

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/1469


> Allow automatic socket.send.buffer from operating system
> 
>
> Key: KAFKA-724
> URL: https://issues.apache.org/jira/browse/KAFKA-724
> Project: Kafka
>  Issue Type: Improvement
>Affects Versions: 0.8.2.0
>Reporter: Pablo Barrera
>Assignee: Rekha Joshi
>  Labels: newbie
> Fix For: 0.10.1.0
>
>
> To do this, don't call to socket().setXXXBufferSize. This can be 
> controlled by the configuration parameter: if the value socket.send.buffer or 
> others are set to -1, don't call to socket().setXXXBufferSize



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-724) Allow automatic socket.send.buffer from operating system

[Ismael Juma (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315780#comment-15315780
 ] 

Ismael Juma commented on KAFKA-724:
---

This was fixed on the new producer and consumer in 0.9.0.0. The  PR also fixes 
the broker (i.e. `SocketServer`).

> Allow automatic socket.send.buffer from operating system
> 
>
> Key: KAFKA-724
> URL: https://issues.apache.org/jira/browse/KAFKA-724
> Project: Kafka
>  Issue Type: Improvement
>Affects Versions: 0.8.2.0
>Reporter: Pablo Barrera
>Assignee: Rekha Joshi
>  Labels: newbie
> Fix For: 0.10.1.0
>
>
> To do this, don't call to socket().setXXXBufferSize. This can be 
> controlled by the configuration parameter: if the value socket.send.buffer or 
> others are set to -1, don't call to socket().setXXXBufferSize



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-724) Allow automatic socket.send.buffer from operating system

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315696#comment-15315696
 ] 

ASF GitHub Bot commented on KAFKA-724:
--

GitHub user rekhajoshm opened a pull request:

https://github.com/apache/kafka/pull/1469

KAFKA-724; Send, receive buffer size set if not -1

PR #50 closed. Fixed, after rebase on trunk.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rekhajoshm/kafka KAFKA-724-rebased

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/1469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1469


commit c9a66992b1095616f87c5748f210b973ebc7eb01
Author: Rekha Joshi 
Date:   2016-05-26T17:48:37Z

Merge pull request #2 from apache/trunk

Apache Kafka trunk pull

commit 8d7fb005cb132440e7768a5b74257d2598642e0f
Author: Rekha Joshi 
Date:   2016-05-30T21:37:43Z

Merge pull request #3 from apache/trunk

Apache Kafka trunk pull

commit fbef9a8fb1411282fbadec46955691c3e7ba2578
Author: Rekha Joshi 
Date:   2016-06-04T23:58:02Z

Merge pull request #4 from apache/trunk

Apache Kafka trunk pull

commit feafe9714788896b00b0854eaf23c8ce5b8892ba
Author: Joshi 
Date:   2016-06-05T01:18:32Z

KAFKA-724; Send, receive buffer size set if not -1




> Allow automatic socket.send.buffer from operating system
> 
>
> Key: KAFKA-724
> URL: https://issues.apache.org/jira/browse/KAFKA-724
> Project: Kafka
>  Issue Type: Improvement
>Affects Versions: 0.8.2.0
>Reporter: Pablo Barrera
>Assignee: Rekha Joshi
>  Labels: newbie
>
> To do this, don't call to socket().setXXXBufferSize. This can be 
> controlled by the configuration parameter: if the value socket.send.buffer or 
> others are set to -1, don't call to socket().setXXXBufferSize



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-724) Allow automatic socket.send.buffer from operating system

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315694#comment-15315694
 ] 

ASF GitHub Bot commented on KAFKA-724:
--

Github user rekhajoshm closed the pull request at:

https://github.com/apache/kafka/pull/50


> Allow automatic socket.send.buffer from operating system
> 
>
> Key: KAFKA-724
> URL: https://issues.apache.org/jira/browse/KAFKA-724
> Project: Kafka
>  Issue Type: Improvement
>Affects Versions: 0.8.2.0
>Reporter: Pablo Barrera
>Assignee: Rekha Joshi
>  Labels: newbie
>
> To do this, don't call to socket().setXXXBufferSize. This can be 
> controlled by the configuration parameter: if the value socket.send.buffer or 
> others are set to -1, don't call to socket().setXXXBufferSize



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-724) Allow automatic socket.send.buffer from operating system

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14332482#comment-14332482
 ] 

ASF GitHub Bot commented on KAFKA-724:
--

GitHub user rekhajoshm opened a pull request:

https://github.com/apache/kafka/pull/50

KAFKA-724: auto socket buffer set

KAFKA-724: Allow automatic socket.send.buffer from operating system 
If socket.receive.buffer.bytes/socket.send.buffer.bytes set to non-zero/-1, 
the OS defaults work.Do not explicitly set buffers.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rekhajoshm/kafka KAFKA-724

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/50.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #50


commit 118fdc3cdba2711d5d4389609da1b1fe759c5cab
Author: Joshi rekhajo...@gmail.com
Date:   2015-02-23T02:01:58Z

KAFKA-724: auto socket buffer set




 Allow automatic socket.send.buffer from operating system
 

 Key: KAFKA-724
 URL: https://issues.apache.org/jira/browse/KAFKA-724
 Project: Kafka
  Issue Type: Improvement
Reporter: Pablo Barrera
  Labels: newbie

 To do this, don't call to socket().setXXXBufferSize. This can be 
 controlled by the configuration parameter: if the value socket.send.buffer or 
 others are set to -1, don't call to socket().setXXXBufferSize



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-724) Allow automatic socket.send.buffer from operating system

[Jay Kreps (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311008#comment-14311008
 ] 

Jay Kreps commented on KAFKA-724:
-

This is fixed on the old scala clients, but not on the new producer and 
consumer. It would be good to add the -1 means use OS default setting.

 Allow automatic socket.send.buffer from operating system
 

 Key: KAFKA-724
 URL: https://issues.apache.org/jira/browse/KAFKA-724
 Project: Kafka
  Issue Type: Improvement
Reporter: Pablo Barrera
  Labels: newbie

 To do this, don't call to socket().setXXXBufferSize. This can be 
 controlled by the configuration parameter: if the value socket.send.buffer or 
 others are set to -1, don't call to socket().setXXXBufferSize



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)