[jira] [Updated] (KAFKA-1746) System tests don't handle errors well
[ https://issues.apache.org/jira/browse/KAFKA-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1746: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch! Pushed to trunk > System tests don't handle errors well > - > > Key: KAFKA-1746 > URL: https://issues.apache.org/jira/browse/KAFKA-1746 > Project: Kafka > Issue Type: Bug > Components: system tests >Affects Versions: 0.8.1.1 >Reporter: Ewen Cheslack-Postava >Assignee: Ewen Cheslack-Postava > Fix For: 0.8.3 > > Attachments: KAFKA-1746.patch > > > The system test scripts don't handle errors well. A couple of key issues: > * Unexpected exceptions during tests are just ignored and the tests appear to > be successful in the reports. > * The scripts exit code is always 0, even if tests fail. > * Almost no subprocess calls are checked. In a lot of cases this is ok, and > sometimes it's not possible (e.g. after starting a long-running remote > process), but in some cases such as calls to DumpLogSegments, the tests can > miss that the tools is exiting with an exception and the test appears to be > successful even though no data was verified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1746) System tests don't handle errors well
[ https://issues.apache.org/jira/browse/KAFKA-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1746: - Fix Version/s: 0.8.3 > System tests don't handle errors well > - > > Key: KAFKA-1746 > URL: https://issues.apache.org/jira/browse/KAFKA-1746 > Project: Kafka > Issue Type: Bug > Components: system tests >Affects Versions: 0.8.1.1 >Reporter: Ewen Cheslack-Postava >Assignee: Ewen Cheslack-Postava > Fix For: 0.8.3 > > Attachments: KAFKA-1746.patch > > > The system test scripts don't handle errors well. A couple of key issues: > * Unexpected exceptions during tests are just ignored and the tests appear to > be successful in the reports. > * The scripts exit code is always 0, even if tests fail. > * Almost no subprocess calls are checked. In a lot of cases this is ok, and > sometimes it's not possible (e.g. after starting a long-running remote > process), but in some cases such as calls to DumpLogSegments, the tests can > miss that the tools is exiting with an exception and the test appears to be > successful even though no data was verified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1746) System tests don't handle errors well
[ https://issues.apache.org/jira/browse/KAFKA-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1746: - Component/s: system tests > System tests don't handle errors well > - > > Key: KAFKA-1746 > URL: https://issues.apache.org/jira/browse/KAFKA-1746 > Project: Kafka > Issue Type: Bug > Components: system tests >Affects Versions: 0.8.1.1 >Reporter: Ewen Cheslack-Postava >Assignee: Ewen Cheslack-Postava > Fix For: 0.8.3 > > Attachments: KAFKA-1746.patch > > > The system test scripts don't handle errors well. A couple of key issues: > * Unexpected exceptions during tests are just ignored and the tests appear to > be successful in the reports. > * The scripts exit code is always 0, even if tests fail. > * Almost no subprocess calls are checked. In a lot of cases this is ok, and > sometimes it's not possible (e.g. after starting a long-running remote > process), but in some cases such as calls to DumpLogSegments, the tests can > miss that the tools is exiting with an exception and the test appears to be > successful even though no data was verified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1746) System tests don't handle errors well
[ https://issues.apache.org/jira/browse/KAFKA-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1746: - Assignee: Ewen Cheslack-Postava Status: Patch Available (was: Open) > System tests don't handle errors well > - > > Key: KAFKA-1746 > URL: https://issues.apache.org/jira/browse/KAFKA-1746 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.1.1 >Reporter: Ewen Cheslack-Postava >Assignee: Ewen Cheslack-Postava > Attachments: KAFKA-1746.patch > > > The system test scripts don't handle errors well. A couple of key issues: > * Unexpected exceptions during tests are just ignored and the tests appear to > be successful in the reports. > * The scripts exit code is always 0, even if tests fail. > * Almost no subprocess calls are checked. In a lot of cases this is ok, and > sometimes it's not possible (e.g. after starting a long-running remote > process), but in some cases such as calls to DumpLogSegments, the tests can > miss that the tools is exiting with an exception and the test appears to be > successful even though no data was verified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-1746) System tests don't handle errors well
[ https://issues.apache.org/jira/browse/KAFKA-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1746: - Attachment: KAFKA-1746.patch > System tests don't handle errors well > - > > Key: KAFKA-1746 > URL: https://issues.apache.org/jira/browse/KAFKA-1746 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8.1.1 >Reporter: Ewen Cheslack-Postava > Attachments: KAFKA-1746.patch > > > The system test scripts don't handle errors well. A couple of key issues: > * Unexpected exceptions during tests are just ignored and the tests appear to > be successful in the reports. > * The scripts exit code is always 0, even if tests fail. > * Almost no subprocess calls are checked. In a lot of cases this is ok, and > sometimes it's not possible (e.g. after starting a long-running remote > process), but in some cases such as calls to DumpLogSegments, the tests can > miss that the tools is exiting with an exception and the test appears to be > successful even though no data was verified. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
