[jira] [Updated] (KAFKA-3100) Broker.createBroker should work if json is version > 2, but still compatible
[ https://issues.apache.org/jira/browse/KAFKA-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-3100: --- Resolution: Fixed Status: Resolved (was: Patch Available) Issue resolved by pull request 773 [https://github.com/apache/kafka/pull/773] > Broker.createBroker should work if json is version > 2, but still compatible > > > Key: KAFKA-3100 > URL: https://issues.apache.org/jira/browse/KAFKA-3100 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.9.0.0 >Reporter: Ismael Juma >Assignee: Ismael Juma > Fix For: 0.9.0.1 > > > Description from Jun: > In 0.9.0.0, the old consumer reads broker info directly from ZK and the code > throws an exception if the version in json is not 1 or 2. This old consumer > will break when we upgrade the broker json to version 3 in ZK in 0.9.1, which > will be an issue. We overlooked this issue in 0.9.0.0. The easiest fix is > probably not to check the version in ZkUtils.getBrokerInfo(). > This way, as long as we are only adding new fields in broker json, we can > preserve the compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3100) Broker.createBroker should work if json is version > 2, but still compatible
[ https://issues.apache.org/jira/browse/KAFKA-3100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3100: --- Reviewer: Jun Rao Status: Patch Available (was: Open) > Broker.createBroker should work if json is version > 2, but still compatible > > > Key: KAFKA-3100 > URL: https://issues.apache.org/jira/browse/KAFKA-3100 > Project: Kafka > Issue Type: Improvement > Components: core >Affects Versions: 0.9.0.0 >Reporter: Ismael Juma >Assignee: Ismael Juma > Fix For: 0.9.0.1 > > > Description from Jun: > In 0.9.0.0, the old consumer reads broker info directly from ZK and the code > throws an exception if the version in json is not 1 or 2. This old consumer > will break when we upgrade the broker json to version 3 in ZK in 0.9.1, which > will be an issue. We overlooked this issue in 0.9.0.0. The easiest fix is > probably not to check the version in ZkUtils.getBrokerInfo(). > This way, as long as we are only adding new fields in broker json, we can > preserve the compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
