[jira] [Updated] (KAFKA-3378) Client blocks forever if SocketChannel connects instantly
[ https://issues.apache.org/jira/browse/KAFKA-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-3378: Resolution: Fixed Status: Resolved (was: Patch Available) > Client blocks forever if SocketChannel connects instantly > - > > Key: KAFKA-3378 > URL: https://issues.apache.org/jira/browse/KAFKA-3378 > Project: Kafka > Issue Type: Bug > Components: clients >Affects Versions: 0.9.0.1 >Reporter: Larkin Lowrey >Assignee: Larkin Lowrey >Priority: Blocker > Fix For: 0.10.0.0 > > > Observed that some consumers were blocked in Fetcher.listOffset() when > starting many dozens of consumer threads at the same time. > Selector.connect(...) calls SocketChannel.connect() in non-blocking mode and > assumes that false is always returned and that the channel will be in the > Selector's readyKeys once the connection is ready for connect completion due > to the OP_CONNECT interest op. > When connect() returns true the channel is fully connected connected and will > not be included in readyKeys since only OP_CONNECT is set. > I implemented a fix which handles the case when connect(...) returns true and > verified that I no longer see stuck consumers. A git pull request will be > forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3378) Client blocks forever if SocketChannel connects instantly
[ https://issues.apache.org/jira/browse/KAFKA-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3378: --- Status: Patch Available (was: Reopened) > Client blocks forever if SocketChannel connects instantly > - > > Key: KAFKA-3378 > URL: https://issues.apache.org/jira/browse/KAFKA-3378 > Project: Kafka > Issue Type: Bug > Components: clients >Affects Versions: 0.9.0.1 >Reporter: Larkin Lowrey >Assignee: Larkin Lowrey >Priority: Blocker > Fix For: 0.10.0.0 > > > Observed that some consumers were blocked in Fetcher.listOffset() when > starting many dozens of consumer threads at the same time. > Selector.connect(...) calls SocketChannel.connect() in non-blocking mode and > assumes that false is always returned and that the channel will be in the > Selector's readyKeys once the connection is ready for connect completion due > to the OP_CONNECT interest op. > When connect() returns true the channel is fully connected connected and will > not be included in readyKeys since only OP_CONNECT is set. > I implemented a fix which handles the case when connect(...) returns true and > verified that I no longer see stuck consumers. A git pull request will be > forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3378) Client blocks forever if SocketChannel connects instantly
[ https://issues.apache.org/jira/browse/KAFKA-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-3378: Reviewer: Jun Rao > Client blocks forever if SocketChannel connects instantly > - > > Key: KAFKA-3378 > URL: https://issues.apache.org/jira/browse/KAFKA-3378 > Project: Kafka > Issue Type: Bug > Components: clients >Affects Versions: 0.9.0.1 >Reporter: Larkin Lowrey >Assignee: Larkin Lowrey >Priority: Blocker > Fix For: 0.10.0.0 > > > Observed that some consumers were blocked in Fetcher.listOffset() when > starting many dozens of consumer threads at the same time. > Selector.connect(...) calls SocketChannel.connect() in non-blocking mode and > assumes that false is always returned and that the channel will be in the > Selector's readyKeys once the connection is ready for connect completion due > to the OP_CONNECT interest op. > When connect() returns true the channel is fully connected connected and will > not be included in readyKeys since only OP_CONNECT is set. > I implemented a fix which handles the case when connect(...) returns true and > verified that I no longer see stuck consumers. A git pull request will be > forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3378) Client blocks forever if SocketChannel connects instantly
[ https://issues.apache.org/jira/browse/KAFKA-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-3378: Assignee: Larkin Lowrey > Client blocks forever if SocketChannel connects instantly > - > > Key: KAFKA-3378 > URL: https://issues.apache.org/jira/browse/KAFKA-3378 > Project: Kafka > Issue Type: Bug > Components: clients >Affects Versions: 0.9.0.1 >Reporter: Larkin Lowrey >Assignee: Larkin Lowrey >Priority: Blocker > Fix For: 0.10.0.0 > > > Observed that some consumers were blocked in Fetcher.listOffset() when > starting many dozens of consumer threads at the same time. > Selector.connect(...) calls SocketChannel.connect() in non-blocking mode and > assumes that false is always returned and that the channel will be in the > Selector's readyKeys once the connection is ready for connect completion due > to the OP_CONNECT interest op. > When connect() returns true the channel is fully connected connected and will > not be included in readyKeys since only OP_CONNECT is set. > I implemented a fix which handles the case when connect(...) returns true and > verified that I no longer see stuck consumers. A git pull request will be > forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3378) Client blocks forever if SocketChannel connects instantly
[ https://issues.apache.org/jira/browse/KAFKA-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-3378: Status: Patch Available (was: Open) > Client blocks forever if SocketChannel connects instantly > - > > Key: KAFKA-3378 > URL: https://issues.apache.org/jira/browse/KAFKA-3378 > Project: Kafka > Issue Type: Bug > Components: clients >Affects Versions: 0.9.0.1 >Reporter: Larkin Lowrey >Assignee: Larkin Lowrey >Priority: Blocker > Fix For: 0.10.0.0 > > > Observed that some consumers were blocked in Fetcher.listOffset() when > starting many dozens of consumer threads at the same time. > Selector.connect(...) calls SocketChannel.connect() in non-blocking mode and > assumes that false is always returned and that the channel will be in the > Selector's readyKeys once the connection is ready for connect completion due > to the OP_CONNECT interest op. > When connect() returns true the channel is fully connected connected and will > not be included in readyKeys since only OP_CONNECT is set. > I implemented a fix which handles the case when connect(...) returns true and > verified that I no longer see stuck consumers. A git pull request will be > forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3378) Client blocks forever if SocketChannel connects instantly
[ https://issues.apache.org/jira/browse/KAFKA-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-3378: Resolution: Fixed Status: Resolved (was: Patch Available) Issue resolved by pull request 1094 [https://github.com/apache/kafka/pull/1094] > Client blocks forever if SocketChannel connects instantly > - > > Key: KAFKA-3378 > URL: https://issues.apache.org/jira/browse/KAFKA-3378 > Project: Kafka > Issue Type: Bug > Components: clients >Affects Versions: 0.9.0.1 >Reporter: Larkin Lowrey >Assignee: Larkin Lowrey >Priority: Blocker > Fix For: 0.10.0.0 > > > Observed that some consumers were blocked in Fetcher.listOffset() when > starting many dozens of consumer threads at the same time. > Selector.connect(...) calls SocketChannel.connect() in non-blocking mode and > assumes that false is always returned and that the channel will be in the > Selector's readyKeys once the connection is ready for connect completion due > to the OP_CONNECT interest op. > When connect() returns true the channel is fully connected connected and will > not be included in readyKeys since only OP_CONNECT is set. > I implemented a fix which handles the case when connect(...) returns true and > verified that I no longer see stuck consumers. A git pull request will be > forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3378) Client blocks forever if SocketChannel connects instantly
[ https://issues.apache.org/jira/browse/KAFKA-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-3378: --- Priority: Blocker (was: Critical) Thanks for reporting this. Marking this as a blocker for 0.10.0 since it can have a big impact to the client. > Client blocks forever if SocketChannel connects instantly > - > > Key: KAFKA-3378 > URL: https://issues.apache.org/jira/browse/KAFKA-3378 > Project: Kafka > Issue Type: Bug > Components: clients >Affects Versions: 0.9.0.1 >Reporter: Larkin Lowrey >Priority: Blocker > Fix For: 0.10.0.0 > > > Observed that some consumers were blocked in Fetcher.listOffset() when > starting many dozens of consumer threads at the same time. > Selector.connect(...) calls SocketChannel.connect() in non-blocking mode and > assumes that false is always returned and that the channel will be in the > Selector's readyKeys once the connection is ready for connect completion due > to the OP_CONNECT interest op. > When connect() returns true the channel is fully connected connected and will > not be included in readyKeys since only OP_CONNECT is set. > I implemented a fix which handles the case when connect(...) returns true and > verified that I no longer see stuck consumers. A git pull request will be > forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3378) Client blocks forever if SocketChannel connects instantly
[ https://issues.apache.org/jira/browse/KAFKA-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3378: --- Priority: Critical (was: Major) > Client blocks forever if SocketChannel connects instantly > - > > Key: KAFKA-3378 > URL: https://issues.apache.org/jira/browse/KAFKA-3378 > Project: Kafka > Issue Type: Bug > Components: clients >Affects Versions: 0.9.0.1 >Reporter: Larkin Lowrey >Priority: Critical > Fix For: 0.10.0.0 > > > Observed that some consumers were blocked in Fetcher.listOffset() when > starting many dozens of consumer threads at the same time. > Selector.connect(...) calls SocketChannel.connect() in non-blocking mode and > assumes that false is always returned and that the channel will be in the > Selector's readyKeys once the connection is ready for connect completion due > to the OP_CONNECT interest op. > When connect() returns true the channel is fully connected connected and will > not be included in readyKeys since only OP_CONNECT is set. > I implemented a fix which handles the case when connect(...) returns true and > verified that I no longer see stuck consumers. A git pull request will be > forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (KAFKA-3378) Client blocks forever if SocketChannel connects instantly
[ https://issues.apache.org/jira/browse/KAFKA-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-3378: --- Fix Version/s: 0.10.0.0 > Client blocks forever if SocketChannel connects instantly > - > > Key: KAFKA-3378 > URL: https://issues.apache.org/jira/browse/KAFKA-3378 > Project: Kafka > Issue Type: Bug > Components: clients >Affects Versions: 0.9.0.1 >Reporter: Larkin Lowrey >Priority: Critical > Fix For: 0.10.0.0 > > > Observed that some consumers were blocked in Fetcher.listOffset() when > starting many dozens of consumer threads at the same time. > Selector.connect(...) calls SocketChannel.connect() in non-blocking mode and > assumes that false is always returned and that the channel will be in the > Selector's readyKeys once the connection is ready for connect completion due > to the OP_CONNECT interest op. > When connect() returns true the channel is fully connected connected and will > not be included in readyKeys since only OP_CONNECT is set. > I implemented a fix which handles the case when connect(...) returns true and > verified that I no longer see stuck consumers. A git pull request will be > forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
