Re: [VOTE] KIP-848: The Next Generation of the Consumer Rebalance Protocol
Hi all, I am pleased to announce that the KIP is accepted with 4 binding votes from Guozhang, Luke, Jun and Jason, and 1 non-binding vote from Magnus. Thank you all for the great discussion and feedback! Best, David On Fri, Oct 28, 2022 at 6:33 PM Jason Gustafson wrote: > > +1 Thanks for all the hard work. > > -Jason > > On Tue, Oct 25, 2022 at 7:17 AM David Jacot > wrote: > > > Hi all, > > > > The vote has been open for a while. I plan to close it on Friday if > > there are no further comments in the discussion thread. > > > > Best, > > David > > > > On Wed, Oct 19, 2022 at 6:10 PM Jun Rao wrote: > > > > > > Hi, David, > > > > > > Thanks for the KIP. +1 > > > > > > Jun > > > > > > On Wed, Oct 19, 2022 at 2:21 AM Magnus Edenhill > > wrote: > > > > > > > Great work on the KIP, David. > > > > > > > > +1 (nonbinding) > > > > > > > > Den fre 14 okt. 2022 kl 11:50 skrev Luke Chen : > > > > > > > > > Hi David, > > > > > > > > > > I made a final pass and LGTM now. > > > > > +1 from me. > > > > > > > > > > Luke > > > > > > > > > > On Wed, Oct 5, 2022 at 12:32 AM Guozhang Wang > > > > wrote: > > > > > > > > > > > Hello David, > > > > > > > > > > > > I've made my final pass on the doc and I think it looks good now. > > +1. > > > > > > > > > > > > > > > > > > Guozhang > > > > > > > > > > > > On Wed, Sep 14, 2022 at 1:37 PM Guozhang Wang > > > > > wrote: > > > > > > > > > > > > > Thanks David, > > > > > > > > > > > > > > There are a few minor comments pending in the discussion thread, > > and > > > > > one > > > > > > > is about whether we should merge PreparePartitionAssignment with > > HB. > > > > > But > > > > > > I > > > > > > > think the KIP itself is in pretty good shape now. Thanks! > > > > > > > > > > > > > > > > > > > > > Guozhang > > > > > > > > > > > > > > On Fri, Sep 9, 2022 at 1:32 AM David Jacot > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > >> Hi all, > > > > > > >> > > > > > > >> Thank you all for the very positive discussion about KIP-848. It > > > > looks > > > > > > >> like folks are very positive about it overall. > > > > > > >> > > > > > > >> I would like to start a vote on KIP-848, which introduces a > > brand > > > > new > > > > > > >> consumer rebalance protocol. > > > > > > >> > > > > > > >> The KIP is here: https://cwiki.apache.org/confluence/x/HhD1D. > > > > > > >> > > > > > > >> Best, > > > > > > >> David > > > > > > >> > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > -- Guozhang > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > -- Guozhang > > > > > > > > > > > > > > > > >
Re: [VOTE] KIP-848: The Next Generation of the Consumer Rebalance Protocol
+1 Thanks for all the hard work. -Jason On Tue, Oct 25, 2022 at 7:17 AM David Jacot wrote: > Hi all, > > The vote has been open for a while. I plan to close it on Friday if > there are no further comments in the discussion thread. > > Best, > David > > On Wed, Oct 19, 2022 at 6:10 PM Jun Rao wrote: > > > > Hi, David, > > > > Thanks for the KIP. +1 > > > > Jun > > > > On Wed, Oct 19, 2022 at 2:21 AM Magnus Edenhill > wrote: > > > > > Great work on the KIP, David. > > > > > > +1 (nonbinding) > > > > > > Den fre 14 okt. 2022 kl 11:50 skrev Luke Chen : > > > > > > > Hi David, > > > > > > > > I made a final pass and LGTM now. > > > > +1 from me. > > > > > > > > Luke > > > > > > > > On Wed, Oct 5, 2022 at 12:32 AM Guozhang Wang > > > wrote: > > > > > > > > > Hello David, > > > > > > > > > > I've made my final pass on the doc and I think it looks good now. > +1. > > > > > > > > > > > > > > > Guozhang > > > > > > > > > > On Wed, Sep 14, 2022 at 1:37 PM Guozhang Wang > > > > wrote: > > > > > > > > > > > Thanks David, > > > > > > > > > > > > There are a few minor comments pending in the discussion thread, > and > > > > one > > > > > > is about whether we should merge PreparePartitionAssignment with > HB. > > > > But > > > > > I > > > > > > think the KIP itself is in pretty good shape now. Thanks! > > > > > > > > > > > > > > > > > > Guozhang > > > > > > > > > > > > On Fri, Sep 9, 2022 at 1:32 AM David Jacot > > > > > > > > > > > > > wrote: > > > > > > > > > > > >> Hi all, > > > > > >> > > > > > >> Thank you all for the very positive discussion about KIP-848. It > > > looks > > > > > >> like folks are very positive about it overall. > > > > > >> > > > > > >> I would like to start a vote on KIP-848, which introduces a > brand > > > new > > > > > >> consumer rebalance protocol. > > > > > >> > > > > > >> The KIP is here: https://cwiki.apache.org/confluence/x/HhD1D. > > > > > >> > > > > > >> Best, > > > > > >> David > > > > > >> > > > > > > > > > > > > > > > > > > -- > > > > > > -- Guozhang > > > > > > > > > > > > > > > > > > > > > -- > > > > > -- Guozhang > > > > > > > > > > > > >
Re: [VOTE] KIP-848: The Next Generation of the Consumer Rebalance Protocol
Hi all, The vote has been open for a while. I plan to close it on Friday if there are no further comments in the discussion thread. Best, David On Wed, Oct 19, 2022 at 6:10 PM Jun Rao wrote: > > Hi, David, > > Thanks for the KIP. +1 > > Jun > > On Wed, Oct 19, 2022 at 2:21 AM Magnus Edenhill wrote: > > > Great work on the KIP, David. > > > > +1 (nonbinding) > > > > Den fre 14 okt. 2022 kl 11:50 skrev Luke Chen : > > > > > Hi David, > > > > > > I made a final pass and LGTM now. > > > +1 from me. > > > > > > Luke > > > > > > On Wed, Oct 5, 2022 at 12:32 AM Guozhang Wang > > wrote: > > > > > > > Hello David, > > > > > > > > I've made my final pass on the doc and I think it looks good now. +1. > > > > > > > > > > > > Guozhang > > > > > > > > On Wed, Sep 14, 2022 at 1:37 PM Guozhang Wang > > > wrote: > > > > > > > > > Thanks David, > > > > > > > > > > There are a few minor comments pending in the discussion thread, and > > > one > > > > > is about whether we should merge PreparePartitionAssignment with HB. > > > But > > > > I > > > > > think the KIP itself is in pretty good shape now. Thanks! > > > > > > > > > > > > > > > Guozhang > > > > > > > > > > On Fri, Sep 9, 2022 at 1:32 AM David Jacot > > > > > > > > > > wrote: > > > > > > > > > >> Hi all, > > > > >> > > > > >> Thank you all for the very positive discussion about KIP-848. It > > looks > > > > >> like folks are very positive about it overall. > > > > >> > > > > >> I would like to start a vote on KIP-848, which introduces a brand > > new > > > > >> consumer rebalance protocol. > > > > >> > > > > >> The KIP is here: https://cwiki.apache.org/confluence/x/HhD1D. > > > > >> > > > > >> Best, > > > > >> David > > > > >> > > > > > > > > > > > > > > > -- > > > > > -- Guozhang > > > > > > > > > > > > > > > > > -- > > > > -- Guozhang > > > > > > > > >
Re: [VOTE] KIP-848: The Next Generation of the Consumer Rebalance Protocol
Hi, David, Thanks for the KIP. +1 Jun On Wed, Oct 19, 2022 at 2:21 AM Magnus Edenhill wrote: > Great work on the KIP, David. > > +1 (nonbinding) > > Den fre 14 okt. 2022 kl 11:50 skrev Luke Chen : > > > Hi David, > > > > I made a final pass and LGTM now. > > +1 from me. > > > > Luke > > > > On Wed, Oct 5, 2022 at 12:32 AM Guozhang Wang > wrote: > > > > > Hello David, > > > > > > I've made my final pass on the doc and I think it looks good now. +1. > > > > > > > > > Guozhang > > > > > > On Wed, Sep 14, 2022 at 1:37 PM Guozhang Wang > > wrote: > > > > > > > Thanks David, > > > > > > > > There are a few minor comments pending in the discussion thread, and > > one > > > > is about whether we should merge PreparePartitionAssignment with HB. > > But > > > I > > > > think the KIP itself is in pretty good shape now. Thanks! > > > > > > > > > > > > Guozhang > > > > > > > > On Fri, Sep 9, 2022 at 1:32 AM David Jacot > > > > > > > wrote: > > > > > > > >> Hi all, > > > >> > > > >> Thank you all for the very positive discussion about KIP-848. It > looks > > > >> like folks are very positive about it overall. > > > >> > > > >> I would like to start a vote on KIP-848, which introduces a brand > new > > > >> consumer rebalance protocol. > > > >> > > > >> The KIP is here: https://cwiki.apache.org/confluence/x/HhD1D. > > > >> > > > >> Best, > > > >> David > > > >> > > > > > > > > > > > > -- > > > > -- Guozhang > > > > > > > > > > > > > -- > > > -- Guozhang > > > > > >
Re: [VOTE] KIP-848: The Next Generation of the Consumer Rebalance Protocol
Great work on the KIP, David. +1 (nonbinding) Den fre 14 okt. 2022 kl 11:50 skrev Luke Chen : > Hi David, > > I made a final pass and LGTM now. > +1 from me. > > Luke > > On Wed, Oct 5, 2022 at 12:32 AM Guozhang Wang wrote: > > > Hello David, > > > > I've made my final pass on the doc and I think it looks good now. +1. > > > > > > Guozhang > > > > On Wed, Sep 14, 2022 at 1:37 PM Guozhang Wang > wrote: > > > > > Thanks David, > > > > > > There are a few minor comments pending in the discussion thread, and > one > > > is about whether we should merge PreparePartitionAssignment with HB. > But > > I > > > think the KIP itself is in pretty good shape now. Thanks! > > > > > > > > > Guozhang > > > > > > On Fri, Sep 9, 2022 at 1:32 AM David Jacot > > > > wrote: > > > > > >> Hi all, > > >> > > >> Thank you all for the very positive discussion about KIP-848. It looks > > >> like folks are very positive about it overall. > > >> > > >> I would like to start a vote on KIP-848, which introduces a brand new > > >> consumer rebalance protocol. > > >> > > >> The KIP is here: https://cwiki.apache.org/confluence/x/HhD1D. > > >> > > >> Best, > > >> David > > >> > > > > > > > > > -- > > > -- Guozhang > > > > > > > > > -- > > -- Guozhang > > >
Re: [VOTE] KIP-848: The Next Generation of the Consumer Rebalance Protocol
Hi David, I made a final pass and LGTM now. +1 from me. Luke On Wed, Oct 5, 2022 at 12:32 AM Guozhang Wang wrote: > Hello David, > > I've made my final pass on the doc and I think it looks good now. +1. > > > Guozhang > > On Wed, Sep 14, 2022 at 1:37 PM Guozhang Wang wrote: > > > Thanks David, > > > > There are a few minor comments pending in the discussion thread, and one > > is about whether we should merge PreparePartitionAssignment with HB. But > I > > think the KIP itself is in pretty good shape now. Thanks! > > > > > > Guozhang > > > > On Fri, Sep 9, 2022 at 1:32 AM David Jacot > > wrote: > > > >> Hi all, > >> > >> Thank you all for the very positive discussion about KIP-848. It looks > >> like folks are very positive about it overall. > >> > >> I would like to start a vote on KIP-848, which introduces a brand new > >> consumer rebalance protocol. > >> > >> The KIP is here: https://cwiki.apache.org/confluence/x/HhD1D. > >> > >> Best, > >> David > >> > > > > > > -- > > -- Guozhang > > > > > -- > -- Guozhang >
Re: [VOTE] KIP-848: The Next Generation of the Consumer Rebalance Protocol
Hello David, I've made my final pass on the doc and I think it looks good now. +1. Guozhang On Wed, Sep 14, 2022 at 1:37 PM Guozhang Wang wrote: > Thanks David, > > There are a few minor comments pending in the discussion thread, and one > is about whether we should merge PreparePartitionAssignment with HB. But I > think the KIP itself is in pretty good shape now. Thanks! > > > Guozhang > > On Fri, Sep 9, 2022 at 1:32 AM David Jacot > wrote: > >> Hi all, >> >> Thank you all for the very positive discussion about KIP-848. It looks >> like folks are very positive about it overall. >> >> I would like to start a vote on KIP-848, which introduces a brand new >> consumer rebalance protocol. >> >> The KIP is here: https://cwiki.apache.org/confluence/x/HhD1D. >> >> Best, >> David >> > > > -- > -- Guozhang > -- -- Guozhang
Re: [VOTE] KIP-848: The Next Generation of the Consumer Rebalance Protocol
Thanks David, There are a few minor comments pending in the discussion thread, and one is about whether we should merge PreparePartitionAssignment with HB. But I think the KIP itself is in pretty good shape now. Thanks! Guozhang On Fri, Sep 9, 2022 at 1:32 AM David Jacot wrote: > Hi all, > > Thank you all for the very positive discussion about KIP-848. It looks > like folks are very positive about it overall. > > I would like to start a vote on KIP-848, which introduces a brand new > consumer rebalance protocol. > > The KIP is here: https://cwiki.apache.org/confluence/x/HhD1D. > > Best, > David > -- -- Guozhang
Re:[VOTE] KIP-848: The Next Generation of the Consumer Rebalance Protocol
+1 (non-binding) Really looking forward for the discussion on how other group types (especially connect) will support this new protocol. From: dev@kafka.apache.org At: 09/09/22 04:32:46 UTC-4:00To: dev@kafka.apache.org Subject: [VOTE] KIP-848: The Next Generation of the Consumer Rebalance Protocol Hi all, Thank you all for the very positive discussion about KIP-848. It looks like folks are very positive about it overall. I would like to start a vote on KIP-848, which introduces a brand new consumer rebalance protocol. The KIP is here: https://cwiki.apache.org/confluence/x/HhD1D. Best, David