Re: KIP-162: Enable topic deletion by default

[Bill Bejeck]

+1

On Wed, Jul 19, 2017 at 1:35 PM, Jay Kreps  wrote:

> +1
>
> On Sat, May 27, 2017 at 11:04 AM, Gwen Shapira  wrote:
>
> > Thanks Vahid,
> >
> > Do you mind if we leave the command-line out of scope for this?
> >
> > I can see why adding confirmations, options to bypass confirmations, etc
> > would be an improvement. However, I've seen no complaints about the
> current
> > behavior of the command-line and the KIP doesn't change it at all. So I'd
> > rather address things separately.
> >
> > Gwen
> >
> > On Fri, May 26, 2017 at 8:10 PM Vahid S Hashemian <
> > vahidhashem...@us.ibm.com>
> > wrote:
> >
> > > Gwen, thanks for the KIP.
> > > It looks good to me.
> > >
> > > Just a minor suggestion: It would be great if the command asks for a
> > > confirmation (y/n) before deleting the topic (similar to how removing
> > ACLs
> > > works).
> > >
> > > Thanks.
> > > --Vahid
> > >
> > >
> > >
> > > From:   Gwen Shapira 
> > > To: "dev@kafka.apache.org" , Users
> > > 
> > > Date:   05/26/2017 07:04 AM
> > > Subject:KIP-162: Enable topic deletion by default
> > >
> > >
> > >
> > > Hi Kafka developers, users and friends,
> > >
> > > I've added a KIP to improve our out-of-the-box usability a bit:
> > > KIP-162: Enable topic deletion by default:
> > >
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> > 162+-+Enable+topic+deletion+by+default
> > >
> > >
> > > Pretty simple :) Discussion and feedback are welcome.
> > >
> > > Gwen
> > >
> > >
> > >
> > >
> > >
> >
>

Re: KIP-162: Enable topic deletion by default

[Jay Kreps]

+1

On Sat, May 27, 2017 at 11:04 AM, Gwen Shapira  wrote:

> Thanks Vahid,
>
> Do you mind if we leave the command-line out of scope for this?
>
> I can see why adding confirmations, options to bypass confirmations, etc
> would be an improvement. However, I've seen no complaints about the current
> behavior of the command-line and the KIP doesn't change it at all. So I'd
> rather address things separately.
>
> Gwen
>
> On Fri, May 26, 2017 at 8:10 PM Vahid S Hashemian <
> vahidhashem...@us.ibm.com>
> wrote:
>
> > Gwen, thanks for the KIP.
> > It looks good to me.
> >
> > Just a minor suggestion: It would be great if the command asks for a
> > confirmation (y/n) before deleting the topic (similar to how removing
> ACLs
> > works).
> >
> > Thanks.
> > --Vahid
> >
> >
> >
> > From:   Gwen Shapira 
> > To: "dev@kafka.apache.org" , Users
> > 
> > Date:   05/26/2017 07:04 AM
> > Subject:KIP-162: Enable topic deletion by default
> >
> >
> >
> > Hi Kafka developers, users and friends,
> >
> > I've added a KIP to improve our out-of-the-box usability a bit:
> > KIP-162: Enable topic deletion by default:
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 162+-+Enable+topic+deletion+by+default
> >
> >
> > Pretty simple :) Discussion and feedback are welcome.
> >
> > Gwen
> >
> >
> >
> >
> >
>

Re: KIP-162: Enable topic deletion by default

[Damian Guy]

+1

On Wed, 31 May 2017 at 13:36 Jim Jagielski <j...@jagunet.com> wrote:

> +1
> > On May 27, 2017, at 9:27 PM, Vahid S Hashemian <
> vahidhashem...@us.ibm.com> wrote:
> >
> > Sure, that sounds good.
> >
> > I suggested that to keep command line behavior consistent.
> > Plus, removal of ACL access is something that can be easily undone, but
> > topic deletion is not reversible.
> > So, perhaps a new follow-up JIRA to this KIP to add the confirmation for
> > topic deletion.
> >
> > Thanks.
> > --Vahid
> >
> >
> >
> > From:   Gwen Shapira <g...@confluent.io>
> > To:     dev@kafka.apache.org, us...@kafka.apache.org
> > Date:   05/27/2017 11:04 AM
> > Subject:Re: KIP-162: Enable topic deletion by default
> >
> >
> >
> > Thanks Vahid,
> >
> > Do you mind if we leave the command-line out of scope for this?
> >
> > I can see why adding confirmations, options to bypass confirmations, etc
> > would be an improvement. However, I've seen no complaints about the
> > current
> > behavior of the command-line and the KIP doesn't change it at all. So I'd
> > rather address things separately.
> >
> > Gwen
> >
> > On Fri, May 26, 2017 at 8:10 PM Vahid S Hashemian
> > <vahidhashem...@us.ibm.com>
> > wrote:
> >
> >> Gwen, thanks for the KIP.
> >> It looks good to me.
> >>
> >> Just a minor suggestion: It would be great if the command asks for a
> >> confirmation (y/n) before deleting the topic (similar to how removing
> > ACLs
> >> works).
> >>
> >> Thanks.
> >> --Vahid
> >>
> >>
> >>
> >> From:   Gwen Shapira <g...@confluent.io>
> >> To: "dev@kafka.apache.org" <dev@kafka.apache.org>, Users
> >> <us...@kafka.apache.org>
> >> Date:   05/26/2017 07:04 AM
> >> Subject:KIP-162: Enable topic deletion by default
> >>
> >>
> >>
> >> Hi Kafka developers, users and friends,
> >>
> >> I've added a KIP to improve our out-of-the-box usability a bit:
> >> KIP-162: Enable topic deletion by default:
> >>
> >>
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+Enable+topic+deletion+by+default
> >
> >>
> >>
> >> Pretty simple :) Discussion and feedback are welcome.
> >>
> >> Gwen
> >>
> >>
> >>
> >>
> >>
> >
> >
> >
> >
>
>

Re: KIP-162: Enable topic deletion by default

[Jim Jagielski]

+1
> On May 27, 2017, at 9:27 PM, Vahid S Hashemian <vahidhashem...@us.ibm.com> 
> wrote:
> 
> Sure, that sounds good.
> 
> I suggested that to keep command line behavior consistent.
> Plus, removal of ACL access is something that can be easily undone, but 
> topic deletion is not reversible.
> So, perhaps a new follow-up JIRA to this KIP to add the confirmation for 
> topic deletion.
> 
> Thanks.
> --Vahid
> 
> 
> 
> From:   Gwen Shapira <g...@confluent.io>
> To: dev@kafka.apache.org, us...@kafka.apache.org
> Date:   05/27/2017 11:04 AM
> Subject:Re: KIP-162: Enable topic deletion by default
> 
> 
> 
> Thanks Vahid,
> 
> Do you mind if we leave the command-line out of scope for this?
> 
> I can see why adding confirmations, options to bypass confirmations, etc
> would be an improvement. However, I've seen no complaints about the 
> current
> behavior of the command-line and the KIP doesn't change it at all. So I'd
> rather address things separately.
> 
> Gwen
> 
> On Fri, May 26, 2017 at 8:10 PM Vahid S Hashemian 
> <vahidhashem...@us.ibm.com>
> wrote:
> 
>> Gwen, thanks for the KIP.
>> It looks good to me.
>> 
>> Just a minor suggestion: It would be great if the command asks for a
>> confirmation (y/n) before deleting the topic (similar to how removing 
> ACLs
>> works).
>> 
>> Thanks.
>> --Vahid
>> 
>> 
>> 
>> From:   Gwen Shapira <g...@confluent.io>
>> To: "dev@kafka.apache.org" <dev@kafka.apache.org>, Users
>> <us...@kafka.apache.org>
>> Date:   05/26/2017 07:04 AM
>> Subject:KIP-162: Enable topic deletion by default
>> 
>> 
>> 
>> Hi Kafka developers, users and friends,
>> 
>> I've added a KIP to improve our out-of-the-box usability a bit:
>> KIP-162: Enable topic deletion by default:
>> 
>> 
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+Enable+topic+deletion+by+default
> 
>> 
>> 
>> Pretty simple :) Discussion and feedback are welcome.
>> 
>> Gwen
>> 
>> 
>> 
>> 
>> 
> 
> 
> 
> 

Re: KIP-162: Enable topic deletion by default

[Sandeep Nemuri]

+1

On Sun, May 28, 2017 at 6:57 AM, Vahid S Hashemian <
vahidhashem...@us.ibm.com> wrote:

> Sure, that sounds good.
>
> I suggested that to keep command line behavior consistent.
> Plus, removal of ACL access is something that can be easily undone, but
> topic deletion is not reversible.
> So, perhaps a new follow-up JIRA to this KIP to add the confirmation for
> topic deletion.
>
> Thanks.
> --Vahid
>
>
>
> From:   Gwen Shapira <g...@confluent.io>
> To: dev@kafka.apache.org, us...@kafka.apache.org
> Date:   05/27/2017 11:04 AM
> Subject:Re: KIP-162: Enable topic deletion by default
>
>
>
> Thanks Vahid,
>
> Do you mind if we leave the command-line out of scope for this?
>
> I can see why adding confirmations, options to bypass confirmations, etc
> would be an improvement. However, I've seen no complaints about the
> current
> behavior of the command-line and the KIP doesn't change it at all. So I'd
> rather address things separately.
>
> Gwen
>
> On Fri, May 26, 2017 at 8:10 PM Vahid S Hashemian
> <vahidhashem...@us.ibm.com>
> wrote:
>
> > Gwen, thanks for the KIP.
> > It looks good to me.
> >
> > Just a minor suggestion: It would be great if the command asks for a
> > confirmation (y/n) before deleting the topic (similar to how removing
> ACLs
> > works).
> >
> > Thanks.
> > --Vahid
> >
> >
> >
> > From:   Gwen Shapira <g...@confluent.io>
> > To: "dev@kafka.apache.org" <dev@kafka.apache.org>, Users
> > <us...@kafka.apache.org>
> > Date:   05/26/2017 07:04 AM
> > Subject:KIP-162: Enable topic deletion by default
> >
> >
> >
> > Hi Kafka developers, users and friends,
> >
> > I've added a KIP to improve our out-of-the-box usability a bit:
> > KIP-162: Enable topic deletion by default:
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 162+-+Enable+topic+deletion+by+default
>
> >
> >
> > Pretty simple :) Discussion and feedback are welcome.
> >
> > Gwen
> >
> >
> >
> >
> >
>
>
>
>
>


-- 
*  Regards*
*  Sandeep Nemuri*

Re: KIP-162: Enable topic deletion by default

[Vahid S Hashemian]

Sure, that sounds good.

I suggested that to keep command line behavior consistent.
Plus, removal of ACL access is something that can be easily undone, but 
topic deletion is not reversible.
So, perhaps a new follow-up JIRA to this KIP to add the confirmation for 
topic deletion.

Thanks.
--Vahid



From:   Gwen Shapira <g...@confluent.io>
To: dev@kafka.apache.org, us...@kafka.apache.org
Date:   05/27/2017 11:04 AM
Subject:        Re: KIP-162: Enable topic deletion by default



Thanks Vahid,

Do you mind if we leave the command-line out of scope for this?

I can see why adding confirmations, options to bypass confirmations, etc
would be an improvement. However, I've seen no complaints about the 
current
behavior of the command-line and the KIP doesn't change it at all. So I'd
rather address things separately.

Gwen

On Fri, May 26, 2017 at 8:10 PM Vahid S Hashemian 
<vahidhashem...@us.ibm.com>
wrote:

> Gwen, thanks for the KIP.
> It looks good to me.
>
> Just a minor suggestion: It would be great if the command asks for a
> confirmation (y/n) before deleting the topic (similar to how removing 
ACLs
> works).
>
> Thanks.
> --Vahid
>
>
>
> From:   Gwen Shapira <g...@confluent.io>
> To: "dev@kafka.apache.org" <dev@kafka.apache.org>, Users
> <us...@kafka.apache.org>
> Date:   05/26/2017 07:04 AM
> Subject:KIP-162: Enable topic deletion by default
>
>
>
> Hi Kafka developers, users and friends,
>
> I've added a KIP to improve our out-of-the-box usability a bit:
> KIP-162: Enable topic deletion by default:
>
> 
https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+Enable+topic+deletion+by+default

>
>
> Pretty simple :) Discussion and feedback are welcome.
>
> Gwen
>
>
>
>
>

Re: KIP-162: Enable topic deletion by default

[Gwen Shapira]

Agreed and updated the KIP accordingly. Thank you!

On Sat, May 27, 2017 at 1:25 AM Guozhang Wang  wrote:

> I'd say just remove those two lines.
>
> On Fri, May 26, 2017 at 7:55 AM, Gwen Shapira  wrote:
>
> > This was a discussion, not a vote (sorry for mangling the title), but
> > thanks for all the +1 anyway.
> >
> > Regarding Ismael's feedback:
> > The current server.properties includes the following:
> > # Switch to enable topic deletion or not, default value is false
> > #delete.topic.enable=true
> >
> > We can't leave it as is, obviously - since the KIP invalidates the
> > comment.  Lets just remove those two lines?
> >
> > Note that all our proposed changes may break few community puppet/docker
> > scripts that use these lines for "sed" that enables topic deletion.
> >
> > Gwen
> >
> > On Fri, May 26, 2017 at 5:41 PM Tom Crayford 
> wrote:
> >
> > > +1 (non-binding)
> > >
> > > On Fri, May 26, 2017 at 3:38 PM, Damian Guy 
> > wrote:
> > >
> > > > +1
> > > > Also agree with what Ismael said.
> > > >
> > > > On Fri, 26 May 2017 at 15:26 Ismael Juma  wrote:
> > > >
> > > > > Thanks for the KIP, sounds good to me. One comment: not sure we
> need
> > to
> > > > add
> > > > > the config to server.properties. Do we expect people to change this
> > > > > default?
> > > > >
> > > > > On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira 
> > > wrote:
> > > > >
> > > > > > Hi Kafka developers, users and friends,
> > > > > >
> > > > > > I've added a KIP to improve our out-of-the-box usability a bit:
> > > > > > KIP-162: Enable topic deletion by default:
> > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+
> > > > > > Enable+topic+deletion+by+default
> > > > > >
> > > > > > Pretty simple :) Discussion and feedback are welcome.
> > > > > >
> > > > > > Gwen
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
>
> --
> -- Guozhang
>

Re: KIP-162: Enable topic deletion by default

[Gwen Shapira]

Thanks Vahid,

Do you mind if we leave the command-line out of scope for this?

I can see why adding confirmations, options to bypass confirmations, etc
would be an improvement. However, I've seen no complaints about the current
behavior of the command-line and the KIP doesn't change it at all. So I'd
rather address things separately.

Gwen

On Fri, May 26, 2017 at 8:10 PM Vahid S Hashemian 
wrote:

> Gwen, thanks for the KIP.
> It looks good to me.
>
> Just a minor suggestion: It would be great if the command asks for a
> confirmation (y/n) before deleting the topic (similar to how removing ACLs
> works).
>
> Thanks.
> --Vahid
>
>
>
> From:   Gwen Shapira 
> To: "dev@kafka.apache.org" , Users
> 
> Date:   05/26/2017 07:04 AM
> Subject:KIP-162: Enable topic deletion by default
>
>
>
> Hi Kafka developers, users and friends,
>
> I've added a KIP to improve our out-of-the-box usability a bit:
> KIP-162: Enable topic deletion by default:
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+Enable+topic+deletion+by+default
>
>
> Pretty simple :) Discussion and feedback are welcome.
>
> Gwen
>
>
>
>
>

Re: KIP-162: Enable topic deletion by default

[Gwen Shapira]

This KIP only changes a configuration default, so the two changes seem
independent to me.

And since both changes will be included in the release following 0.11
(October) and no sooner, I don't know if the order matters that much.

Am I missing anything regarding KAFKA-4893 that means KIP-162 isn't as
simple as I assume?

Gwen

On Sat, May 27, 2017 at 4:25 AM Onur Karaman 
wrote:

> Would it make sense to resolve KAFKA-4893 before enabling it by default, as
> fixing the ticket would likely involve changing the log directory
> structure?
>
> On Fri, May 26, 2017 at 3:24 PM, Guozhang Wang  wrote:
>
> > I'd say just remove those two lines.
> >
> > On Fri, May 26, 2017 at 7:55 AM, Gwen Shapira  wrote:
> >
> > > This was a discussion, not a vote (sorry for mangling the title), but
> > > thanks for all the +1 anyway.
> > >
> > > Regarding Ismael's feedback:
> > > The current server.properties includes the following:
> > > # Switch to enable topic deletion or not, default value is false
> > > #delete.topic.enable=true
> > >
> > > We can't leave it as is, obviously - since the KIP invalidates the
> > > comment.  Lets just remove those two lines?
> > >
> > > Note that all our proposed changes may break few community
> puppet/docker
> > > scripts that use these lines for "sed" that enables topic deletion.
> > >
> > > Gwen
> > >
> > > On Fri, May 26, 2017 at 5:41 PM Tom Crayford 
> > wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > On Fri, May 26, 2017 at 3:38 PM, Damian Guy 
> > > wrote:
> > > >
> > > > > +1
> > > > > Also agree with what Ismael said.
> > > > >
> > > > > On Fri, 26 May 2017 at 15:26 Ismael Juma 
> wrote:
> > > > >
> > > > > > Thanks for the KIP, sounds good to me. One comment: not sure we
> > need
> > > to
> > > > > add
> > > > > > the config to server.properties. Do we expect people to change
> this
> > > > > > default?
> > > > > >
> > > > > > On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira  >
> > > > wrote:
> > > > > >
> > > > > > > Hi Kafka developers, users and friends,
> > > > > > >
> > > > > > > I've added a KIP to improve our out-of-the-box usability a bit:
> > > > > > > KIP-162: Enable topic deletion by default:
> > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+
> > > > > > > Enable+topic+deletion+by+default
> > > > > > >
> > > > > > > Pretty simple :) Discussion and feedback are welcome.
> > > > > > >
> > > > > > > Gwen
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > -- Guozhang
> >
>

Re: KIP-162: Enable topic deletion by default

[Onur Karaman]

Would it make sense to resolve KAFKA-4893 before enabling it by default, as
fixing the ticket would likely involve changing the log directory structure?

On Fri, May 26, 2017 at 3:24 PM, Guozhang Wang  wrote:

> I'd say just remove those two lines.
>
> On Fri, May 26, 2017 at 7:55 AM, Gwen Shapira  wrote:
>
> > This was a discussion, not a vote (sorry for mangling the title), but
> > thanks for all the +1 anyway.
> >
> > Regarding Ismael's feedback:
> > The current server.properties includes the following:
> > # Switch to enable topic deletion or not, default value is false
> > #delete.topic.enable=true
> >
> > We can't leave it as is, obviously - since the KIP invalidates the
> > comment.  Lets just remove those two lines?
> >
> > Note that all our proposed changes may break few community puppet/docker
> > scripts that use these lines for "sed" that enables topic deletion.
> >
> > Gwen
> >
> > On Fri, May 26, 2017 at 5:41 PM Tom Crayford 
> wrote:
> >
> > > +1 (non-binding)
> > >
> > > On Fri, May 26, 2017 at 3:38 PM, Damian Guy 
> > wrote:
> > >
> > > > +1
> > > > Also agree with what Ismael said.
> > > >
> > > > On Fri, 26 May 2017 at 15:26 Ismael Juma  wrote:
> > > >
> > > > > Thanks for the KIP, sounds good to me. One comment: not sure we
> need
> > to
> > > > add
> > > > > the config to server.properties. Do we expect people to change this
> > > > > default?
> > > > >
> > > > > On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira 
> > > wrote:
> > > > >
> > > > > > Hi Kafka developers, users and friends,
> > > > > >
> > > > > > I've added a KIP to improve our out-of-the-box usability a bit:
> > > > > > KIP-162: Enable topic deletion by default:
> > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+
> > > > > > Enable+topic+deletion+by+default
> > > > > >
> > > > > > Pretty simple :) Discussion and feedback are welcome.
> > > > > >
> > > > > > Gwen
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
>
> --
> -- Guozhang
>

Re: KIP-162: Enable topic deletion by default

[Guozhang Wang]

I'd say just remove those two lines.

On Fri, May 26, 2017 at 7:55 AM, Gwen Shapira  wrote:

> This was a discussion, not a vote (sorry for mangling the title), but
> thanks for all the +1 anyway.
>
> Regarding Ismael's feedback:
> The current server.properties includes the following:
> # Switch to enable topic deletion or not, default value is false
> #delete.topic.enable=true
>
> We can't leave it as is, obviously - since the KIP invalidates the
> comment.  Lets just remove those two lines?
>
> Note that all our proposed changes may break few community puppet/docker
> scripts that use these lines for "sed" that enables topic deletion.
>
> Gwen
>
> On Fri, May 26, 2017 at 5:41 PM Tom Crayford  wrote:
>
> > +1 (non-binding)
> >
> > On Fri, May 26, 2017 at 3:38 PM, Damian Guy 
> wrote:
> >
> > > +1
> > > Also agree with what Ismael said.
> > >
> > > On Fri, 26 May 2017 at 15:26 Ismael Juma  wrote:
> > >
> > > > Thanks for the KIP, sounds good to me. One comment: not sure we need
> to
> > > add
> > > > the config to server.properties. Do we expect people to change this
> > > > default?
> > > >
> > > > On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira 
> > wrote:
> > > >
> > > > > Hi Kafka developers, users and friends,
> > > > >
> > > > > I've added a KIP to improve our out-of-the-box usability a bit:
> > > > > KIP-162: Enable topic deletion by default:
> > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+
> > > > > Enable+topic+deletion+by+default
> > > > >
> > > > > Pretty simple :) Discussion and feedback are welcome.
> > > > >
> > > > > Gwen
> > > > >
> > > >
> > >
> >
>



-- 
-- Guozhang

Re: KIP-162: Enable topic deletion by default

[Jim Jagielski]

> On May 26, 2017, at 1:10 PM, Vahid S Hashemian  
> wrote:
> 
> Gwen, thanks for the KIP.
> It looks good to me.
> 
> Just a minor suggestion: It would be great if the command asks for a 
> confirmation (y/n) before deleting the topic (similar to how removing ACLs 
> works).
> 

+1 (or some sort of 'force' option to bypass the
query)

Re: KIP-162: Enable topic deletion by default

[Vahid S Hashemian]

Gwen, thanks for the KIP.
It looks good to me.

Just a minor suggestion: It would be great if the command asks for a 
confirmation (y/n) before deleting the topic (similar to how removing ACLs 
works).

Thanks.
--Vahid



From:   Gwen Shapira 
To: "dev@kafka.apache.org" , Users 

Date:   05/26/2017 07:04 AM
Subject:KIP-162: Enable topic deletion by default



Hi Kafka developers, users and friends,

I've added a KIP to improve our out-of-the-box usability a bit:
KIP-162: Enable topic deletion by default:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+Enable+topic+deletion+by+default


Pretty simple :) Discussion and feedback are welcome.

Gwen

Re: KIP-162: Enable topic deletion by default

[Bill Bejeck]

+1

On Fri, May 26, 2017 at 10:55 AM, Gwen Shapira  wrote:

> This was a discussion, not a vote (sorry for mangling the title), but
> thanks for all the +1 anyway.
>
> Regarding Ismael's feedback:
> The current server.properties includes the following:
> # Switch to enable topic deletion or not, default value is false
> #delete.topic.enable=true
>
> We can't leave it as is, obviously - since the KIP invalidates the
> comment.  Lets just remove those two lines?
>
> Note that all our proposed changes may break few community puppet/docker
> scripts that use these lines for "sed" that enables topic deletion.
>
> Gwen
>
> On Fri, May 26, 2017 at 5:41 PM Tom Crayford  wrote:
>
> > +1 (non-binding)
> >
> > On Fri, May 26, 2017 at 3:38 PM, Damian Guy 
> wrote:
> >
> > > +1
> > > Also agree with what Ismael said.
> > >
> > > On Fri, 26 May 2017 at 15:26 Ismael Juma  wrote:
> > >
> > > > Thanks for the KIP, sounds good to me. One comment: not sure we need
> to
> > > add
> > > > the config to server.properties. Do we expect people to change this
> > > > default?
> > > >
> > > > On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira 
> > wrote:
> > > >
> > > > > Hi Kafka developers, users and friends,
> > > > >
> > > > > I've added a KIP to improve our out-of-the-box usability a bit:
> > > > > KIP-162: Enable topic deletion by default:
> > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+
> > > > > Enable+topic+deletion+by+default
> > > > >
> > > > > Pretty simple :) Discussion and feedback are welcome.
> > > > >
> > > > > Gwen
> > > > >
> > > >
> > >
> >
>

Re: KIP-162: Enable topic deletion by default

[Gwen Shapira]

This was a discussion, not a vote (sorry for mangling the title), but
thanks for all the +1 anyway.

Regarding Ismael's feedback:
The current server.properties includes the following:
# Switch to enable topic deletion or not, default value is false
#delete.topic.enable=true

We can't leave it as is, obviously - since the KIP invalidates the
comment.  Lets just remove those two lines?

Note that all our proposed changes may break few community puppet/docker
scripts that use these lines for "sed" that enables topic deletion.

Gwen

On Fri, May 26, 2017 at 5:41 PM Tom Crayford  wrote:

> +1 (non-binding)
>
> On Fri, May 26, 2017 at 3:38 PM, Damian Guy  wrote:
>
> > +1
> > Also agree with what Ismael said.
> >
> > On Fri, 26 May 2017 at 15:26 Ismael Juma  wrote:
> >
> > > Thanks for the KIP, sounds good to me. One comment: not sure we need to
> > add
> > > the config to server.properties. Do we expect people to change this
> > > default?
> > >
> > > On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira 
> wrote:
> > >
> > > > Hi Kafka developers, users and friends,
> > > >
> > > > I've added a KIP to improve our out-of-the-box usability a bit:
> > > > KIP-162: Enable topic deletion by default:
> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+
> > > > Enable+topic+deletion+by+default
> > > >
> > > > Pretty simple :) Discussion and feedback are welcome.
> > > >
> > > > Gwen
> > > >
> > >
> >
>

Re: KIP-162: Enable topic deletion by default

[Tom Crayford]

+1 (non-binding)

On Fri, May 26, 2017 at 3:38 PM, Damian Guy  wrote:

> +1
> Also agree with what Ismael said.
>
> On Fri, 26 May 2017 at 15:26 Ismael Juma  wrote:
>
> > Thanks for the KIP, sounds good to me. One comment: not sure we need to
> add
> > the config to server.properties. Do we expect people to change this
> > default?
> >
> > On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira  wrote:
> >
> > > Hi Kafka developers, users and friends,
> > >
> > > I've added a KIP to improve our out-of-the-box usability a bit:
> > > KIP-162: Enable topic deletion by default:
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+
> > > Enable+topic+deletion+by+default
> > >
> > > Pretty simple :) Discussion and feedback are welcome.
> > >
> > > Gwen
> > >
> >
>

Re: KIP-162: Enable topic deletion by default

[Damian Guy]

+1
Also agree with what Ismael said.

On Fri, 26 May 2017 at 15:26 Ismael Juma  wrote:

> Thanks for the KIP, sounds good to me. One comment: not sure we need to add
> the config to server.properties. Do we expect people to change this
> default?
>
> On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira  wrote:
>
> > Hi Kafka developers, users and friends,
> >
> > I've added a KIP to improve our out-of-the-box usability a bit:
> > KIP-162: Enable topic deletion by default:
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+
> > Enable+topic+deletion+by+default
> >
> > Pretty simple :) Discussion and feedback are welcome.
> >
> > Gwen
> >
>

Re: KIP-162: Enable topic deletion by default

[Ismael Juma]

Thanks for the KIP, sounds good to me. One comment: not sure we need to add
the config to server.properties. Do we expect people to change this default?

On Fri, May 26, 2017 at 3:03 PM, Gwen Shapira  wrote:

> Hi Kafka developers, users and friends,
>
> I've added a KIP to improve our out-of-the-box usability a bit:
> KIP-162: Enable topic deletion by default:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+
> Enable+topic+deletion+by+default
>
> Pretty simple :) Discussion and feedback are welcome.
>
> Gwen
>

Re: KIP-162: Enable topic deletion by default

[Jorge Esteban Quilcate Otoya]

+1

El vie., 26 may. 2017 a las 16:14, Matthias J. Sax ()
escribió:

> +1
>
> On 5/26/17 7:03 AM, Gwen Shapira wrote:
> > Hi Kafka developers, users and friends,
> >
> > I've added a KIP to improve our out-of-the-box usability a bit:
> > KIP-162: Enable topic deletion by default:
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+Enable+topic+deletion+by+default
> >
> > Pretty simple :) Discussion and feedback are welcome.
> >
> > Gwen
> >
>
>

Re: KIP-162: Enable topic deletion by default

[Matthias J. Sax]

+1

On 5/26/17 7:03 AM, Gwen Shapira wrote:
> Hi Kafka developers, users and friends,
> 
> I've added a KIP to improve our out-of-the-box usability a bit:
> KIP-162: Enable topic deletion by default:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-162+-+Enable+topic+deletion+by+default
> 
> Pretty simple :) Discussion and feedback are welcome.
> 
> Gwen
> 



signature.asc
Description: OpenPGP digital signature