Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Jan. 14, 2015, 12:43 a.m.) Review request for kafka, Guozhang Wang, joel koshy, and Neha Narkhede. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description (updated) --- Reverted changes to ZookeeperConsumerConnector.scala Combined the import/export offset tool in to a single tool. Refactored OffsetClient Deleted old Export/Import offsets tool Added apache license Added a default value for the constructor parameter ConsumerOffsetChecker will print the OffsetManager and OffsetsTopicPartition it is reading from Resolving COnflicts for OffsetCommitTest.scala Changed the description in comments regarding input parameters for the class and added a check for groupId when th operation is import Diffs (updated) - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 4a3a5b264a021e55c39f4d7424ce04ee591503ef Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review67997 --- core/src/main/scala/kafka/client/ClientUtils.scala https://reviews.apache.org/r/25944/#comment112130 ; not needed core/src/main/scala/kafka/client/ClientUtils.scala https://reviews.apache.org/r/25944/#comment112131 This will blow up if getOffsetManagerChannel returns None. scala None.get java.util.NoSuchElementException: None.get at scala.None$.get(Option.scala:322) ... 33 elided Maybe this method can return Option[BlockingChannel] instead of BlockingChannel? - Eric Olander On Jan. 14, 2015, 12:43 a.m., Mayuresh Gharat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Jan. 14, 2015, 12:43 a.m.) Review request for kafka, Guozhang Wang, joel koshy, and Neha Narkhede. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description --- Reverted changes to ZookeeperConsumerConnector.scala Combined the import/export offset tool in to a single tool. Refactored OffsetClient Deleted old Export/Import offsets tool Added apache license Added a default value for the constructor parameter ConsumerOffsetChecker will print the OffsetManager and OffsetsTopicPartition it is reading from Resolving COnflicts for OffsetCommitTest.scala Changed the description in comments regarding input parameters for the class and added a check for groupId when th operation is import Diffs - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 4a3a5b264a021e55c39f4d7424ce04ee591503ef Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Jan. 13, 2015, 9:56 p.m.) Review request for kafka, Guozhang Wang, joel koshy, and Neha Narkhede. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description (updated) --- Reverted changes to ZookeeperConsumerConnector.scala Combined the import/export offset tool in to a single tool. Refactored OffsetClient Deleted old Export/Import offsets tool Added apache license Added a default value for the constructor parameter ConsumerOffsetChecker will print the OffsetManager and OffsetsTopicPartition it is reading from Resolving COnflicts for OffsetCommitTest.scala Diffs (updated) - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 4a3a5b264a021e55c39f4d7424ce04ee591503ef Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Jan. 8, 2015, 2:35 a.m.) Review request for kafka, Guozhang Wang, joel koshy, and Neha Narkhede. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description --- Reverted changes to ZookeeperConsumerConnector.scala Combined the import/export offset tool in to a single tool. Refactored OffsetClient Deleted old Export/Import offsets tool Added apache license Diffs - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319 Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 28, 2014, 12:15 a.m.) Review request for kafka and joel koshy. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description (updated) --- Reverted changes to ZookeeperConsumerConnector.scala Combined the import/export offset tool in to a single tool. Refactored OffsetClient Deleted old Export/Import offsets tool Diffs (updated) - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319 Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 28, 2014, 12:21 a.m.) Review request for kafka and joel koshy. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description (updated) --- Reverted changes to ZookeeperConsumerConnector.scala Combined the import/export offset tool in to a single tool. Refactored OffsetClient Deleted old Export/Import offsets tool Added apache license Diffs (updated) - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319 Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 24, 2014, 12:41 a.m.) Review request for kafka and joel koshy. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description --- Reverted Changes to ZookeeperConsumerConnector.scala Diffs - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319 Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review65997 --- core/src/main/scala/kafka/client/ClientUtils.scala https://reviews.apache.org/r/25944/#comment109304 See comment in OffsetClient core/src/main/scala/kafka/tools/ExportOffsets.scala https://reviews.apache.org/r/25944/#comment109308 I thought we would be consolidating the export/import tool into a single consumer offsets tool? core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment109306 Ideally, we should have a _class_ OffsetClient - actually, a trait and the interface should be: commitOffsets fetchOffsets close It would be convenient for the user to just instantiate it (the constructor would take a group), use it and then close it. core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment109303 This really should not be part of the offset client's public API. fetchTopicMetadata is a utils-level concept. It can take a channel as an argument over which the metadata request will be sent. - Joel Koshy On Dec. 24, 2014, 12:41 a.m., Mayuresh Gharat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 24, 2014, 12:41 a.m.) Review request for kafka and joel koshy. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description --- Reverted Changes to ZookeeperConsumerConnector.scala Diffs - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319 Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
On Dec. 24, 2014, 1:59 a.m., Joel Koshy wrote: core/src/main/scala/kafka/tools/OffsetClient.scala, line 141 https://reviews.apache.org/r/25944/diff/9/?file=798240#file798240line141 This really should not be part of the offset client's public API. fetchTopicMetadata is a utils-level concept. It can take a channel as an argument over which the metadata request will be sent. Cool. I suppose we should leave it in the ClientUtils and use that in the tools instead of having clientUtils call this internally. On Dec. 24, 2014, 1:59 a.m., Joel Koshy wrote: core/src/main/scala/kafka/tools/ExportOffsets.scala, line 56 https://reviews.apache.org/r/25944/diff/9/?file=798236#file798236line56 I thought we would be consolidating the export/import tool into a single consumer offsets tool? Yeah. I thought of keeping it simple since there were 2 separate classes namely ImportZKOffsets and ExportZKOffsets I will mearge them in to one and use an additional commandline parameter for there usage. - Mayuresh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review65997 --- On Dec. 24, 2014, 12:41 a.m., Mayuresh Gharat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 24, 2014, 12:41 a.m.) Review request for kafka and joel koshy. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description --- Reverted Changes to ZookeeperConsumerConnector.scala Diffs - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319 Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 21, 2014, 10:42 p.m.) Review request for kafka. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description (updated) --- Reverted Changes to ZookeeperConsumerConnector.scala Diffs (updated) - core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Dec. 21, 2014, 11:06 p.m.) Review request for kafka and joel koshy. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description --- Reverted Changes to ZookeeperConsumerConnector.scala Diffs - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319 Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Oct. 3, 2014, 5:43 a.m.) Review request for kafka. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description (updated) --- Added the apache License Diffs (updated) - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala d349a3000feb9ccd57d1f3cb163548d5bf432186 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fbc680fde21b02f11285a4f4b442987356abd17b core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 29d5a17d4a03cfd3f3cdd2994cbd783a4be2732e core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 2d9325045ac1ac2d7531161b32c98c847125cbf0 Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Oct. 2, 2014, 4:05 a.m.) Review request for kafka. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description (updated) --- Made changes to client, ExportOffsets,ImportOffsets and test cases Diffs (updated) - core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde core/src/main/scala/kafka/consumer/SimpleConsumer.scala d349a3000feb9ccd57d1f3cb163548d5bf432186 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fbc680fde21b02f11285a4f4b442987356abd17b core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79 core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2 core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION core/src/main/scala/kafka/utils/Utils.scala 29d5a17d4a03cfd3f3cdd2994cbd783a4be2732e core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191 core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 2d9325045ac1ac2d7531161b32c98c847125cbf0 Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54609 --- core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala https://reviews.apache.org/r/25944/#comment94796 This comment line is for code line 320, better move it above it. core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala https://reviews.apache.org/r/25944/#comment94797 This comment line is for code line 320, better move it above it. core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala https://reviews.apache.org/r/25944/#comment94799 Is there a difference between these two: Thread.sleep() TimeUnit.MILLISECONDS.sleep() since we do the former everywhere in the code base. core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala https://reviews.apache.org/r/25944/#comment94800 Do we still need this variable? core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala https://reviews.apache.org/r/25944/#comment94802 Can we omit collection.Seq() here can just use groupId = config.groupId? core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala https://reviews.apache.org/r/25944/#comment94804 merge in a single line core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala https://reviews.apache.org/r/25944/#comment94806 revert core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala https://reviews.apache.org/r/25944/#comment94807 revert core/src/main/scala/kafka/tools/ExportOffsets.scala https://reviews.apache.org/r/25944/#comment94812 Can we actually make the same format for ZK / offsetmanager, making two different formats would make it harder to be parsed since the user needs to know whether ZK or offsetmanager is used. core/src/main/scala/kafka/tools/ExportOffsets.scala https://reviews.apache.org/r/25944/#comment94810 We can make a parseBrokerList in Utils and use it there, since I have seens this similar parsing logic at multiple places. core/src/main/scala/kafka/tools/ExportOffsets.scala https://reviews.apache.org/r/25944/#comment94811 You can take a look at KAFKA-686's latest patch which did some cleanup on the util functions; these function may probably merged into Utils. core/src/main/scala/kafka/tools/ImportOffsets.scala https://reviews.apache.org/r/25944/#comment94813 Ditto as above, can we unify the input offset format? core/src/main/scala/kafka/tools/ImportOffsets.scala https://reviews.apache.org/r/25944/#comment94814 Ditto as above. core/src/main/scala/kafka/tools/ImportOffsets.scala https://reviews.apache.org/r/25944/#comment94815 Same as Joel suggested: we can just use config's default values. core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment94816 The apache header is missing. core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment94819 This could be error. core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment94822 This can be trace, or we can just print the offset manager id in debug if it does not contain error code. core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment94820 Could be error(Error while connecting to %s:%d for fetching consumer metadata), since thi is not a general exception. core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment94821 When an exception is thrown and caught here, we should skip the rest of the loop. core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment94823 Could be error(Error while connecting to offset manager %s) core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment94824 Some logging inconsistency: broker [%s:%d] broker %s:%d %s:%d core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment94825 Why this API needs to return an Option while the previous one can directly return the reponse? core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment94826 We do not need Possible cause any more, just print the exception's message if necessary. core/src/main/scala/kafka/tools/OffsetClient.scala https://reviews.apache.org/r/25944/#comment94827 Are there any other exceptions that can be caught besides IOExceptions? We need to be careful about always catching Throwable and printing stack trace. - Guozhang Wang On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote: --- This is an
Re: Review Request 25944: Patch for KAFKA-1013
On Sept. 25, 2014, 10:43 p.m., Guozhang Wang wrote: core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala, line 374 https://reviews.apache.org/r/25944/diff/3/?file=703083#file703083line374 Is there a difference between these two: Thread.sleep() TimeUnit.MILLISECONDS.sleep() since we do the former everywhere in the code base. Its the same thing. Just another way of doing it. Internally it does the same thing. On Sept. 25, 2014, 10:43 p.m., Guozhang Wang wrote: core/src/main/scala/kafka/tools/ExportOffsets.scala, line 33 https://reviews.apache.org/r/25944/diff/3/?file=703085#file703085line33 Can we actually make the same format for ZK / offsetmanager, making two different formats would make it harder to be parsed since the user needs to know whether ZK or offsetmanager is used. Yeah, the offset manager format is simpler. So unless we are planning to fetch offsets from ZK and commit to OffsetManager this should work. what do you think? On Sept. 25, 2014, 10:43 p.m., Guozhang Wang wrote: core/src/main/scala/kafka/tools/ExportOffsets.scala, line 199 https://reviews.apache.org/r/25944/diff/3/?file=703085#file703085line199 You can take a look at KAFKA-686's latest patch which did some cleanup on the util functions; these function may probably merged into Utils. Would like to discuss more on this! - Mayuresh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54609 --- On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Sept. 23, 2014, 5:48 p.m.) Review request for kafka. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description --- OffsetCLient Tool API. ImportZkOffsets and ExportZkOffsets replaced by ImportOffsets and ExportOffsets Modified the comments in the headers Corrected a value Diffs - config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fbc680fde21b02f11285a4f4b442987356abd17b core/src/main/scala/kafka/tools/ConfigConstants.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/#review54329
---
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
https://reviews.apache.org/r/25944/#comment94448
Revert this whitespace change.
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
https://reviews.apache.org/r/25944/#comment94568
revert
core/src/main/scala/kafka/tools/ConfigConstants.scala
https://reviews.apache.org/r/25944/#comment94456
I think we can remove this file and just pick up the defaults from object
ConsumerConfig
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94453
I think kafka.client would be a better place for this than kafka.tools
In fact, we should consider rewriting this in Java and putting it in the
clients package, but since this is largely based on the existing code we can
defer on that.
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94567
License header
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94449
Can you remove the auto-generated comments and add scaladocs?
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94454
val socketTimeoutMs = if (config != null) config.socketTimeoutMs else
ConsumerConfig.default...
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94459
Should this be allowed to loop indefinitely until a connection is
established? i.e., remove i shuffledBrokers.size and change line 38 to be i =
(i + 1) % shuffledBrokers.size
If no connection is established then we would hit an NPE on line 53
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94460
Connecting to broker...
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94499
Can you also remove the following:
ClientUtils.scala: channelToOffsetManager
SimpleConsumer.scala: commitOffsets and fetchOffsets
You will need to update ConsumerOffsetChecker to use the OffsetClient as
well
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94455
val (offsetChannelBackoffMs, socketTimeoutMs) = if (config != null)
(config.offsetsChannelBackoffMs, config.socketTimeoutMs)
else ...
(also, the convention elsewhere in the code is to write Ms not MS)
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94484
This would be a good time to rename all these references to coordinator to
offsetManager
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94481
Can you add a info saying Connected to offset manager host:port for group
...
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94557
Should we just use ClientUtils.fetchTopicMetadata?
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94501
Should probably back-off on retries
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94554
Better to name this fetchOffsets
Also, it seems annoying for a user to always have to pass in a consumer
config. Should we just expose the timeouts, etc through this API and provide
defaults as well? Alternatively we could provide an OffsetClient class that
takes these parameters once through its constructor. One benefit of doing that
is it becomes possible to maintain a persistent offset manager channel - with
this for every ofset fetch/commit the consumer (or tools) have to spawn
connections to query for metadata then possibly topic metadata and then the
offset fetch or commit.
Also, consider making a separate OffsetClientConfig class.
Also, see comment below for compatibility with Java. Not sure if the
response can be easily extracted from the option in Java code
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94560
flatMap { case(topic, partitionsMetadata) =
...
}
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94559
You can remove val topicPartitions =
core/src/main/scala/kafka/tools/OffsetClient.scala
https://reviews.apache.org/r/25944/#comment94452
Instead of taking a map of offsetsToCommit it may be better to just take an
OffsetCommitRequest. That will make it easier to use this client from Java. You
will also need to provide a variant of this method that takes
Re: Review Request 25944: Patch for KAFKA-1013
On Sept. 24, 2014, 5:13 p.m., Joel Koshy wrote: core/src/main/scala/kafka/tools/OffsetClient.scala, line 1 https://reviews.apache.org/r/25944/diff/3/?file=703087#file703087line1 I think kafka.client would be a better place for this than kafka.tools In fact, we should consider rewriting this in Java and putting it in the clients package, but since this is largely based on the existing code we can defer on that. Yeah, I can write it in java after we get this checked in. Porting to java should not be a problem - Mayuresh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54329 --- On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Sept. 23, 2014, 5:48 p.m.) Review request for kafka. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description --- OffsetCLient Tool API. ImportZkOffsets and ExportZkOffsets replaced by ImportOffsets and ExportOffsets Modified the comments in the headers Corrected a value Diffs - config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fbc680fde21b02f11285a4f4b442987356abd17b core/src/main/scala/kafka/tools/ConfigConstants.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
On Sept. 25, 2014, 12:54 a.m., Neha Narkhede wrote: Can you consolidate the import and export offsets tools into a single tool? We already have https://issues.apache.org/jira/browse/KAFKA-1476 filed to consolidate tools and it will be great to not create too many redundant tools. Sure I will clean up the code as per the comments and then work on consolidating it in to single tool. - Mayuresh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54487 --- On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Sept. 23, 2014, 5:48 p.m.) Review request for kafka. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description --- OffsetCLient Tool API. ImportZkOffsets and ExportZkOffsets replaced by ImportOffsets and ExportOffsets Modified the comments in the headers Corrected a value Diffs - config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fbc680fde21b02f11285a4f4b442987356abd17b core/src/main/scala/kafka/tools/ConfigConstants.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54286 --- config/consumer.properties https://reviews.apache.org/r/25944/#comment94288 Please discard this core/src/main/scala/kafka/tools/SreOffsetTool.scala https://reviews.apache.org/r/25944/#comment94289 Please discard this!! - Mayuresh Gharat On Sept. 23, 2014, 5:18 p.m., Mayuresh Gharat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Sept. 23, 2014, 5:18 p.m.) Review request for kafka. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description --- OffsetCLient Tool API. ImportZkOffsets and ExportZkOffsets replaced by ImportOffsets and ExportOffsets Diffs - config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fbc680fde21b02f11285a4f4b442987356abd17b core/src/main/scala/kafka/tools/ConfigConstants.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION core/src/main/scala/kafka/tools/SreOffsetTool.scala PRE-CREATION Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Sept. 23, 2014, 5:45 p.m.) Review request for kafka. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description (updated) --- OffsetCLient Tool API. ImportZkOffsets and ExportZkOffsets replaced by ImportOffsets and ExportOffsets Modified the comments in the headers Diffs (updated) - config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fbc680fde21b02f11285a4f4b442987356abd17b core/src/main/scala/kafka/tools/ConfigConstants.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Sept. 23, 2014, 5:48 p.m.) Review request for kafka. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description (updated) --- OffsetCLient Tool API. ImportZkOffsets and ExportZkOffsets replaced by ImportOffsets and ExportOffsets Modified the comments in the headers Corrected a value Diffs (updated) - config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fbc680fde21b02f11285a4f4b442987356abd17b core/src/main/scala/kafka/tools/ConfigConstants.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/#review54288 --- config/consumer.properties https://reviews.apache.org/r/25944/#comment94290 Please discard this file for review - Mayuresh Gharat On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25944/ --- (Updated Sept. 23, 2014, 5:48 p.m.) Review request for kafka. Bugs: KAFKA-1013 https://issues.apache.org/jira/browse/KAFKA-1013 Repository: kafka Description --- OffsetCLient Tool API. ImportZkOffsets and ExportZkOffsets replaced by ImportOffsets and ExportOffsets Modified the comments in the headers Corrected a value Diffs - config/consumer.properties 83847de30d10b6e78bb8de28e0bb925d7c0e6ca2 core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala fbc680fde21b02f11285a4f4b442987356abd17b core/src/main/scala/kafka/tools/ConfigConstants.scala PRE-CREATION core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION Diff: https://reviews.apache.org/r/25944/diff/ Testing --- Thanks, Mayuresh Gharat
