Re: Review Request 26390: Fix KAFKA-1641
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26390/#review58117 --- Ship it! - Joel Koshy On Oct. 9, 2014, 8:04 p.m., Guozhang Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26390/ --- (Updated Oct. 9, 2014, 8:04 p.m.) Review request for kafka. Bugs: KAFKA-1641 https://issues.apache.org/jira/browse/KAFKA-1641 Repository: kafka Description --- Reset cleaning start offset upon abnormal log truncation Diffs - core/src/main/scala/kafka/log/LogCleanerManager.scala e8ced6a5922508ea3274905be7c3d6e728f320ac Diff: https://reviews.apache.org/r/26390/diff/ Testing --- Thanks, Guozhang Wang
Re: Review Request 26390: Fix KAFKA-1641
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26390/#review58144 --- core/src/main/scala/kafka/log/LogCleanerManager.scala https://reviews.apache.org/r/26390/#comment99062 Actually, because of the + the format specifiers are unmatched. I will fix this on check-in. - Joel Koshy On Oct. 9, 2014, 8:04 p.m., Guozhang Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26390/ --- (Updated Oct. 9, 2014, 8:04 p.m.) Review request for kafka. Bugs: KAFKA-1641 https://issues.apache.org/jira/browse/KAFKA-1641 Repository: kafka Description --- Reset cleaning start offset upon abnormal log truncation Diffs - core/src/main/scala/kafka/log/LogCleanerManager.scala e8ced6a5922508ea3274905be7c3d6e728f320ac Diff: https://reviews.apache.org/r/26390/diff/ Testing --- Thanks, Guozhang Wang
Re: Review Request 26390: Fix KAFKA-1641
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26390/ --- (Updated Oct. 9, 2014, 8:04 p.m.) Review request for kafka. Bugs: KAFKA-1641 https://issues.apache.org/jira/browse/KAFKA-1641 Repository: kafka Description --- Reset cleaning start offset upon abnormal log truncation Diffs (updated) - core/src/main/scala/kafka/log/LogCleanerManager.scala e8ced6a5922508ea3274905be7c3d6e728f320ac Diff: https://reviews.apache.org/r/26390/diff/ Testing --- Thanks, Guozhang Wang
Re: Review Request 26390: Fix KAFKA-1641
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26390/#review55696
---
core/src/main/scala/kafka/log/LogCleanerManager.scala
https://reviews.apache.org/r/26390/#comment96074
Can we switch to case(topicPartition , log)?
core/src/main/scala/kafka/log/LogCleanerManager.scala
https://reviews.apache.org/r/26390/#comment96073
firstDirtyOffset = logStartOffset
Personally, I prefer this style for these kinds of statement sequences
since all the logic for setting this val is clearly contained, but again that's
just a preference - I'm okay with the vars also.
```
val firstDirtyOffset = {
val offset = lastClean.getOrElse(l._1, logStartOffset)
if (offset logStartOffset) {
error(...)
logStartOffset
}
else
offset
}
```
core/src/main/scala/kafka/log/LogCleanerManager.scala
https://reviews.apache.org/r/26390/#comment96075
It seems this should be `LogToClean(l._1, l._2, firstDirtyOffset)`
- Joel Koshy
On Oct. 6, 2014, 10:21 p.m., Guozhang Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26390/
---
(Updated Oct. 6, 2014, 10:21 p.m.)
Review request for kafka.
Bugs: KAFKA-1641
https://issues.apache.org/jira/browse/KAFKA-1641
Repository: kafka
Description
---
Reset cleaning start offset upon abnormal log truncation
Diffs
-
core/src/main/scala/kafka/log/LogCleanerManager.scala
e8ced6a5922508ea3274905be7c3d6e728f320ac
Diff: https://reviews.apache.org/r/26390/diff/
Testing
---
Thanks,
Guozhang Wang
Review Request 26390: Fix KAFKA-1641
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26390/ --- Review request for kafka. Bugs: KAFKA-1641 https://issues.apache.org/jira/browse/KAFKA-1641 Repository: kafka Description --- Reset cleaning start offset upon abnormal log truncation Diffs - core/src/main/scala/kafka/log/LogCleanerManager.scala e8ced6a5922508ea3274905be7c3d6e728f320ac Diff: https://reviews.apache.org/r/26390/diff/ Testing --- Thanks, Guozhang Wang
