Re: Review Request 32869: Patch for KAFKA-2091
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32869/#review85608 --- Ship it! Ship It! - Joel Koshy On May 27, 2015, 10:50 p.m., Sriharsha Chintalapani wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32869/ --- (Updated May 27, 2015, 10:50 p.m.) Review request for kafka. Bugs: KAFKA-2091 https://issues.apache.org/jira/browse/KAFKA-2091 Repository: kafka Description --- KAFKA-2091. Expose a Partitioner interface in the new producer. Diffs - clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 8e336a3aa96c73f52beaeb56b931baf4b026cf21 clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java 3c34610dbc8a68e4561e7264e0b545de3d93cef2 clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java PRE-CREATION clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 187d0004c8c46b6664ddaffecc6166d4b47351e5 clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java 93e799105fb6cc5c49a129c0db099a3a973b2ab3 clients/src/test/java/org/apache/kafka/clients/producer/internals/PartitionerTest.java 5dadd0e3554577ad6be28a18ff5ab08f8b31050f Diff: https://reviews.apache.org/r/32869/diff/ Testing --- Thanks, Sriharsha Chintalapani
Re: Review Request 32869: Patch for KAFKA-2091
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32869/#review85476 --- Ship it! Ship It! - Jay Kreps On May 27, 2015, 10:50 p.m., Sriharsha Chintalapani wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32869/ --- (Updated May 27, 2015, 10:50 p.m.) Review request for kafka. Bugs: KAFKA-2091 https://issues.apache.org/jira/browse/KAFKA-2091 Repository: kafka Description --- KAFKA-2091. Expose a Partitioner interface in the new producer. Diffs - clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 8e336a3aa96c73f52beaeb56b931baf4b026cf21 clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java 3c34610dbc8a68e4561e7264e0b545de3d93cef2 clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java PRE-CREATION clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 187d0004c8c46b6664ddaffecc6166d4b47351e5 clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java 93e799105fb6cc5c49a129c0db099a3a973b2ab3 clients/src/test/java/org/apache/kafka/clients/producer/internals/PartitionerTest.java 5dadd0e3554577ad6be28a18ff5ab08f8b31050f Diff: https://reviews.apache.org/r/32869/diff/ Testing --- Thanks, Sriharsha Chintalapani
Re: Review Request 32869: Patch for KAFKA-2091
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32869/ --- (Updated May 27, 2015, 10:50 p.m.) Review request for kafka. Bugs: KAFKA-2091 https://issues.apache.org/jira/browse/KAFKA-2091 Repository: kafka Description --- KAFKA-2091. Expose a Partitioner interface in the new producer. Diffs (updated) - clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 8e336a3aa96c73f52beaeb56b931baf4b026cf21 clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java 3c34610dbc8a68e4561e7264e0b545de3d93cef2 clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java PRE-CREATION clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 187d0004c8c46b6664ddaffecc6166d4b47351e5 clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java 93e799105fb6cc5c49a129c0db099a3a973b2ab3 clients/src/test/java/org/apache/kafka/clients/producer/internals/PartitionerTest.java 5dadd0e3554577ad6be28a18ff5ab08f8b31050f Diff: https://reviews.apache.org/r/32869/diff/ Testing --- Thanks, Sriharsha Chintalapani
Re: Review Request 32869: Patch for KAFKA-2091
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32869/#review80738 --- clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java https://reviews.apache.org/r/32869/#comment130858 It is reasonable to need to partition on the key prior to serialization. I wonder if people would also want access to the value? This is a bit odd, but could potentially be useful... What about making this public int partition(String topic, Object key, byte[] keyBytes, Object value, byte[] valBytes, Integer partition, Cluster cluster); Should DefaultPartitioner move into the public package since now users can directly configure it? Also if this is a public interface it would be good to add a producer test that configures a custom partitioner and checks that it takes effect so that this keeps working. - Jay Kreps On April 6, 2015, 12:13 a.m., Sriharsha Chintalapani wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32869/ --- (Updated April 6, 2015, 12:13 a.m.) Review request for kafka. Bugs: KAFKA-2091 https://issues.apache.org/jira/browse/KAFKA-2091 Repository: kafka Description --- KAFKA-2091. Expose a Partitioner interface in the new producer. Diffs - clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ab263423ff1d33170effb71acdef3fc501fa072a clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java 6913090af03a455452b0b5c3df78f266126b3854 clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java PRE-CREATION clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java fa9daaef66ff7961e1c46cd0cd8fed18a53bccd8 clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java 93e799105fb6cc5c49a129c0db099a3a973b2ab3 clients/src/test/java/org/apache/kafka/clients/producer/internals/PartitionerTest.java 5dadd0e3554577ad6be28a18ff5ab08f8b31050f Diff: https://reviews.apache.org/r/32869/diff/ Testing --- Thanks, Sriharsha Chintalapani
Review Request 32869: Patch for KAFKA-2091
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32869/ --- Review request for kafka. Bugs: KAFKA-2091 https://issues.apache.org/jira/browse/KAFKA-2091 Repository: kafka Description --- KAFKA-2091. Expose a Partitioner interface in the new producer. Diffs - clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ab263423ff1d33170effb71acdef3fc501fa072a clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java 6913090af03a455452b0b5c3df78f266126b3854 clients/src/main/java/org/apache/kafka/clients/producer/Partitioner.java PRE-CREATION clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java fa9daaef66ff7961e1c46cd0cd8fed18a53bccd8 clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java 93e799105fb6cc5c49a129c0db099a3a973b2ab3 clients/src/test/java/org/apache/kafka/clients/producer/internals/PartitionerTest.java 5dadd0e3554577ad6be28a18ff5ab08f8b31050f Diff: https://reviews.apache.org/r/32869/diff/ Testing --- Thanks, Sriharsha Chintalapani
