---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/#review84554
---
Ship it!
This looks good to be, but it would be good to get a second reviewer since this
is fairly critical code.
- Jay Kreps
On May 11, 2015, 10 a.m., Honghai Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
---
(Updated May 11, 2015, 10 a.m.)
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description
---
Kafka 1646 fix add test cases
Diffs
-
core/src/main/scala/kafka/log/FileMessageSet.scala
2522604bd985c513527fa0c863a7df677ff7a503
core/src/main/scala/kafka/log/Log.scala
84e7b8fe9dd014884b60c4fbe13c835cf02a40e4
core/src/main/scala/kafka/log/LogConfig.scala
a907da09e1ccede3b446459225e407cd1ae6d8b3
core/src/main/scala/kafka/log/LogSegment.scala
ed039539ac18ea4d65144073915cf112f7374631
core/src/main/scala/kafka/server/KafkaConfig.scala
9efa15ca5567b295ab412ee9eea7c03eb4cdc18b
core/src/main/scala/kafka/server/KafkaServer.scala
b7d2a2842e17411a823b93bdedc84657cbd62be1
core/src/main/scala/kafka/utils/CoreUtils.scala
d0a8fa701564b4c13b3cd6501e1b6218d77e8e06
core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala
cec1caecc51507ae339ebf8f3b8a028b12a1a056
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala
03fb3512c4a4450eac83d4cd4b0919baeaa22942
Diff: https://reviews.apache.org/r/33204/diff/
Testing
---
Thanks,
Honghai Chen
