Re: Review Request 36270: Patch for KAFKA-2317

2015-07-07 Thread Guozhang Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36270/#review90773
---

Ship it!


Ship It!

- Guozhang Wang


On July 7, 2015, 6:14 p.m., Ashish Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36270/
> ---
> 
> (Updated July 7, 2015, 6:14 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2317
> https://issues.apache.org/jira/browse/KAFKA-2317
> 
> 
> Repository: kafka
> 
> 
> Description
> ---
> 
> KAFKA-2317: De-register isrChangeNotificationListener on controller 
> resignation
> 
> 
> Diffs
> -
> 
>   core/src/main/scala/kafka/controller/KafkaController.scala 
> 09630d07afc75d4b92c847e31032f8a1dfa0dabe 
> 
> Diff: https://reviews.apache.org/r/36270/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>



Review Request 36270: Patch for KAFKA-2317

2015-07-07 Thread Ashish Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36270/
---

Review request for kafka.


Bugs: KAFKA-2317
https://issues.apache.org/jira/browse/KAFKA-2317


Repository: kafka


Description
---

KAFKA-2317: De-register isrChangeNotificationListener on controller resignation


Diffs
-

  core/src/main/scala/kafka/controller/KafkaController.scala 
09630d07afc75d4b92c847e31032f8a1dfa0dabe 

Diff: https://reviews.apache.org/r/36270/diff/


Testing
---


Thanks,

Ashish Singh