Re: Review Request 36341: Patch for KAFKA-2311

2015-07-21 Thread Grant Henke

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36341/#review92417
---

Ship it!


Ship It!

- Grant Henke


On July 9, 2015, 1:04 a.m., Tim Brooks wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36341/
> ---
> 
> (Updated July 9, 2015, 1:04 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2311
> https://issues.apache.org/jira/browse/KAFKA-2311
> 
> 
> Repository: kafka
> 
> 
> Description
> ---
> 
> Remove unnecessary close check
> 
> 
> Diffs
> -
> 
>   clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 
> 1f0e51557c4569f0980b72652846b250d00e05d6 
> 
> Diff: https://reviews.apache.org/r/36341/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tim Brooks
> 
>



Re: Review Request 36341: Patch for KAFKA-2311

2015-07-13 Thread Jason Gustafson

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36341/#review91556
---

Ship it!


Ship It!

- Jason Gustafson


On July 9, 2015, 1:04 a.m., Tim Brooks wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36341/
> ---
> 
> (Updated July 9, 2015, 1:04 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2311
> https://issues.apache.org/jira/browse/KAFKA-2311
> 
> 
> Repository: kafka
> 
> 
> Description
> ---
> 
> Remove unnecessary close check
> 
> 
> Diffs
> -
> 
>   clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 
> 1f0e51557c4569f0980b72652846b250d00e05d6 
> 
> Diff: https://reviews.apache.org/r/36341/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tim Brooks
> 
>



Re: Review Request 36341: Patch for KAFKA-2311

2015-07-08 Thread Sriharsha Chintalapani

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36341/#review91035
---

Ship it!


Ship It!

- Sriharsha Chintalapani


On July 9, 2015, 1:04 a.m., Tim Brooks wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36341/
> ---
> 
> (Updated July 9, 2015, 1:04 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-2311
> https://issues.apache.org/jira/browse/KAFKA-2311
> 
> 
> Repository: kafka
> 
> 
> Description
> ---
> 
> Remove unnecessary close check
> 
> 
> Diffs
> -
> 
>   clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 
> 1f0e51557c4569f0980b72652846b250d00e05d6 
> 
> Diff: https://reviews.apache.org/r/36341/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tim Brooks
> 
>



Review Request 36341: Patch for KAFKA-2311

2015-07-08 Thread Tim Brooks

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36341/
---

Review request for kafka.


Bugs: KAFKA-2311
https://issues.apache.org/jira/browse/KAFKA-2311


Repository: kafka


Description
---

Remove unnecessary close check


Diffs
-

  clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 
1f0e51557c4569f0980b72652846b250d00e05d6 

Diff: https://reviews.apache.org/r/36341/diff/


Testing
---


Thanks,

Tim Brooks