[GitHub] [kafka] ijuma commented on issue #8467: MINOR: reduce allocations in log start and recovery checkpoints
ijuma commented on issue #8467: URL: https://github.com/apache/kafka/pull/8467#issuecomment-616239344 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] kkonstantine commented on a change in pull request #8445: KAFKA-9823: Remember the sent generation for the coordinator request
kkonstantine commented on a change in pull request #8445:
URL: https://github.com/apache/kafka/pull/8445#discussion_r411123324
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -737,16 +751,21 @@ public void handle(SyncGroupResponse syncResponse,
log.debug("SyncGroup failed because the group began
another rebalance");
future.raise(error);
} else if (error == Errors.FENCED_INSTANCE_ID) {
-log.error("Received fatal exception: group.instance.id
gets fenced");
+// for sync-group request, even if the generation has
changed we would not expect the instance id
+// gets fenced, and hence we always treat this as a fatal
error
+log.error("SyncGroup failed with {} due to
group.instance.id {} gets fenced",
+sentGeneration, rebalanceConfig.groupInstanceId);
future.raise(error);
} else if (error == Errors.UNKNOWN_MEMBER_ID
|| error == Errors.ILLEGAL_GENERATION) {
-log.debug("SyncGroup failed: {}", error.message());
-resetGenerationOnResponseError(ApiKeys.SYNC_GROUP, error);
+log.info("SyncGroup failed with {}: {}, would request
re-join", sentGeneration, error.message());
+if (generationUnchanged())
Review comment:
Makes sense. Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] ijuma commented on issue #7677: MINOR: Update to Gradle 6.3
ijuma commented on issue #7677: URL: https://github.com/apache/kafka/pull/7677#issuecomment-616271179 I tested `./gradlew install` with trunk versus this PR after `./gradlew clean`: * trunk: BUILD SUCCESSFUL in 1m 23s * this PR: BUILD SUCCESSFUL in 1m 50s I think that's OK given the incremental compilation improvements. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] kkonstantine commented on a change in pull request #8445: KAFKA-9823: Remember the sent generation for the coordinator request
kkonstantine commented on a change in pull request #8445:
URL: https://github.com/apache/kafka/pull/8445#discussion_r411125481
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -737,16 +751,21 @@ public void handle(SyncGroupResponse syncResponse,
log.debug("SyncGroup failed because the group began
another rebalance");
future.raise(error);
} else if (error == Errors.FENCED_INSTANCE_ID) {
-log.error("Received fatal exception: group.instance.id
gets fenced");
+// for sync-group request, even if the generation has
changed we would not expect the instance id
+// gets fenced, and hence we always treat this as a fatal
error
+log.error("SyncGroup failed with {} due to
group.instance.id {} gets fenced",
+sentGeneration, rebalanceConfig.groupInstanceId);
future.raise(error);
} else if (error == Errors.UNKNOWN_MEMBER_ID
|| error == Errors.ILLEGAL_GENERATION) {
-log.debug("SyncGroup failed: {}", error.message());
-resetGenerationOnResponseError(ApiKeys.SYNC_GROUP, error);
+log.info("SyncGroup failed with {}: {}, would request
re-join", sentGeneration, error.message());
Review comment:
Not sure how this comment was changed, but this still doesn't read well
for me.
Still seems that the message should say `... will request re-join"`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] ijuma commented on issue #7677: MINOR: Update to Gradle 6.3
ijuma commented on issue #7677: URL: https://github.com/apache/kafka/pull/7677#issuecomment-616272581 @omkreddy I've done a bunch of testing and this seems to work as expected generally. One part that I wasn't completely sure about is the behavior of `./gradlew uploadArchivesAll` in trunk versus `./gradlewAll uploadArchives` in this PR with regards to Java modules that end up getting built twice due to being dependencies of the Scala modules (e.g kafka-clients, kafka-streams). When I try this in trunk with a local Maven repository, it fails. With the code in this PR, it completes, but these modules get uploaded twice. So, I have decided to go ahead and merge this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] LiamClarkeNZ opened a new pull request #8520: Add explicit grace period to tumbling window example
LiamClarkeNZ opened a new pull request #8520: URL: https://github.com/apache/kafka/pull/8520 Comments also discuss current default grace period value, and the fact that it may change with the next major release. ### Committer Checklist (excluded from commit message) - [n/a] Verify design and implementation - [n/a] Verify test coverage and CI build status - [X] Verify documentation (including upgrade notes) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on issue #8517: MINOR: avoid unnecessary delay conversion in isDelayed check
ijuma commented on issue #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-616264737 Same test failed in both jobs: > kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup Seems unrelated, but will retest just in case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on issue #8517: MINOR: avoid unnecessary delay conversion in isDelayed check
ijuma commented on issue #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-616264759 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma opened a new pull request #8519: MINOR: Upgrade gradle plugins and test libraries for Java 14 support
ijuma opened a new pull request #8519: URL: https://github.com/apache/kafka/pull/8519 Also remove deprecated `=` in resolutionStrategy. With these changes, the build works with Java 14 and Scala 2.12. The same will apply to Scala 2.13 when Scala 2.13.2 is released (should happen within 1-2 weeks). ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] mjsax commented on issue #8114: KAFKA-9290: Update IQ related JavaDocs
mjsax commented on issue #8114: URL: https://github.com/apache/kafka/pull/8114#issuecomment-616325249 Build failed with checkstyle error: ``` [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java:34:8: Unused import - org.apache.kafka.streams.processor.ProcessorContext. [UnusedImports] 11:59:28 [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk11-scala2.13/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java:163:21: '=' is not preceded with whitespace. [WhitespaceAround] ``` @highluck Can you update the PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] cadonna commented on a change in pull request #8514: MINOR: Further reduce runtime for metrics integration tests
cadonna commented on a change in pull request #8514:
URL: https://github.com/apache/kafka/pull/8514#discussion_r411304452
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RocksDBMetricsIntegrationTest.java
##
@@ -319,18 +266,6 @@ private void checkMetricByName(final List
listMetric,
}
}
-private void verifyThatBytesWrittenTotalIncreases(final KafkaStreams
kafkaStreams,
- final String
metricsScope) throws InterruptedException {
-final List metric = getRocksDBMetrics(kafkaStreams,
metricsScope).stream()
-.filter(m -> BYTES_WRITTEN_TOTAL.equals(m.metricName().name()))
-.collect(Collectors.toList());
-TestUtils.waitForCondition(
-() -> (double) metric.get(0).metricValue() > 0,
-TIMEOUT,
-() -> "RocksDB metric bytes.written.total did not increase in " +
TIMEOUT + " ms"
-);
-}
-
Review comment:
Thank you! I forgot to delete this in my refactoring.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] cadonna commented on a change in pull request #8514: MINOR: Further reduce runtime for metrics integration tests
cadonna commented on a change in pull request #8514:
URL: https://github.com/apache/kafka/pull/8514#discussion_r411304452
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RocksDBMetricsIntegrationTest.java
##
@@ -319,18 +266,6 @@ private void checkMetricByName(final List
listMetric,
}
}
-private void verifyThatBytesWrittenTotalIncreases(final KafkaStreams
kafkaStreams,
- final String
metricsScope) throws InterruptedException {
-final List metric = getRocksDBMetrics(kafkaStreams,
metricsScope).stream()
-.filter(m -> BYTES_WRITTEN_TOTAL.equals(m.metricName().name()))
-.collect(Collectors.toList());
-TestUtils.waitForCondition(
-() -> (double) metric.get(0).metricValue() > 0,
-TIMEOUT,
-() -> "RocksDB metric bytes.written.total did not increase in " +
TIMEOUT + " ms"
-);
-}
-
Review comment:
Thank you! I forgot to delete this in my refctoring.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] tombentley commented on a change in pull request #8222: KAFKA-9650: include human readable units in ms and bytes configs
tombentley commented on a change in pull request #8222:
URL: https://github.com/apache/kafka/pull/8222#discussion_r411295815
##
File path: clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java
##
@@ -1179,6 +1186,50 @@ protected String getConfigValue(ConfigKey key, String
headerName) {
}
}
+private static String niceMemoryUnits(ConfigKey key) {
+final long defaultValueBytes = ((Number) key.defaultValue).longValue();
+long defaultValue = defaultValueBytes;
+int i = 0;
+while (i < 5) {
+if (defaultValue % 1024 != 0) {
+break;
+}
+defaultValue /= 1024;
+i++;
+}
+switch (i) {
+case 1:
+return " (=" + defaultValue + "KiB)";
Review comment:
You're right, but in this case we're dealing with kibibytes, not
kilobyes, and [it seems](https://en.wikipedia.org/wiki/Kibibyte) in this case
KiB is the standard abbreviation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] highluck commented on issue #8114: KAFKA-9290: Update IQ related JavaDocs
highluck commented on issue #8114: URL: https://github.com/apache/kafka/pull/8114#issuecomment-616510519 Thank you for reivew Yes ok! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] tombentley commented on issue #8222: KAFKA-9650: include human readable units in ms and bytes configs
tombentley commented on issue #8222: URL: https://github.com/apache/kafka/pull/8222#issuecomment-616538532 @mimaison I rewrote that code, which I think makes it clear enough and avoids the repeated constants. Rendered it looks like this:  I wasn't too sure about the `=` in parens, but I thought it made it clearer that it wasn't part of the default value. I guess an alternative would be to use some other font, or italics to make that clear. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma edited a comment on issue #8490: MINOR: Fix compiler warnings and add @nowarn for the unfixed ones
ijuma edited a comment on issue #8490: URL: https://github.com/apache/kafka/pull/8490#issuecomment-614073786 Looks like the annotation is somehow not in the binary. I added a comment to the upstream ticket: https://github.com/scala/scala-collection-compat/pull/312#issuecomment-614073213 _**Edit**_: fixed in scala-collection-compat 2.1.6. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] tombentley commented on issue #8450: KAFKA-7613: Enable -Xlint:rawtypes in clients, fixing warnings
tombentley commented on issue #8450: URL: https://github.com/apache/kafka/pull/8450#issuecomment-616548913 @ijuma would you be able to take a look at this, since you opened the original issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] tombentley commented on issue #8449: KAFKA-7613: Enable -Xlint:try, fixing warnings
tombentley commented on issue #8449: URL: https://github.com/apache/kafka/pull/8449#issuecomment-616548667 @ijuma would you be able to take a look at this, since you opened the original issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy
ijuma commented on a change in pull request #8417:
URL: https://github.com/apache/kafka/pull/8417#discussion_r411378332
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java
##
@@ -57,6 +59,10 @@ public ByteBuffer serialize(ApiKeys apiKey, short version,
int correlationId) {
return Collections.singletonMap(error, 1);
}
+protected Map errorCounts(Stream errors) {
+return errors.collect(Collectors.groupingBy(e -> e,
Collectors.summingInt(e -> 1)));
+}
+
protected Map errorCounts(Collection errors) {
Review comment:
@tombentley Have we done any testing to verify that this way of doing
things is no slower than the old way?
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java
##
@@ -57,6 +59,10 @@ public ByteBuffer serialize(ApiKeys apiKey, short version,
int correlationId) {
return Collections.singletonMap(error, 1);
}
+protected Map errorCounts(Stream errors) {
+return errors.collect(Collectors.groupingBy(e -> e,
Collectors.summingInt(e -> 1)));
+}
+
protected Map errorCounts(Collection errors) {
Review comment:
@tombentley Have we done any testing to verify that this way of doing
things is no slower than the old way?
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java
##
@@ -57,6 +59,10 @@ public ByteBuffer serialize(ApiKeys apiKey, short version,
int correlationId) {
return Collections.singletonMap(error, 1);
}
+protected Map errorCounts(Stream errors) {
+return errors.collect(Collectors.groupingBy(e -> e,
Collectors.summingInt(e -> 1)));
Review comment:
@tombentley Have we done any testing to verify that this way of doing
things is no slower than the old way?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #8506: Minor: avoid duplicate unwrapping when end of stream has been reached
chia7712 commented on a change in pull request #8506:
URL: https://github.com/apache/kafka/pull/8506#discussion_r411355668
##
File path:
clients/src/main/java/org/apache/kafka/common/network/SslTransportLayer.java
##
@@ -293,6 +293,11 @@ public void handshake() throws IOException {
updateBytesBuffered(true);
} catch (SSLException e) {
maybeProcessHandshakeFailure(e, true, null);
+} catch (EOFException e) {
+// it is impossible to complete handshake successfully due to
end-of-stream. Hence, it should throw either
+// EOFException or SslAuthenticationException directly.
+maybeThrowSslAuthenticationException();
+throw e;
Review comment:
@rajinisivaram thanks for the feedback. This optimization is trivial and
there is no strong reason for it. So I'm going to close this PR :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] ijuma commented on issue #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy
ijuma commented on issue #8417: URL: https://github.com/apache/kafka/pull/8417#issuecomment-616553082 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] rajinisivaram commented on a change in pull request #8506: Minor: avoid duplicate unwrapping when end of stream has been reached
rajinisivaram commented on a change in pull request #8506:
URL: https://github.com/apache/kafka/pull/8506#discussion_r411331273
##
File path:
clients/src/main/java/org/apache/kafka/common/network/SslTransportLayer.java
##
@@ -293,6 +293,11 @@ public void handshake() throws IOException {
updateBytesBuffered(true);
} catch (SSLException e) {
maybeProcessHandshakeFailure(e, true, null);
+} catch (EOFException e) {
+// it is impossible to complete handshake successfully due to
end-of-stream. Hence, it should throw either
+// EOFException or SslAuthenticationException directly.
+maybeThrowSslAuthenticationException();
+throw e;
Review comment:
@chia7712 Is there a reason why we need this change? If so, can we add a
test? If there is no data to unwrap, we would just throw the exception in the
IOException catch block below anyway. Since we only get here when the other
side has closed its connection, which is typically a handshake failure, I am
not sure we need to optimize.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] ijuma commented on issue #8519: MINOR: Upgrade gradle plugins and test libraries for Java 14 support
ijuma commented on issue #8519: URL: https://github.com/apache/kafka/pull/8519#issuecomment-616531362 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on issue #8429: MINOR: Enable fatal warnings with scala 2.13
ijuma commented on issue #8429: URL: https://github.com/apache/kafka/pull/8429#issuecomment-616542386 Will rebase after https://github.com/apache/kafka/pull/8490 is merged. Scala 2.13.2 should be released within 1 to 2 weeks and is a requirement for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on issue #8449: KAFKA-7613: Enable -Xlint:try, fixing warnings
ijuma commented on issue #8449: URL: https://github.com/apache/kafka/pull/8449#issuecomment-616552849 Yes, I should be able to review this tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on issue #8450: KAFKA-7613: Enable -Xlint:rawtypes in clients, fixing warnings
ijuma commented on issue #8450: URL: https://github.com/apache/kafka/pull/8450#issuecomment-616552532 Yes, I should be able to review this tomorrow. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy
ijuma commented on a change in pull request #8417:
URL: https://github.com/apache/kafka/pull/8417#discussion_r411379678
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java
##
@@ -57,6 +59,10 @@ public ByteBuffer serialize(ApiKeys apiKey, short version,
int correlationId) {
return Collections.singletonMap(error, 1);
}
+protected Map errorCounts(Stream errors) {
+return errors.collect(Collectors.groupingBy(e -> e,
Collectors.summingInt(e -> 1)));
+}
+
protected Map errorCounts(Collection errors) {
Map errorCounts = new HashMap<>();
for (Errors error : errors)
Review comment:
We can probably update `updateErrorsCounts` to use `getOrDefault` (I
can't comment on the relevant line directly).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] omkreddy commented on issue #8521: MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists
omkreddy commented on issue #8521: URL: https://github.com/apache/kafka/pull/8521#issuecomment-616604860 @ijuma Thanks for the review. Merging to trunk. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy
ijuma commented on a change in pull request #8417:
URL: https://github.com/apache/kafka/pull/8417#discussion_r411381287
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/AlterPartitionReassignmentsResponse.java
##
@@ -66,14 +64,13 @@ public int throttleTimeMs() {
public Map errorCounts() {
Map counts = new HashMap<>();
Errors topLevelErr = Errors.forCode(data.errorCode());
-counts.put(topLevelErr, counts.getOrDefault(topLevelErr, 0) + 1);
+updateErrorCounts(counts, topLevelErr);
-for (ReassignableTopicResponse topicResponse : data.responses()) {
-for (ReassignablePartitionResponse partitionResponse :
topicResponse.partitions()) {
-Errors error = Errors.forCode(partitionResponse.errorCode());
-counts.put(error, counts.getOrDefault(error, 0) + 1);
-}
-}
+data.responses().forEach(topicResponse ->
+topicResponse.partitions().forEach(partitionResponse ->
+updateErrorCounts(counts,
Errors.forCode(partitionResponse.errorCode()))
Review comment:
Indenting seems wrong?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #8521: MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists
ijuma commented on a change in pull request #8521: URL: https://github.com/apache/kafka/pull/8521#discussion_r411389823 ## File path: .asf.yaml ## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +notifications: + commits: comm...@kafka.apache.org + issues: git...@kafka.apache.org + pullrequests: git...@kafka.apache.org Review comment: Do we have this mailing list already? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #8521: MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists
ijuma commented on a change in pull request #8521: URL: https://github.com/apache/kafka/pull/8521#discussion_r411401447 ## File path: .asf.yaml ## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +notifications: + commits: comm...@kafka.apache.org + issues: git...@kafka.apache.org + pullrequests: git...@kafka.apache.org Review comment: Btw, we have a `JIRA mailing list`, maybe we can use that for `issues`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #8521: MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists
ijuma commented on a change in pull request #8521: URL: https://github.com/apache/kafka/pull/8521#discussion_r411401447 ## File path: .asf.yaml ## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +notifications: + commits: comm...@kafka.apache.org + issues: git...@kafka.apache.org + pullrequests: git...@kafka.apache.org Review comment: Btw, we have a `JIRA mailing list`, maybe we can use that for `issues` and `pull requests` for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] highluck commented on issue #8114: KAFKA-9290: Update IQ related JavaDocs
highluck commented on issue #8114: URL: https://github.com/apache/kafka/pull/8114#issuecomment-616573641 @mjsax It was a hotfix! #8515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] omkreddy opened a new pull request #8521: MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists
omkreddy opened a new pull request #8521: URL: https://github.com/apache/kafka/pull/8521 Following the instructions from: https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-ImplementedFeatures This PR redirects all github `commit` notifications to `comm...@kafka.apache.org` and `issues`, `pullrequests` notifications to `git...@kafka.apache.org` mailing list. Also enable `link` `label` JIRA notification options. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on issue #8490: MINOR: Fix compiler warnings and add @nowarn for the unfixed ones
ijuma commented on issue #8490: URL: https://github.com/apache/kafka/pull/8490#issuecomment-616567152 Looks like this annotation is not present in the Scala 2.13 version of this library. So we need to wait for Scala 2.13.2 to be released before we can merge it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] omkreddy commented on a change in pull request #8521: MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists
omkreddy commented on a change in pull request #8521: URL: https://github.com/apache/kafka/pull/8521#discussion_r411399680 ## File path: .asf.yaml ## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +notifications: + commits: comm...@kafka.apache.org + issues: git...@kafka.apache.org + pullrequests: git...@kafka.apache.org Review comment: Good Question. I think, we dont have ``git...@kafka.apache.org` yet. Only ASF members and PMC Chair can create mailing list using : https://selfserve.apache.org/ Maybe we can request @junrao to create a new mailing address : `git...@kafka.apache.org` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #8521: MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists
ijuma commented on a change in pull request #8521: URL: https://github.com/apache/kafka/pull/8521#discussion_r411400608 ## File path: .asf.yaml ## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +notifications: + commits: comm...@kafka.apache.org + issues: git...@kafka.apache.org + pullrequests: git...@kafka.apache.org Review comment: Can we use the `commits` mailing list for now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] omkreddy commented on a change in pull request #8521: MINOR: Use .asf.yaml to direct github notifications to JIRA and mailing lists
omkreddy commented on a change in pull request #8521: URL: https://github.com/apache/kafka/pull/8521#discussion_r411406852 ## File path: .asf.yaml ## @@ -0,0 +1,22 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +notifications: + commits: comm...@kafka.apache.org + issues: git...@kafka.apache.org + pullrequests: git...@kafka.apache.org Review comment: sounds good. we can use `j...@afka.apache.org`. If required, we can change later. updated the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka] WanderingStar commented on issue #8184: KAKFA-9612 CLI Dynamic Configuration with file input
WanderingStar commented on issue #8184: URL: https://github.com/apache/kafka/pull/8184#issuecomment-616585615 @rajinisivaram, @cmccabe, @gwenshap would you mind taking a look at this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] hartantothio opened a new pull request #263: Added KS2020 (Virtual)
hartantothio opened a new pull request #263: URL: https://github.com/apache/kafka-site/pull/263 ## Reviewers @guozhangwang @mjsax This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] showuon opened a new pull request #264: MINOR: Reorder the documentation sub-title to sync with the TOC
showuon opened a new pull request #264: URL: https://github.com/apache/kafka-site/pull/264 current Table of Content(TOC) in navigation sidebar:  **TOC in the content:** 1. Getting Started 2. APIs 3. Configuration 4. Design 5. Implementation 6. Operations 7. Security 8. Kafka Connect 9. Kafka Streams This change will sync them up. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] mjsax commented on pull request #264: MINOR: Reorder the documentation sub-title to sync with the TOC
mjsax commented on pull request #264: URL: https://github.com/apache/kafka-site/pull/264#issuecomment-623619312 Thanks for the PR @showuon! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] showuon opened a new pull request #265: Update stream documentation
showuon opened a new pull request #265: URL: https://github.com/apache/kafka-site/pull/265 1. fix broken links 2. rephrase a sentence 3. update the version number This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] showuon commented on pull request #265: MINOR: Update stream documentation for version 2.5
showuon commented on pull request #265: URL: https://github.com/apache/kafka-site/pull/265#issuecomment-629911823 Same change with the PR to `kafka` repo: https://github.com/apache/kafka/pull/8622/ per @bbejeck 's request. Thanks. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] bbejeck commented on pull request #265: MINOR: Update stream documentation for version 2.5
bbejeck commented on pull request #265: URL: https://github.com/apache/kafka-site/pull/265#issuecomment-630893259 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] bbejeck merged pull request #265: MINOR: Update stream documentation for version 2.5
bbejeck merged pull request #265: URL: https://github.com/apache/kafka-site/pull/265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] ableegoldman opened a new pull request #301: Redo 2.6 docs commit
ableegoldman opened a new pull request #301: URL: https://github.com/apache/kafka-site/pull/301 Just noticed that all of the docs I added just before 2.6 aren't actually showing up on the site. Seems like they were accidentally reverted by [this commit](https://github.com/apache/kafka-site/commit/35d3b804b86c249aace9a729c5abd9be4525ef3d) So, this PR just redoes everything that was originally in https://github.com/apache/kafka-site/commit/4c19eab4f6315c91549be0bff08ad46173be4f64 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] vvcephei merged pull request #301: Redo 2.6 docs commit
vvcephei merged pull request #301: URL: https://github.com/apache/kafka-site/pull/301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] vvcephei commented on a change in pull request #301: Redo 2.6 docs commit
vvcephei commented on a change in pull request #301: URL: https://github.com/apache/kafka-site/pull/301#discussion_r485142442 ## File path: 26/streams/developer-guide/memory-mgmt.html ## @@ -202,7 +202,10 @@ RocksDB} } -1. INDEX_FILTER_BLOCK_RATIO can be used to set a fraction of the block cache to set aside for "high priority" (aka index and filter) blocks, preventing them from being evicted by data blocks. See the full signature of the https://github.com/facebook/rocksdb/blob/master/java/src/main/java/org/rocksdb/LRUCache.java#L72;>LRUCache constructor. +1. INDEX_FILTER_BLOCK_RATIO can be used to set a fraction of the block cache to set aside for "high priority" (aka index and filter) blocks, preventing them from being evicted by data blocks. See the full signature of the https://github.com/facebook/rocksdb/blob/master/java/src/main/java/org/rocksdb/LRUCache.java#L72;>LRUCache constructor. + NOTE: the boolean parameter in the cache constructor lets you control whether the cache should enforce a strict memory limit by failing the read or iteration in the rare cases where it might go larger than its capacity. Due to a + https://github.com/facebook/rocksdb/issues/6247;>bug in RocksDB, this option cannot be used + if the write buffer memory is also counted against the cache. If you set this to true, you should NOT pass the cache in to the WriteBufferManager and just control the write buffer and cache memory separately. Review comment: It looks like this (and some other stuff in the config-streams file) has come along for the ride. We should make sure it's referencing behavior that was released, not behavior that will be released next. Can you double-check that this actually is in reference to 2.6.0, and not 2.6.1+? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] ableegoldman commented on a change in pull request #301: Redo 2.6 docs commit
ableegoldman commented on a change in pull request #301: URL: https://github.com/apache/kafka-site/pull/301#discussion_r485154723 ## File path: 26/streams/developer-guide/memory-mgmt.html ## @@ -202,7 +202,10 @@ RocksDB} } -1. INDEX_FILTER_BLOCK_RATIO can be used to set a fraction of the block cache to set aside for "high priority" (aka index and filter) blocks, preventing them from being evicted by data blocks. See the full signature of the https://github.com/facebook/rocksdb/blob/master/java/src/main/java/org/rocksdb/LRUCache.java#L72;>LRUCache constructor. +1. INDEX_FILTER_BLOCK_RATIO can be used to set a fraction of the block cache to set aside for "high priority" (aka index and filter) blocks, preventing them from being evicted by data blocks. See the full signature of the https://github.com/facebook/rocksdb/blob/master/java/src/main/java/org/rocksdb/LRUCache.java#L72;>LRUCache constructor. + NOTE: the boolean parameter in the cache constructor lets you control whether the cache should enforce a strict memory limit by failing the read or iteration in the rare cases where it might go larger than its capacity. Due to a + https://github.com/facebook/rocksdb/issues/6247;>bug in RocksDB, this option cannot be used + if the write buffer memory is also counted against the cache. If you set this to true, you should NOT pass the cache in to the WriteBufferManager and just control the write buffer and cache memory separately. Review comment: Nope, this is correct. My original commit had a few other fixes on the side in addition to the KIP-441/KIP-613 docs As far as I know this has always been the case in every RocksDB version we've depended on but didn't discover the bug until just recently. (I believe it actually is fixed in some newer versions, so we may be able to remove this again once we upgrade) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] ableegoldman commented on a change in pull request #301: Redo 2.6 docs commit
ableegoldman commented on a change in pull request #301: URL: https://github.com/apache/kafka-site/pull/301#discussion_r485154723 ## File path: 26/streams/developer-guide/memory-mgmt.html ## @@ -202,7 +202,10 @@ RocksDB} } -1. INDEX_FILTER_BLOCK_RATIO can be used to set a fraction of the block cache to set aside for "high priority" (aka index and filter) blocks, preventing them from being evicted by data blocks. See the full signature of the https://github.com/facebook/rocksdb/blob/master/java/src/main/java/org/rocksdb/LRUCache.java#L72;>LRUCache constructor. +1. INDEX_FILTER_BLOCK_RATIO can be used to set a fraction of the block cache to set aside for "high priority" (aka index and filter) blocks, preventing them from being evicted by data blocks. See the full signature of the https://github.com/facebook/rocksdb/blob/master/java/src/main/java/org/rocksdb/LRUCache.java#L72;>LRUCache constructor. + NOTE: the boolean parameter in the cache constructor lets you control whether the cache should enforce a strict memory limit by failing the read or iteration in the rare cases where it might go larger than its capacity. Due to a + https://github.com/facebook/rocksdb/issues/6247;>bug in RocksDB, this option cannot be used + if the write buffer memory is also counted against the cache. If you set this to true, you should NOT pass the cache in to the WriteBufferManager and just control the write buffer and cache memory separately. Review comment: Nope, this is correct. As far as I know this has always been the case in every RocksDB version we've depended on but didn't discover the bug until just recently. (I believe it actually is fixed in some newer versions, so we may be able to remove this again once we upgrade) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] ewencp merged pull request #300: [MINOR] adding Itau Unibanco and OTICS to the powered-by page
ewencp merged pull request #300: URL: https://github.com/apache/kafka-site/pull/300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] scott-confluent opened a new pull request #302: Updating title on videos page
scott-confluent opened a new pull request #302: URL: https://github.com/apache/kafka-site/pull/302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] mjsax merged pull request #302: Updating title on videos page
mjsax merged pull request #302: URL: https://github.com/apache/kafka-site/pull/302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] dajac opened a new pull request #303: Add dajac to committers
dajac opened a new pull request #303: URL: https://github.com/apache/kafka-site/pull/303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] dajac merged pull request #303: Add dajac to committers
dajac merged pull request #303: URL: https://github.com/apache/kafka-site/pull/303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] chia7712 merged pull request #304: Add chia7712 to committers
chia7712 merged pull request #304: URL: https://github.com/apache/kafka-site/pull/304 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] chia7712 commented on pull request #304: Add chia7712 to committers
chia7712 commented on pull request #304: URL: https://github.com/apache/kafka-site/pull/304#issuecomment-711161869 @guozhangwang Thanks for confirming. Merge it to trunk :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] chia7712 opened a new pull request #304: Add chia7712 to committers
chia7712 opened a new pull request #304: URL: https://github.com/apache/kafka-site/pull/304 hello Kafka :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] guozhangwang commented on pull request #304: Add chia7712 to committers
guozhangwang commented on pull request #304: URL: https://github.com/apache/kafka-site/pull/304#issuecomment-710760998 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] chia7712 commented on pull request #304: Add chia7712 to committers
chia7712 commented on pull request #304: URL: https://github.com/apache/kafka-site/pull/304#issuecomment-710767238 @guozhangwang thanks for reviews! > you'd also need to git add the image file as well. The image file is already included. Please correct me if I misunderstand your point. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] guozhangwang commented on pull request #304: Add chia7712 to committers
guozhangwang commented on pull request #304: URL: https://github.com/apache/kafka-site/pull/304#issuecomment-711025894 I missed that file. You are good to go. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] miguno commented on pull request #305: Add the best talks from Kafka Summit 2020
miguno commented on pull request #305: URL: https://github.com/apache/kafka-site/pull/305#issuecomment-711975561 I tested the PR locally with `vnu` (HTML validation) and via https://cwiki.apache.org/confluence/display/KAFKA/Setup+Kafka+Website+on+Local+Apache+Server. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] miguno commented on pull request #305: Add the best talks from Kafka Summit 2020
miguno commented on pull request #305: URL: https://github.com/apache/kafka-site/pull/305#issuecomment-711980559 HTML cleanup example. After cleanup: ```html https://www.confluent.io/kafka-summit-san-francisco-2019/eventing-things-a-netflix-original/;>Eventing Things A Netflix Original! (https://kafka-summit.org/sessions/eventing-things-netflix-original/;>abstract), Nitin Sharma (Netflix), SFO 2019 ``` Before cleanup: ```html https://www.confluent.io/kafka-summit-san-francisco-2019/eventing-things-a-netflix-original/; >Eventing Things A Netflix Original!(https://kafka-summit.org/sessions/eventing-things-netflix-original/; >abstract), Nitin Sharma (Netflix), SFO 2019 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] miguno opened a new pull request #305: Add the best talks from Kafka Summit 2020
miguno opened a new pull request #305: URL: https://github.com/apache/kafka-site/pull/305 This PR adds the thirty best Kafka Summit 2020 talks as rated by the community (summit attendees). To make maintenance of the Videos page easier, I also refactored (read: cleaned up) the HTML of the original page, which was very messy to deal with. I also added a table of contents as the page has now a length of a few screens. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] tom1299 closed pull request #290: MINOR: Add missing to to testing
tom1299 closed pull request #290: URL: https://github.com/apache/kafka-site/pull/290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] mjsax merged pull request #305: Add the best talks from Kafka Summit 2020
mjsax merged pull request #305: URL: https://github.com/apache/kafka-site/pull/305 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] vvcephei merged pull request #295: MINOR: fix for text wrapping in some tables in docs
vvcephei merged pull request #295: URL: https://github.com/apache/kafka-site/pull/295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] SanjayYr opened a new pull request #296: MINOR: fix for extra line break in streams processor API documentation
SanjayYr opened a new pull request #296: URL: https://github.com/apache/kafka-site/pull/296 Removed the extra "/p" tag. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] SanjayYr opened a new pull request #297: MINOR: fix for example implementation of how to add a new header to the record
SanjayYr opened a new pull request #297: URL: https://github.com/apache/kafka-site/pull/297 Fixed method invocation and arguments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] scott-confluent opened a new pull request #295: fix for text wrapping in some tables in docs
scott-confluent opened a new pull request #295: URL: https://github.com/apache/kafka-site/pull/295 Someone opened a JIRA ticket for this: https://issues.apache.org/jira/browse/KAFKA-10406 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] guozhangwang commented on pull request #293: MINOR: fix for quickstart in docs
guozhangwang commented on pull request #293: URL: https://github.com/apache/kafka-site/pull/293#issuecomment-675832265 @scott-confluent After merged the PR the new link seems still not working? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] guozhangwang merged pull request #293: MINOR: fix for quickstart in docs
guozhangwang merged pull request #293: URL: https://github.com/apache/kafka-site/pull/293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] mimaison merged pull request #299: fix: Fix link for Kafka London meetup
mimaison merged pull request #299: URL: https://github.com/apache/kafka-site/pull/299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] katheris opened a new pull request #299: fix: Fix link for Kafka London meetup
katheris opened a new pull request #299: URL: https://github.com/apache/kafka-site/pull/299 Signed-off-by: Katherine Stanley This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] mjsax merged pull request #298: MINOR: remove unreleased versions from CVE page
mjsax merged pull request #298: URL: https://github.com/apache/kafka-site/pull/298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] mjsax opened a new pull request #298: MINOR: remove unreleased versions from CVE page
mjsax opened a new pull request #298: URL: https://github.com/apache/kafka-site/pull/298 As reported on the mailing list: https://lists.apache.org/list.html?dev@kafka.apache.org:lte=1M:cve%202.0.2%202.1.2 Call for review @ijuma This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] scott-confluent opened a new pull request #300: [MINOR] adding Itau Unibanco and OTICS to the powered-by page
scott-confluent opened a new pull request #300: URL: https://github.com/apache/kafka-site/pull/300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] viktorsomogyi edited a comment on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric
viktorsomogyi edited a comment on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo (and perhaps get someone to merge it). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] viktorsomogyi commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric
viktorsomogyi commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] ankit-kumar-25 commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric
ankit-kumar-25 commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603 Hey @viktorsomogyi, Thank you for the pointers, I have created a PR against the ops.html available in the Kafka project: https://github.com/apache/kafka/pull/9314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] ankit-kumar-25 edited a comment on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric
ankit-kumar-25 edited a comment on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603 Hey @viktorsomogyi, Thank you for the pointers, I have created a PR against the ops.html available in the Kafka project: https://github.com/apache/kafka/pull/9325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] ankit-kumar-25 closed pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric
ankit-kumar-25 closed pull request #220: URL: https://github.com/apache/kafka-site/pull/220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] ankit-kumar-25 commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric
ankit-kumar-25 commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696188603 Hey @viktorsomogyi, Thank you for the pointers, I have created a PR against the ops.html available in the Kafka project: https://github.com/apache/kafka/pull/9314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] mjsax commented on pull request #266: MINOR: Add more info in the "adding to contributor list" section
mjsax commented on pull request #266: URL: https://github.com/apache/kafka-site/pull/266#issuecomment-634390804 Thanks a lot @showuon! This seems to be super helpful! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] showuon commented on pull request #266: MINOR: Add more info in the "adding to contributor list" section
showuon commented on pull request #266: URL: https://github.com/apache/kafka-site/pull/266#issuecomment-634381918 hi @mjsax , I think you must love this PR because you won't have to handle the "requesting to be added into contributor list" but without JIRA ID provided issue. :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] mjsax merged pull request #266: MINOR: Add more info in the "adding to contributor list" section
mjsax merged pull request #266: URL: https://github.com/apache/kafka-site/pull/266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] showuon opened a new pull request #266: MINOR: Add more info in the "adding to contributor list" section
showuon opened a new pull request #266: URL: https://github.com/apache/kafka-site/pull/266 We usually got this kind of email to request to be added into contributor list, but without JIRA username provided. That wasted the committer's or the existing contributor's time to do more explanation. I found it's because we didn't provide enough information in the **How to contribute** page. I added the info explicitly: **with your JIRA account username provided in the email** . **example 1**  **example 2**  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] viktorsomogyi commented on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric
viktorsomogyi commented on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] viktorsomogyi edited a comment on pull request #220: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric
viktorsomogyi edited a comment on pull request #220: URL: https://github.com/apache/kafka-site/pull/220#issuecomment-696132637 Otherwise it looks good, I can approve it once you create the PR in the kafka repo (and perhaps get someone to merge it). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] ableegoldman opened a new pull request #306: Add ableegoldman to committers
ableegoldman opened a new pull request #306: URL: https://github.com/apache/kafka-site/pull/306 A bit late on this but here we go This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] ableegoldman commented on a change in pull request #306: Add ableegoldman to committers
ableegoldman commented on a change in pull request #306: URL: https://github.com/apache/kafka-site/pull/306#discussion_r513151562 ## File path: committers.html ## @@ -334,6 +334,14 @@ The committers Committer https://www.linkedin.com/in/chia7712/;>/in/chia7712 + Review comment: Ah, good catch. Fixed now -- thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] chia7712 commented on a change in pull request #306: Add ableegoldman to committers
chia7712 commented on a change in pull request #306: URL: https://github.com/apache/kafka-site/pull/306#discussion_r513148887 ## File path: committers.html ## @@ -334,6 +334,14 @@ The committers Committer https://www.linkedin.com/in/chia7712/;>/in/chia7712 + Review comment: It needs a new line (`` and ``) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] ableegoldman merged pull request #306: Add ableegoldman to committers
ableegoldman merged pull request #306: URL: https://github.com/apache/kafka-site/pull/306 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] rhauch commented on a change in pull request #260: Add 2.5.0 release to website
rhauch commented on a change in pull request #260: URL: https://github.com/apache/kafka-site/pull/260#discussion_r464774655 ## File path: downloads.html ## @@ -5,12 +5,52 @@ Download -2.4.1 is the latest release. The current stable version is 2.4.1. +2.5.0 is the latest release. The current stable version is 2.5.0. You can verify your download by following these https://www.apache.org/info/verification.html;>procedures and using these https://www.apache.org/dist/kafka/KEYS;>KEYS. + +2.5.0 + + +Released April 15, 2020 + + +https://www.apache.org/dist/kafka/2.5.0/RELEASE_NOTES.html;>Release Notes + + +Source download: https://www.apache.org/dyn/closer.cgi?path=/kafka/2.5.0/kafka-2.5.0-src.tgz;>kafka-2.5.0-src.tgz (https://www.apache.org/dist/kafka/2.5.0/kafka-2.5.0-src.tgz.asc;>asc, https://www.apache.org/dist/kafka/2.5.0/kafka-2.5.0-src.tgz.sha512;>sha512) + + +Binary downloads: + +Scala 2.12 - https://www.apache.org/dyn/closer.cgi?path=/kafka/2.5.0/kafka_2.12-2.5.0.tgz;>kafka_2.12-2.5.0.tgz (https://www.apache.org/dist/kafka/2.5.0/kafka_2.12-2.5.0.tgz.asc;>asc, https://www.apache.org/dist/kafka/2.5.0/kafka_2.12-2.5.0.tgz.sha512;>sha512) +Scala 2.13 - https://www.apache.org/dyn/closer.cgi?path=/kafka/2.5.0/kafka_2.13-2.5.0.tgz;>kafka_2.13-2.5.0.tgz (https://www.apache.org/dist/kafka/2.5.0/kafka_2.13-2.5.0.tgz.asc;>asc, https://www.apache.org/dist/kafka/2.5.0/kafka_2.13-2.5.0.tgz.sha512;>sha512) + +We build for multiple versions of Scala. This only matters if you are using Scala and you want a version +built for the same Scala version you use. Otherwise any version should work (2.12 is recommended). + + + + +Kafka 2.5.0 includes a number of significant new features. Here is a summary of some notable changes: + + + +TLS 1.3 support (1.2 is now the default) +Co-groups for Kafka Streams +Incremental rebalance for Kafka Consumer +New metrics for better operational insight +Upgrade Zookeeper to 3.5.7 +Deprecate support for Scala 2.11 + + + +For more information, please read the detailed https://www.apache.org/dist/kafka/2.5.0/RELEASE_NOTES.html;>Release Notes. + + Review comment: These should have been added to the kafka repository in the `documentation/upgrade.html` file. See https://github.com/apache/kafka/pull/9118 that adds this section back into the correct location/repository, and see https://github.com/apache/kafka/pull/9117 for a similar fix for the 2.6.0 release. See https://github.com/apache/kafka/pull/9119 for a fix for the `trunk` branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] rhauch opened a new pull request #277: 2.6.0 release
rhauch opened a new pull request #277: URL: https://github.com/apache/kafka-site/pull/277 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] guozhangwang merged pull request #269: Kafka nav and hompeage redesign
guozhangwang merged pull request #269: URL: https://github.com/apache/kafka-site/pull/269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release
rhauch commented on a change in pull request #277: URL: https://github.com/apache/kafka-site/pull/277#discussion_r465425702 ## File path: 26/upgrade.html ## @@ -19,6 +19,48 @@
[GitHub] [kafka-site] rhauch commented on a change in pull request #277: 2.6.0 release
rhauch commented on a change in pull request #277: URL: https://github.com/apache/kafka-site/pull/277#discussion_r465425450 ## File path: 26/upgrade.html ## @@ -19,6 +19,48 @@
[GitHub] [kafka-site] scott-confluent commented on a change in pull request #284: MINOR: Change the arrow direction based on the view state is expanded or not
scott-confluent commented on a change in pull request #284:
URL: https://github.com/apache/kafka-site/pull/284#discussion_r466554238
##
File path: includes/_footer.htm
##
@@ -329,7 +329,13 @@
var docsHandle =
document.querySelector('.toc-handle');
function toggleDocsWidth() {
-
docsContainer.classList.toggle('expanded');
+ let isExpanded =
docsContainer.classList.toggle('expanded');
+ // change the arrow direction based on
the view state is expanded or not
+ if (isExpanded) {
Review comment:
This is technically only working because JavaScript is lax on types and
the `DOMTokenList` returned by `classList.toggle` is empty resulting in a
falsy value. We should probably do `isExapnded.contains('expanded')` as the
condition to be more explicit.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
