[GitHub] karaf pull request #331: Fix karaf scheduler interface abstraction leak on e...

2017-07-27 Thread CMoH 
GitHub user CMoH opened a pull request:

https://github.com/apache/karaf/pull/331

Fix karaf scheduler interface abstraction leak on exceptions

Wrap quartz SchedulerException in SchedulerError instead of using the
private exception class in the scheduler API.

This fixes wiring errors in service clients when using the scheduler 
interface, since class `org.quartz.SchedulerException` is not exported by 
scheduler-core bundle.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/CMoH/karaf fix-scheduler-abstraction-leak

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/karaf/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #331


commit 6a548d83f4977f383524637d2f129b339c6578a3
Author: Ciprian Ciubotariu 
Date:   2017-07-27T17:13:32Z

Fix karaf scheduler interface abstraction leak on exceptions

Wrap quartz SchedulerException in SchedulerError instead of using the
private exception class in the scheduler API.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Building custom dist, including all features of a repository

2017-07-27 Thread Jean-Baptiste Onofré 

Cool, thanks !

Regards
JB

On 07/27/2017 09:55 AM, Fabian Lange wrote:

Sure, done in
https://issues.apache.org/jira/browse/KARAF-5273

No prio from my side though, its more a convenience thing
Fabian

On Thu, Jul 27, 2017 at 9:51 AM, Jean-Baptiste Onofré 
wrote:


Ah yeah, that's it: the wildcard is for verify. Actually, we could do the
same for assembly as well.

@Fabian: can you create the Jira about that ?

Thanks
Regards
JB


On 07/27/2017 09:03 AM, Guillaume Nodet wrote:


The verify goal accepts a matching pattern, but I don't think the assembly
goal ever supported it.

2017-07-27 8:33 GMT+02:00 Jean-Baptiste Onofré :

Hi,


AFAIR it was supported, so  it looks like a regression. Let me take a
look.

And it doesn't work just defining the repo and using
installAllFeaturesByDefault true ?

Can you create a Jira about that, I will investigate ? Thanks !

Regards
JB


On 07/27/2017 07:52 AM, Fabian Lange wrote:

Sure, JB, :-)


 
myfeature-*
 

Unable to build assembly: Could not find matching feature for
myfeature-*

That is probably because

https://github.com/apache/karaf/blob/master/profile/src/main
/java/org/apache/karaf/profile/assembly/Builder.java#L1284

Checks for f.getName().equals(name)


If that should be supported, then this is also probably the place where
I
would add some wildcarding

Fabian

--
Fabian Lange | Performance Expert
mobil: +49 (0) 160.3673393

codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland

Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
Schütz

On Thu, Jul 27, 2017 at 7:38 AM, Jean-Baptiste Onofré 
wrote:

Hi Fabian,



did you try with wildcard ?

Regards
JB


On 07/26/2017 06:49 PM, Fabian Lange wrote:

Hi,



I have a features.xml aka repository, and I want to include all
features
defined in that repository when building a dist with
karaf-maven-plugin.

As far as I can tell this doesnt work, and I need to list all features
manually as boot/installed feature

Is this something we should have?

Fabian

--
Fabian Lange | Performance Expert
mobil: +49 (0) 160.3673393

codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland

Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
Schütz







--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: Building custom dist, including all features of a repository

2017-07-27 Thread Fabian Lange 
Sure, done in
https://issues.apache.org/jira/browse/KARAF-5273

No prio from my side though, its more a convenience thing
Fabian

On Thu, Jul 27, 2017 at 9:51 AM, Jean-Baptiste Onofré 
wrote:

> Ah yeah, that's it: the wildcard is for verify. Actually, we could do the
> same for assembly as well.
>
> @Fabian: can you create the Jira about that ?
>
> Thanks
> Regards
> JB
>
>
> On 07/27/2017 09:03 AM, Guillaume Nodet wrote:
>
>> The verify goal accepts a matching pattern, but I don't think the assembly
>> goal ever supported it.
>>
>> 2017-07-27 8:33 GMT+02:00 Jean-Baptiste Onofré :
>>
>> Hi,
>>>
>>> AFAIR it was supported, so  it looks like a regression. Let me take a
>>> look.
>>>
>>> And it doesn't work just defining the repo and using
>>> installAllFeaturesByDefault true ?
>>>
>>> Can you create a Jira about that, I will investigate ? Thanks !
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 07/27/2017 07:52 AM, Fabian Lange wrote:
>>>
>>> Sure, JB, :-)

 
myfeature-*
 

 Unable to build assembly: Could not find matching feature for
 myfeature-*

 That is probably because

 https://github.com/apache/karaf/blob/master/profile/src/main
 /java/org/apache/karaf/profile/assembly/Builder.java#L1284

 Checks for f.getName().equals(name)


 If that should be supported, then this is also probably the place where
 I
 would add some wildcarding

 Fabian

 --
 Fabian Lange | Performance Expert
 mobil: +49 (0) 160.3673393

 codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland

 Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
 Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
 Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
 Schütz

 On Thu, Jul 27, 2017 at 7:38 AM, Jean-Baptiste Onofré 
 wrote:

 Hi Fabian,

>
> did you try with wildcard ?
>
> Regards
> JB
>
>
> On 07/26/2017 06:49 PM, Fabian Lange wrote:
>
> Hi,
>
>>
>> I have a features.xml aka repository, and I want to include all
>> features
>> defined in that repository when building a dist with
>> karaf-maven-plugin.
>>
>> As far as I can tell this doesnt work, and I need to list all features
>> manually as boot/installed feature
>>
>> Is this something we should have?
>>
>> Fabian
>>
>> --
>> Fabian Lange | Performance Expert
>> mobil: +49 (0) 160.3673393
>>
>> codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland
>>
>> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
>> Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
>> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
>> Schütz
>>
>>
>>

Re: Building custom dist, including all features of a repository

2017-07-27 Thread Jean-Baptiste Onofré 
Ah yeah, that's it: the wildcard is for verify. Actually, we could do the same 
for assembly as well.


@Fabian: can you create the Jira about that ?

Thanks
Regards
JB

On 07/27/2017 09:03 AM, Guillaume Nodet wrote:

The verify goal accepts a matching pattern, but I don't think the assembly
goal ever supported it.

2017-07-27 8:33 GMT+02:00 Jean-Baptiste Onofré :


Hi,

AFAIR it was supported, so  it looks like a regression. Let me take a look.

And it doesn't work just defining the repo and using
installAllFeaturesByDefault true ?

Can you create a Jira about that, I will investigate ? Thanks !

Regards
JB


On 07/27/2017 07:52 AM, Fabian Lange wrote:


Sure, JB, :-)


   myfeature-*


Unable to build assembly: Could not find matching feature for myfeature-*

That is probably because

https://github.com/apache/karaf/blob/master/profile/src/main
/java/org/apache/karaf/profile/assembly/Builder.java#L1284

Checks for f.getName().equals(name)


If that should be supported, then this is also probably the place where I
would add some wildcarding

Fabian

--
Fabian Lange | Performance Expert
mobil: +49 (0) 160.3673393

codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland

Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
Schütz

On Thu, Jul 27, 2017 at 7:38 AM, Jean-Baptiste Onofré 
wrote:

Hi Fabian,


did you try with wildcard ?

Regards
JB


On 07/26/2017 06:49 PM, Fabian Lange wrote:

Hi,


I have a features.xml aka repository, and I want to include all features
defined in that repository when building a dist with karaf-maven-plugin.

As far as I can tell this doesnt work, and I need to list all features
manually as boot/installed feature

Is this something we should have?

Fabian

--
Fabian Lange | Performance Expert
mobil: +49 (0) 160.3673393

codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland

Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
Schütz


--

Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com





--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com







--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Re: Building custom dist, including all features of a repository

2017-07-27 Thread Guillaume Nodet 
The verify goal accepts a matching pattern, but I don't think the assembly
goal ever supported it.

2017-07-27 8:33 GMT+02:00 Jean-Baptiste Onofré :

> Hi,
>
> AFAIR it was supported, so  it looks like a regression. Let me take a look.
>
> And it doesn't work just defining the repo and using
> installAllFeaturesByDefault true ?
>
> Can you create a Jira about that, I will investigate ? Thanks !
>
> Regards
> JB
>
>
> On 07/27/2017 07:52 AM, Fabian Lange wrote:
>
>> Sure, JB, :-)
>>
>>
>>   myfeature-*
>>
>>
>> Unable to build assembly: Could not find matching feature for myfeature-*
>>
>> That is probably because
>>
>> https://github.com/apache/karaf/blob/master/profile/src/main
>> /java/org/apache/karaf/profile/assembly/Builder.java#L1284
>>
>> Checks for f.getName().equals(name)
>>
>>
>> If that should be supported, then this is also probably the place where I
>> would add some wildcarding
>>
>> Fabian
>>
>> --
>> Fabian Lange | Performance Expert
>> mobil: +49 (0) 160.3673393
>>
>> codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland
>>
>> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
>> Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
>> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
>> Schütz
>>
>> On Thu, Jul 27, 2017 at 7:38 AM, Jean-Baptiste Onofré 
>> wrote:
>>
>> Hi Fabian,
>>>
>>> did you try with wildcard ?
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 07/26/2017 06:49 PM, Fabian Lange wrote:
>>>
>>> Hi,

 I have a features.xml aka repository, and I want to include all features
 defined in that repository when building a dist with karaf-maven-plugin.

 As far as I can tell this doesnt work, and I need to list all features
 manually as boot/installed feature

 Is this something we should have?

 Fabian

 --
 Fabian Lange | Performance Expert
 mobil: +49 (0) 160.3673393

 codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland

 Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
 Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
 Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
 Schütz


 --
>>> Jean-Baptiste Onofré
>>> jbono...@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>>
>>>
>>
> --
> Jean-Baptiste Onofré
> jbono...@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>



-- 

Guillaume Nodet

Re: Building custom dist, including all features of a repository

2017-07-27 Thread Fabian Lange 
Hi,
will check, but I do not really want to install all standard and framework
features as side effect ;)

Fabian

On Thu, Jul 27, 2017 at 8:33 AM, Jean-Baptiste Onofré 
wrote:

> Hi,
>
> AFAIR it was supported, so  it looks like a regression. Let me take a look.
>
> And it doesn't work just defining the repo and using
> installAllFeaturesByDefault true ?
>
> Can you create a Jira about that, I will investigate ? Thanks !
>
> Regards
> JB
>
>
> On 07/27/2017 07:52 AM, Fabian Lange wrote:
>
>> Sure, JB, :-)
>>
>>
>>   myfeature-*
>>
>>
>> Unable to build assembly: Could not find matching feature for myfeature-*
>>
>> That is probably because
>>
>> https://github.com/apache/karaf/blob/master/profile/src/main
>> /java/org/apache/karaf/profile/assembly/Builder.java#L1284
>>
>> Checks for f.getName().equals(name)
>>
>>
>> If that should be supported, then this is also probably the place where I
>> would add some wildcarding
>>
>> Fabian
>>
>> --
>> Fabian Lange | Performance Expert
>> mobil: +49 (0) 160.3673393
>>
>> codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland
>>
>> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
>> Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
>> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
>> Schütz
>>
>> On Thu, Jul 27, 2017 at 7:38 AM, Jean-Baptiste Onofré 
>> wrote:
>>
>> Hi Fabian,
>>>
>>> did you try with wildcard ?
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 07/26/2017 06:49 PM, Fabian Lange wrote:
>>>
>>> Hi,

 I have a features.xml aka repository, and I want to include all features
 defined in that repository when building a dist with karaf-maven-plugin.

 As far as I can tell this doesnt work, and I need to list all features
 manually as boot/installed feature

 Is this something we should have?

 Fabian

 --
 Fabian Lange | Performance Expert
 mobil: +49 (0) 160.3673393

 codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland

 Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
 Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
 Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
 Schütz


 --
>>> Jean-Baptiste Onofré
>>> jbono...@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>>
>>>
>>
> --
> Jean-Baptiste Onofré
> jbono...@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>

Re: Building custom dist, including all features of a repository

2017-07-27 Thread Jean-Baptiste Onofré 

Hi,

AFAIR it was supported, so  it looks like a regression. Let me take a look.

And it doesn't work just defining the repo and using installAllFeaturesByDefault 
true ?


Can you create a Jira about that, I will investigate ? Thanks !

Regards
JB

On 07/27/2017 07:52 AM, Fabian Lange wrote:

Sure, JB, :-)

   
  myfeature-*
   

Unable to build assembly: Could not find matching feature for myfeature-*

That is probably because

https://github.com/apache/karaf/blob/master/profile/src/main/java/org/apache/karaf/profile/assembly/Builder.java#L1284

Checks for f.getName().equals(name)


If that should be supported, then this is also probably the place where I
would add some wildcarding

Fabian

--
Fabian Lange | Performance Expert
mobil: +49 (0) 160.3673393

codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland

Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen Schütz

On Thu, Jul 27, 2017 at 7:38 AM, Jean-Baptiste Onofré 
wrote:


Hi Fabian,

did you try with wildcard ?

Regards
JB


On 07/26/2017 06:49 PM, Fabian Lange wrote:


Hi,

I have a features.xml aka repository, and I want to include all features
defined in that repository when building a dist with karaf-maven-plugin.

As far as I can tell this doesnt work, and I need to list all features
manually as boot/installed feature

Is this something we should have?

Fabian

--
Fabian Lange | Performance Expert
mobil: +49 (0) 160.3673393

codecentric AG | Hochstraße 11 | 42697 Solingen | Deutschland

Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen
Schütz



--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com





--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com