Re: Tab Completion Trunk
I'm -1 for [3] as the most insteresting on the root level: it's where you have all commands in the completer, which is what we should avoid for subshell. By the way, feature:list doesn't switch automatically to the feature subshell (you can use feature:list on the root level, or any other levels, or go explicitely to the feature subshell). I will add the: subshell.completion.only=false flag: - if subshell.completion.only=false, the completer will complete to all subshells, commands, aliases (on any level) - if subshell.completion.only=true, the completer will complete to all subshells and aliases depending of the level Regards JB On 09/27/2013 09:42 PM, Achim Nierbeck wrote: +1 for giving the user an easy way of en/dis-abling of such a feature. Second I'd prefer variant 2 with a slight varian, or better a [3] - I prefer to use subshell with completion on subshell, but when I'm on the root-Shell I do have global completion, and a feature:list doesn't switch automatically to the feature sub-shell regards, Achim 2013/9/27 nseb seb_nicoul...@hotmail.com +1 An option will give the user the choice. In fact, it all depends on what phase we are in, using the shell is not necessarily the same. It is also necessary that this option can be enabled / disabled from the shell. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755p4029768.html Sent from the Karaf - Dev mailing list archive at Nabble.com. -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: Tab Completion Trunk
Am 27.09.2013 21:42, schrieb Achim Nierbeck: +1 for giving the user an easy way of en/dis-abling of such a feature. Second I'd prefer variant 2 with a slight varian, or better a [3] - I prefer to use subshell with completion on subshell, but when I'm on the root-Shell I do have global completion, and a feature:list doesn't switch automatically to the feature sub-shell +1 That sounds good. To not delay the 3.0.0 release I would also be fine to only have global completion and deliver the switch and the completion defaults Achim described in a 3.0.1 release. Christian -- Christian Schneider http://www.liquid-reality.de Open Source Architect Talend Application Integration Division http://www.talend.com
Re: Tab Completion Trunk
Hi Christian, I can do the change very quickly, and, anyway, we are waiting a Blueprint release (I'm dealing with the Aries team about that). So it gives me the time to implement the configuration flag. Regards JB On 09/28/2013 10:56 AM, Christian Schneider wrote: Am 27.09.2013 21:42, schrieb Achim Nierbeck: +1 for giving the user an easy way of en/dis-abling of such a feature. Second I'd prefer variant 2 with a slight varian, or better a [3] - I prefer to use subshell with completion on subshell, but when I'm on the root-Shell I do have global completion, and a feature:list doesn't switch automatically to the feature sub-shell +1 That sounds good. To not delay the 3.0.0 release I would also be fine to only have global completion and deliver the switch and the completion defaults Achim described in a 3.0.1 release. Christian -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: Tab Completion Trunk
Ok , but we also lost another feature, if I type feature:install j and tab, it offers me the list of features installed beginning by the letter j (in my case ) All these behaviors are very recent, I'd say two months on the version of the trunk. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755p4029759.html Sent from the Karaf - Dev mailing list archive at Nabble.com.
Re: Tab Completion Trunk
Only installed, or also uninstalled (it shound be only the uninstalled features) ? Regards JB On 09/27/2013 10:59 AM, nseb wrote: Ok , but we also lost another feature, if I type feature:install j and tab, it offers me the list of features installed beginning by the letter j (in my case ) All these behaviors are very recent, I'd say two months on the version of the trunk. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755p4029759.html Sent from the Karaf - Dev mailing list archive at Nabble.com. -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: Tab Completion Trunk
By the way, if you do: karaf@root feature karaf@root:feature install jTAB is it OK there ? Regards JB On 09/27/2013 10:59 AM, nseb wrote: Ok , but we also lost another feature, if I type feature:install j and tab, it offers me the list of features installed beginning by the letter j (in my case ) All these behaviors are very recent, I'd say two months on the version of the trunk. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755p4029759.html Sent from the Karaf - Dev mailing list archive at Nabble.com. -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: Tab Completion Trunk
Yes, only if we are in subshell. I still maintain that the system was better before because bcp more interactive and what we call a shell. Currently, we are developing bundles, I go through the installation of feature, I have to check my bundle is properly activated, potentially make a update or refresh a bundle, a bundle of test command, see the logs. With the new method is tedious, before that I was faster because I autocomplete from any location. the shell mode loses much of its interest. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755p4029763.html Sent from the Karaf - Dev mailing list archive at Nabble.com.
Re: Tab Completion Trunk
I get your point. The purpose of subshell is to avoid a huge number of commands, especially when you type TAB. Imagine when you add Camel, CXF, and other projects in Karaf: it's not easy with the bunch of commands displayed. In any case, if you know the commands, you can still use actual command (like bundle:start, bundle:stop), no need to go into the subshell. However, it's fair enough to start a discussion: [1] I prefer to use subshell with completion on subshell [2] I prefer to use subshell with global complete for all commands Let see what the other users prefer. Regards JB On 09/27/2013 02:39 PM, nseb wrote: Yes, only if we are in subshell. I still maintain that the system was better before because bcp more interactive and what we call a shell. Currently, we are developing bundles, I go through the installation of feature, I have to check my bundle is properly activated, potentially make a update or refresh a bundle, a bundle of test command, see the logs. With the new method is tedious, before that I was faster because I autocomplete from any location. the shell mode loses much of its interest. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755p4029763.html Sent from the Karaf - Dev mailing list archive at Nabble.com. -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: Tab Completion Trunk
+1 An option will give the user the choice. I would set the option to global completion by default though so people have their old behaviour. I personally am ok with the number of possible completions global completion produces. By typing the start of the command you can narrow down the list easily. Christian On 27.09.2013 14:46, Jean-Baptiste Onofré wrote: Another thing that I can do is to define a property in etc/org.apache.karaf.shell.cfg to let the user decide: global completion or subshell completion. Like this, each user can use what he prefers. Regards JB On 09/27/2013 02:39 PM, nseb wrote: Yes, only if we are in subshell. I still maintain that the system was better before because bcp more interactive and what we call a shell. Currently, we are developing bundles, I go through the installation of feature, I have to check my bundle is properly activated, potentially make a update or refresh a bundle, a bundle of test command, see the logs. With the new method is tedious, before that I was faster because I autocomplete from any location. the shell mode loses much of its interest. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755p4029763.html Sent from the Karaf - Dev mailing list archive at Nabble.com. -- Christian Schneider http://www.liquid-reality.de Open Source Architect http://www.talend.com
Re: Tab Completion Trunk
+1 An option will give the user the choice. In fact, it all depends on what phase we are in, using the shell is not necessarily the same. It is also necessary that this option can be enabled / disabled from the shell. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755p4029768.html Sent from the Karaf - Dev mailing list archive at Nabble.com.
Re: Tab Completion Trunk
+1 for giving the user an easy way of en/dis-abling of such a feature. Second I'd prefer variant 2 with a slight varian, or better a [3] - I prefer to use subshell with completion on subshell, but when I'm on the root-Shell I do have global completion, and a feature:list doesn't switch automatically to the feature sub-shell regards, Achim 2013/9/27 nseb seb_nicoul...@hotmail.com +1 An option will give the user the choice. In fact, it all depends on what phase we are in, using the shell is not necessarily the same. It is also necessary that this option can be enabled / disabled from the shell. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755p4029768.html Sent from the Karaf - Dev mailing list archive at Nabble.com. -- Apache Karaf http://karaf.apache.org/ Committer PMC OPS4J Pax Web http://wiki.ops4j.org/display/paxweb/Pax+Web/ Committer Project Lead OPS4J Pax for Vaadin http://team.ops4j.org/wiki/display/PAXVAADIN/Home Commiter Project Lead blog http://notizblog.nierbeck.de/
Tab Completion Trunk
In latest sources in trunk , If I type feature followed by pressing the tab key, I see that the proposed feature and comande only. So before we all under command of feature that were proposed. This is true for all the commands. In addition, after pressing TAB, a space is added after the name of the command, I tried debugged but I do not see the problem. Thanks for your reply. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755.html Sent from the Karaf - Dev mailing list archive at Nabble.com.
Re: Tab Completion Trunk
It's normal it's the subshell. Now, you go in a kind of subshell (for instance dedicated to features) and you can get out with exit command. I gonna document this deeper. Regards JB On 09/26/2013 04:51 PM, nseb wrote: In latest sources in trunk , If I type feature followed by pressing the tab key, I see that the proposed feature and comande only. So before we all under command of feature that were proposed. This is true for all the commands. In addition, after pressing TAB, a space is added after the name of the command, I tried debugged but I do not see the problem. Thanks for your reply. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755.html Sent from the Karaf - Dev mailing list archive at Nabble.com. -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: Tab Completion Trunk
I knew the subshell function, but there is still a little time on the trunk development version, if you pressed tab we saw all of the subcommands available for a given subshell without going into this command. this is no longer the case without going into the subshell command. I think it is annoying. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755p4029757.html Sent from the Karaf - Dev mailing list archive at Nabble.com.
Re: Tab Completion Trunk
It's the new behavior. It doesn't make sense to display all commands: you have the completion for the commands only in the current shell. That's why we see only the subshells, the aliases and the commands for the default scope. Subshell without this filter completion is not interesting. It's exactly as Cisco IOS for instance. Regards JB On 09/26/2013 09:50 PM, nseb wrote: I knew the subshell function, but there is still a little time on the trunk development version, if you pressed tab we saw all of the subcommands available for a given subshell without going into this command. this is no longer the case without going into the subshell command. I think it is annoying. -- View this message in context: http://karaf.922171.n3.nabble.com/Tab-Completion-Trunk-tp4029755p4029757.html Sent from the Karaf - Dev mailing list archive at Nabble.com. -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
