[jira] [Comment Edited] (KNOX-2400) Can't login with SSO+CAS
[
https://issues.apache.org/jira/browse/KNOX-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183421#comment-17183421
]
rohannimmagadda edited comment on KNOX-2400 at 8/27/20, 4:59 PM:
-
[~lmccay]
We faced similar issue with Knox 1.4 + JDK 1.8 while creating the file in HDFS
with Knox+webHDFS curl , However here is the few steps we have taken to fix
this issue
# Step1 : We've started the Knox Service alone with Open JDK 11 by exporting
JAVA command in gateway.sh (ex: export JAVA=/usr/java/openjdk-11/bin/java)
# Step2: If you’r using http auth to non Kerberos which means
(hadoop.http.authentication.type: simple,
hadoop.http.authentication.simple.anonymous.allowed: true) the above export
JAVA command would work
# Otherwise , If your are using OpenJDK 11 and have http authentication
enabled to Kerberos, you may experience authentication errors (i.e HTTP ERROR
401 ** Authentication require like in YARN and WebHDFS gateway URLs *)* when
running Knox Services . To work around this problem: We tried setting this
sun.security.krb5.disableReferrals=true` value in java.security file but it
didn’t worked out in our case
# Here is the fix : By removing `renew_lifetime` property from /etc/krb5.conf
resolved our issue
# we can also run below command to keep renew_lifetime in krb5.conf modprinc
-maxlife 1days -maxrenewlife 7days +allow_renewable knox/Knox_node@Realm
was (Author: rohannimmagadda):
[~lmccay]
We faced similar issue with Knox 1.4 + JDK 1.8 while creating the file in HDFS
with Knox+webHDFS curl , However here is the few steps we have taken to fix
this issue
# Step1 : We've started the Knox Service alone with Open JDK 11 by exporting
JAVA command in gateway.sh (ex: export JAVA=/usr/java/openjdk-11/bin/java)
# Step2: If you’r using http auth to non Kerberos which means
(hadoop.http.authentication.type: simple,
hadoop.http.authentication.simple.anonymous.allowed: true) the above export
JAVA command would work
# Otherwise , If your are using OpenJDK 11 and have http authentication
enabled to Kerberos, you may experience authentication errors (i.e HTTP ERROR
401 ** Authentication require like in YARN and WebHDFS gateway URLs *)* when
running Knox Services . To work around this problem: We tried setting this
sun.security.krb5.disableReferrals=true` value in java.security file but it
didn’t worked out in our case
# Here is the fix : By removing `renew_lifetime` property from /etc/krb5.conf
resolved our issue
# we can also run below command to keep renew_lifetime in krb5.conf
> Can't login with SSO+CAS
>
>
> Key: KNOX-2400
> URL: https://issues.apache.org/jira/browse/KNOX-2400
> Project: Apache Knox
> Issue Type: Bug
> Components: KnoxSSO
>Affects Versions: 1.4.0
> Environment: java8
>Reporter: cdmikechen
>Priority: Major
>
> If we use CAS to login by KNOX-SSO, the request will fail with an error:
> {code}
> 2020-07-07 18:20:14,783 ERROR knox.gateway
> (AbstractGatewayFilter.java:doFilter(63)) - Failed to execute filter:
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;
> at
> org.apache.knox.gateway.services.security.EncryptionResult.toByteAray(EncryptionResult.java:45)
> at
> org.apache.knox.gateway.pac4j.session.KnoxSessionStore.compressEncryptBase64(KnoxSessionStore.java:132)
> at
> org.apache.knox.gateway.pac4j.session.KnoxSessionStore.set(KnoxSessionStore.java:150)
> at
> org.pac4j.core.engine.DefaultSecurityLogic.saveRequestedUrl(DefaultSecurityLogic.java:204)
> at
> org.pac4j.core.engine.DefaultSecurityLogic.perform(DefaultSecurityLogic.java:148)
> at
> org.pac4j.j2e.filter.SecurityFilter.internalFilter(SecurityFilter.java:92)
> at
> org.pac4j.j2e.filter.AbstractConfigFilter.doFilter(AbstractConfigFilter.java:84)
> at
> org.apache.knox.gateway.pac4j.filter.Pac4jDispatcherFilter.doFilter(Pac4jDispatcherFilter.java:272)
> at
> org.apache.knox.gateway.GatewayFilter$Holder.doFilter(GatewayFilter.java:348)
> at
> org.apache.knox.gateway.GatewayFilter$Chain.doFilter(GatewayFilter.java:262)
> at
> org.apache.knox.gateway.filter.XForwardedHeaderFilter.doFilter(XForwardedHeaderFilter.java:50)
> at
> org.apache.knox.gateway.filter.AbstractGatewayFilter.doFilter(AbstractGatewayFilter.java:58)
> at
> org.apache.knox.gateway.GatewayFilter$Holder.doFilter(GatewayFilter.java:348)
> at
> org.apache.knox.gateway.GatewayFilter$Chain.doFilter(GatewayFilter.java:262)
> at
> org.apache.knox.gateway.webappsec.filter.XFrameOptionsFilter.doFilter(XFrameOptionsFilter.java:52)
> at
>
[jira] [Comment Edited] (KNOX-2400) Can't login with SSO+CAS
[
https://issues.apache.org/jira/browse/KNOX-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183421#comment-17183421
]
rohannimmagadda edited comment on KNOX-2400 at 8/27/20, 4:58 PM:
-
[~lmccay]
We faced similar issue with Knox 1.4 + JDK 1.8 while creating the file in HDFS
with Knox+webHDFS curl , However here is the few steps we have taken to fix
this issue
# Step1 : We've started the Knox Service alone with Open JDK 11 by exporting
JAVA command in gateway.sh (ex: export JAVA=/usr/java/openjdk-11/bin/java)
# Step2: If you’r using http auth to non Kerberos which means
(hadoop.http.authentication.type: simple,
hadoop.http.authentication.simple.anonymous.allowed: true) the above export
JAVA command would work
# Otherwise , If your are using OpenJDK 11 and have http authentication
enabled to Kerberos, you may experience authentication errors (i.e HTTP ERROR
401 ** Authentication require like in YARN and WebHDFS gateway URLs *)* when
running Knox Services . To work around this problem: We tried setting this
sun.security.krb5.disableReferrals=true` value in java.security file but it
didn’t worked out in our case
# Here is the fix : By removing `renew_lifetime` property from /etc/krb5.conf
resolved our issue
# we can also run below command to keep renew_lifetime in krb5.conf
was (Author: rohannimmagadda):
[~lmccay]
We faced similar issue with Knox 1.4 + JDK 1.8 while creating the file in HDFS
with Knox+webHDFS curl , However here is the few steps we have taken to fix
this issue
# Step1 : We've started the Knox Service alone with Open JDK 11 by exporting
JAVA command in gateway.sh (ex: export JAVA=/usr/java/openjdk-11/bin/java)
# Step2: If you’r using http auth to non Kerberos which means
(hadoop.http.authentication.type: simple,
hadoop.http.authentication.simple.anonymous.allowed: true) the above export
JAVA command would work
# Otherwise , If your are using OpenJDK 11 and have http authentication
enabled to Kerberos, you may experience authentication errors (i.e HTTP ERROR
401 ** Authentication require like in YARN and WebHDFS gateway URLs *)* when
running Knox Services . To work around this problem: We tried setting this
sun.security.krb5.disableReferrals=true` value in java.security file but it
didn’t worked out in our case
# Here is the fix : By removing `renew_lifetime` property from /etc/krb5.conf
resolved our issue
> Can't login with SSO+CAS
>
>
> Key: KNOX-2400
> URL: https://issues.apache.org/jira/browse/KNOX-2400
> Project: Apache Knox
> Issue Type: Bug
> Components: KnoxSSO
>Affects Versions: 1.4.0
> Environment: java8
>Reporter: cdmikechen
>Priority: Major
>
> If we use CAS to login by KNOX-SSO, the request will fail with an error:
> {code}
> 2020-07-07 18:20:14,783 ERROR knox.gateway
> (AbstractGatewayFilter.java:doFilter(63)) - Failed to execute filter:
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;
> at
> org.apache.knox.gateway.services.security.EncryptionResult.toByteAray(EncryptionResult.java:45)
> at
> org.apache.knox.gateway.pac4j.session.KnoxSessionStore.compressEncryptBase64(KnoxSessionStore.java:132)
> at
> org.apache.knox.gateway.pac4j.session.KnoxSessionStore.set(KnoxSessionStore.java:150)
> at
> org.pac4j.core.engine.DefaultSecurityLogic.saveRequestedUrl(DefaultSecurityLogic.java:204)
> at
> org.pac4j.core.engine.DefaultSecurityLogic.perform(DefaultSecurityLogic.java:148)
> at
> org.pac4j.j2e.filter.SecurityFilter.internalFilter(SecurityFilter.java:92)
> at
> org.pac4j.j2e.filter.AbstractConfigFilter.doFilter(AbstractConfigFilter.java:84)
> at
> org.apache.knox.gateway.pac4j.filter.Pac4jDispatcherFilter.doFilter(Pac4jDispatcherFilter.java:272)
> at
> org.apache.knox.gateway.GatewayFilter$Holder.doFilter(GatewayFilter.java:348)
> at
> org.apache.knox.gateway.GatewayFilter$Chain.doFilter(GatewayFilter.java:262)
> at
> org.apache.knox.gateway.filter.XForwardedHeaderFilter.doFilter(XForwardedHeaderFilter.java:50)
> at
> org.apache.knox.gateway.filter.AbstractGatewayFilter.doFilter(AbstractGatewayFilter.java:58)
> at
> org.apache.knox.gateway.GatewayFilter$Holder.doFilter(GatewayFilter.java:348)
> at
> org.apache.knox.gateway.GatewayFilter$Chain.doFilter(GatewayFilter.java:262)
> at
> org.apache.knox.gateway.webappsec.filter.XFrameOptionsFilter.doFilter(XFrameOptionsFilter.java:52)
> at
> org.apache.knox.gateway.GatewayFilter$Holder.doFilter(GatewayFilter.java:348)
> at
> org.apache.knox.gateway.GatewayFilter$Chain.doFilter(GatewayFilter.java:262)
> at
>
[jira] [Work logged] (KNOX-2402) Develop a performance-test framework to test token state service
[
https://issues.apache.org/jira/browse/KNOX-2402?focusedWorklogId=475358=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475358
]
ASF GitHub Bot logged work on KNOX-2402:
Author: ASF GitHub Bot
Created on: 27/Aug/20 15:34
Start Date: 27/Aug/20 15:34
Worklog Time Spent: 10m
Work Description: pzampino commented on a change in pull request #365:
URL: https://github.com/apache/knox/pull/365#discussion_r478501003
##
File path:
gateway-performance-test/src/main/java/org/apache/knox/gateway/performance/test/knoxtoken/KnoxTokenCache.java
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.gateway.performance.test.knoxtoken;
+
+import java.util.Queue;
+import java.util.concurrent.ConcurrentLinkedQueue;
+
+class KnoxTokenCache {
+ private static final int CAPACITY = 500;
+ private final Queue knoxTokens = new ConcurrentLinkedQueue<>();
+
+ void saveKnoxToken(String knoxToken) {
+cleanIfNecessary();
+this.knoxTokens.offer(knoxToken);
Review comment:
Is it acceptable for a token to NOT be saved here? Just wondering why
you're using _offer_ instead of _add_.
##
File path:
gateway-performance-test/src/main/java/org/apache/knox/gateway/performance/test/PerformanceTestRunner.java
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.gateway.performance.test;
+
+import java.util.Arrays;
+import java.util.List;
+
+import
org.apache.knox.gateway.performance.test.reporting.GatewayMetricsReporter;
+
+public class PerformanceTestRunner {
+
+ public static void main(String[] args) throws Exception {
+final PerformanceTestConfiguration configuration = new
PerformanceTestConfiguration(args[0]);
+final ResponseTimeCache responseTimeCache = new ResponseTimeCache();
+final GatewayMetricsReporter metricsReporter = new
GatewayMetricsReporter(configuration, responseTimeCache);
+metricsReporter.start();
+final List lifeCyleListeners =
Arrays.asList(metricsReporter);
+for (PerformanceTestUseCase useCase : PerformanceTestUseCase.values()) {
Review comment:
Could use ServiceLoader instead of a hard-coded enum to find
PerformanceTestUseCase implementations.
##
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
##
@@ -154,17 +177,16 @@ public long getTokenExpiration(final String tokenId)
throws UnknownTokenExceptio
@Override
public long getTokenExpiration(String tokenId, boolean validate) throws
UnknownTokenException {
-long expiration;
-
if (validate) {
validateToken(tokenId);
}
+long expiration = -1;
synchronized (tokenExpirations) {
- if (!tokenExpirations.containsKey(tokenId)) {
-throw new UnknownTokenException(tokenId);
- }
- expiration = tokenExpirations.get(tokenId);
+ expiration = tokenExpirations.getOrDefault(tokenId, -1L);
+}
+if (expiration == -1) {
Review comment:
This doesn't appear to be any different than the previous
implementation. If this were a check for _expiration < 0_, I could see a
difference. What is the reason for the change?
##
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Ls.java
##
@@
[GitHub] [knox] pzampino commented on a change in pull request #365: KNOX-2402 - Adding Gateway performance testing
pzampino commented on a change in pull request #365:
URL: https://github.com/apache/knox/pull/365#discussion_r478501003
##
File path:
gateway-performance-test/src/main/java/org/apache/knox/gateway/performance/test/knoxtoken/KnoxTokenCache.java
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.gateway.performance.test.knoxtoken;
+
+import java.util.Queue;
+import java.util.concurrent.ConcurrentLinkedQueue;
+
+class KnoxTokenCache {
+ private static final int CAPACITY = 500;
+ private final Queue knoxTokens = new ConcurrentLinkedQueue<>();
+
+ void saveKnoxToken(String knoxToken) {
+cleanIfNecessary();
+this.knoxTokens.offer(knoxToken);
Review comment:
Is it acceptable for a token to NOT be saved here? Just wondering why
you're using _offer_ instead of _add_.
##
File path:
gateway-performance-test/src/main/java/org/apache/knox/gateway/performance/test/PerformanceTestRunner.java
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.gateway.performance.test;
+
+import java.util.Arrays;
+import java.util.List;
+
+import
org.apache.knox.gateway.performance.test.reporting.GatewayMetricsReporter;
+
+public class PerformanceTestRunner {
+
+ public static void main(String[] args) throws Exception {
+final PerformanceTestConfiguration configuration = new
PerformanceTestConfiguration(args[0]);
+final ResponseTimeCache responseTimeCache = new ResponseTimeCache();
+final GatewayMetricsReporter metricsReporter = new
GatewayMetricsReporter(configuration, responseTimeCache);
+metricsReporter.start();
+final List lifeCyleListeners =
Arrays.asList(metricsReporter);
+for (PerformanceTestUseCase useCase : PerformanceTestUseCase.values()) {
Review comment:
Could use ServiceLoader instead of a hard-coded enum to find
PerformanceTestUseCase implementations.
##
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/token/impl/DefaultTokenStateService.java
##
@@ -154,17 +177,16 @@ public long getTokenExpiration(final String tokenId)
throws UnknownTokenExceptio
@Override
public long getTokenExpiration(String tokenId, boolean validate) throws
UnknownTokenException {
-long expiration;
-
if (validate) {
validateToken(tokenId);
}
+long expiration = -1;
synchronized (tokenExpirations) {
- if (!tokenExpirations.containsKey(tokenId)) {
-throw new UnknownTokenException(tokenId);
- }
- expiration = tokenExpirations.get(tokenId);
+ expiration = tokenExpirations.getOrDefault(tokenId, -1L);
+}
+if (expiration == -1) {
Review comment:
This doesn't appear to be any different than the previous
implementation. If this were a check for _expiration < 0_, I could see a
difference. What is the reason for the change?
##
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/hdfs/Ls.java
##
@@ -41,6 +42,11 @@ public Request dir( String dir ) {
return this;
}
+public Request knoxToken(String knoxToken) {
Review comment:
Why not add Knox token support to KnoxSession?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[jira] [Work logged] (KNOX-2436) Add new service for replacing resourceManager property during Oozie usage
[ https://issues.apache.org/jira/browse/KNOX-2436?focusedWorklogId=475317=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475317 ] ASF GitHub Bot logged work on KNOX-2436: Author: ASF GitHub Bot Created on: 27/Aug/20 14:22 Start Date: 27/Aug/20 14:22 Worklog Time Spent: 10m Work Description: moresandeep commented on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681980575 Java8 job failed, re-triggered it. Once it passes we should be good to go. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475317) Time Spent: 1h 10m (was: 1h) > Add new service for replacing resourceManager property during Oozie usage > - > > Key: KNOX-2436 > URL: https://issues.apache.org/jira/browse/KNOX-2436 > Project: Apache Knox > Issue Type: New Feature >Reporter: Adam Arvai >Assignee: Adam Arvai >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > In Oozie 5.x there is a new parameter called resourceManager. This is used > instead of jobTracker. However, Oozie can fall back to jobTracker value if no > resourceManager is defined. resourceManager shall have the same value as > jobTracker has now. > This ticket is intend to track the work on adding a new rewrite rule and a > new service returning the resource-manager's address. > Currently the JobTrackerServiceModelGenerator despite its name is actually > returning the resource-manager's address. This is not enabled by default > because its misleading name since we no longer have job-trackers but > resource-managers. > By having a new service which does exactly the same thing as > JobTrackerServiceModelGenerator but is enabled by default we could have Oozie > work with Knox out of the box. > We should be careful as the resource manager service name is already taken by > ResourceManagerUIServiceModelGenerator. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [knox] moresandeep commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
moresandeep commented on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681980575 Java8 job failed, re-triggered it. Once it passes we should be good to go. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (KNOX-2436) Add new service for replacing resourceManager property during Oozie usage
[ https://issues.apache.org/jira/browse/KNOX-2436?focusedWorklogId=475211=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475211 ] ASF GitHub Bot logged work on KNOX-2436: Author: ASF GitHub Bot Created on: 27/Aug/20 09:41 Start Date: 27/Aug/20 09:41 Worklog Time Spent: 10m Work Description: smolnar82 commented on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681841673 > > @arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within gateway-service-definitions (e.g. 5.0.0) and leave the previous version as-is? > > Thanks for your feedback, i changed accordingly. Thanks, @arvaiadam! I really appreciate your fast feedback and action you've taken here! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475211) Time Spent: 1h (was: 50m) > Add new service for replacing resourceManager property during Oozie usage > - > > Key: KNOX-2436 > URL: https://issues.apache.org/jira/browse/KNOX-2436 > Project: Apache Knox > Issue Type: New Feature >Reporter: Adam Arvai >Assignee: Adam Arvai >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > In Oozie 5.x there is a new parameter called resourceManager. This is used > instead of jobTracker. However, Oozie can fall back to jobTracker value if no > resourceManager is defined. resourceManager shall have the same value as > jobTracker has now. > This ticket is intend to track the work on adding a new rewrite rule and a > new service returning the resource-manager's address. > Currently the JobTrackerServiceModelGenerator despite its name is actually > returning the resource-manager's address. This is not enabled by default > because its misleading name since we no longer have job-trackers but > resource-managers. > By having a new service which does exactly the same thing as > JobTrackerServiceModelGenerator but is enabled by default we could have Oozie > work with Knox out of the box. > We should be careful as the resource manager service name is already taken by > ResourceManagerUIServiceModelGenerator. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [knox] smolnar82 commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
smolnar82 commented on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681841673 > > @arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within gateway-service-definitions (e.g. 5.0.0) and leave the previous version as-is? > > Thanks for your feedback, i changed accordingly. Thanks, @arvaiadam! I really appreciate your fast feedback and action you've taken here! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [knox] arvaiadam commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
arvaiadam commented on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681841227 > @arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within gateway-service-definitions (e.g. 5.0.0) and leave the previous version as-is? Thanks for your feedback, i changed accordingly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (KNOX-2436) Add new service for replacing resourceManager property during Oozie usage
[ https://issues.apache.org/jira/browse/KNOX-2436?focusedWorklogId=475210=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475210 ] ASF GitHub Bot logged work on KNOX-2436: Author: ASF GitHub Bot Created on: 27/Aug/20 09:40 Start Date: 27/Aug/20 09:40 Worklog Time Spent: 10m Work Description: arvaiadam commented on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681841227 > @arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within gateway-service-definitions (e.g. 5.0.0) and leave the previous version as-is? Thanks for your feedback, i changed accordingly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475210) Time Spent: 50m (was: 40m) > Add new service for replacing resourceManager property during Oozie usage > - > > Key: KNOX-2436 > URL: https://issues.apache.org/jira/browse/KNOX-2436 > Project: Apache Knox > Issue Type: New Feature >Reporter: Adam Arvai >Assignee: Adam Arvai >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > In Oozie 5.x there is a new parameter called resourceManager. This is used > instead of jobTracker. However, Oozie can fall back to jobTracker value if no > resourceManager is defined. resourceManager shall have the same value as > jobTracker has now. > This ticket is intend to track the work on adding a new rewrite rule and a > new service returning the resource-manager's address. > Currently the JobTrackerServiceModelGenerator despite its name is actually > returning the resource-manager's address. This is not enabled by default > because its misleading name since we no longer have job-trackers but > resource-managers. > By having a new service which does exactly the same thing as > JobTrackerServiceModelGenerator but is enabled by default we could have Oozie > work with Knox out of the box. > We should be careful as the resource manager service name is already taken by > ResourceManagerUIServiceModelGenerator. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (KNOX-2436) Add new service for replacing resourceManager property during Oozie usage
[ https://issues.apache.org/jira/browse/KNOX-2436?focusedWorklogId=475205=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475205 ] ASF GitHub Bot logged work on KNOX-2436: Author: ASF GitHub Bot Created on: 27/Aug/20 09:30 Start Date: 27/Aug/20 09:30 Worklog Time Spent: 10m Work Description: smolnar82 commented on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681835861 @moresandeep, please review this PR when you have time. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475205) Time Spent: 40m (was: 0.5h) > Add new service for replacing resourceManager property during Oozie usage > - > > Key: KNOX-2436 > URL: https://issues.apache.org/jira/browse/KNOX-2436 > Project: Apache Knox > Issue Type: New Feature >Reporter: Adam Arvai >Assignee: Adam Arvai >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > In Oozie 5.x there is a new parameter called resourceManager. This is used > instead of jobTracker. However, Oozie can fall back to jobTracker value if no > resourceManager is defined. resourceManager shall have the same value as > jobTracker has now. > This ticket is intend to track the work on adding a new rewrite rule and a > new service returning the resource-manager's address. > Currently the JobTrackerServiceModelGenerator despite its name is actually > returning the resource-manager's address. This is not enabled by default > because its misleading name since we no longer have job-trackers but > resource-managers. > By having a new service which does exactly the same thing as > JobTrackerServiceModelGenerator but is enabled by default we could have Oozie > work with Knox out of the box. > We should be careful as the resource manager service name is already taken by > ResourceManagerUIServiceModelGenerator. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [knox] smolnar82 commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
smolnar82 commented on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681835861 @moresandeep, please review this PR when you have time. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Work logged] (KNOX-2436) Add new service for replacing resourceManager property during Oozie usage
[ https://issues.apache.org/jira/browse/KNOX-2436?focusedWorklogId=475188=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475188 ] ASF GitHub Bot logged work on KNOX-2436: Author: ASF GitHub Bot Created on: 27/Aug/20 08:06 Start Date: 27/Aug/20 08:06 Worklog Time Spent: 10m Work Description: smolnar82 commented on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681743389 @arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within `gateway-service-definitions` (e.g. `5.0.0`) and leave the previous version as-is? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475188) Time Spent: 20m (was: 10m) > Add new service for replacing resourceManager property during Oozie usage > - > > Key: KNOX-2436 > URL: https://issues.apache.org/jira/browse/KNOX-2436 > Project: Apache Knox > Issue Type: New Feature >Reporter: Adam Arvai >Assignee: Adam Arvai >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > In Oozie 5.x there is a new parameter called resourceManager. This is used > instead of jobTracker. However, Oozie can fall back to jobTracker value if no > resourceManager is defined. resourceManager shall have the same value as > jobTracker has now. > This ticket is intend to track the work on adding a new rewrite rule and a > new service returning the resource-manager's address. > Currently the JobTrackerServiceModelGenerator despite its name is actually > returning the resource-manager's address. This is not enabled by default > because its misleading name since we no longer have job-trackers but > resource-managers. > By having a new service which does exactly the same thing as > JobTrackerServiceModelGenerator but is enabled by default we could have Oozie > work with Knox out of the box. > We should be careful as the resource manager service name is already taken by > ResourceManagerUIServiceModelGenerator. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (KNOX-2436) Add new service for replacing resourceManager property during Oozie usage
[ https://issues.apache.org/jira/browse/KNOX-2436?focusedWorklogId=475189=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-475189 ] ASF GitHub Bot logged work on KNOX-2436: Author: ASF GitHub Bot Created on: 27/Aug/20 08:06 Start Date: 27/Aug/20 08:06 Worklog Time Spent: 10m Work Description: smolnar82 removed a comment on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681743389 @arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within `gateway-service-definitions` (e.g. `5.0.0`) and leave the previous version as-is? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 475189) Time Spent: 0.5h (was: 20m) > Add new service for replacing resourceManager property during Oozie usage > - > > Key: KNOX-2436 > URL: https://issues.apache.org/jira/browse/KNOX-2436 > Project: Apache Knox > Issue Type: New Feature >Reporter: Adam Arvai >Assignee: Adam Arvai >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > In Oozie 5.x there is a new parameter called resourceManager. This is used > instead of jobTracker. However, Oozie can fall back to jobTracker value if no > resourceManager is defined. resourceManager shall have the same value as > jobTracker has now. > This ticket is intend to track the work on adding a new rewrite rule and a > new service returning the resource-manager's address. > Currently the JobTrackerServiceModelGenerator despite its name is actually > returning the resource-manager's address. This is not enabled by default > because its misleading name since we no longer have job-trackers but > resource-managers. > By having a new service which does exactly the same thing as > JobTrackerServiceModelGenerator but is enabled by default we could have Oozie > work with Knox out of the box. > We should be careful as the resource manager service name is already taken by > ResourceManagerUIServiceModelGenerator. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [knox] smolnar82 removed a comment on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
smolnar82 removed a comment on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681743389 @arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within `gateway-service-definitions` (e.g. `5.0.0`) and leave the previous version as-is? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…
smolnar82 commented on pull request #369: URL: https://github.com/apache/knox/pull/369#issuecomment-681743389 @arvaiadam , in the PR description you say this is needed for Oozie 5.x. Would not be better to create a new version within `gateway-service-definitions` (e.g. `5.0.0`) and leave the previous version as-is? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
