[jira] [Work logged] (KNOX-2862) Setup idle timeout for SSO cookie to 15 minutes

2023-01-17 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/KNOX-2862?focusedWorklogId=839749=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839749
 ]

ASF GitHub Bot logged work on KNOX-2862:


Author: ASF GitHub Bot
Created on: 17/Jan/23 18:47
Start Date: 17/Jan/23 18:47
Worklog Time Spent: 10m 
  Work Description: pzampino commented on code in PR #714:
URL: https://github.com/apache/knox/pull/714#discussion_r1072665671


##
gateway-service-knoxsso/src/main/java/org/apache/knox/gateway/service/knoxsso/WebSSOResource.java:
##
@@ -95,7 +95,7 @@ public class WebSSOResource {
   private static final String ORIGINAL_URL_COOKIE_NAME = "original-url";
   private static final String DEFAULT_SSO_COOKIE_NAME = "hadoop-jwt";
   private static final String SSO_COOKIE_SAMESITE_DEFAULT = "Strict";
-  private static final long TOKEN_TTL_DEFAULT = 3L;
+  private static final long TOKEN_TTL_DEFAULT = 15000 * 60;

Review Comment:
   This does seem to be a more reasonable default, so let's make this change.





Issue Time Tracking
---

Worklog Id: (was: 839749)
Time Spent: 40m  (was: 0.5h)

> Setup idle timeout for SSO cookie to 15 minutes
> ---
>
> Key: KNOX-2862
> URL: https://issues.apache.org/jira/browse/KNOX-2862
> Project: Apache Knox
>  Issue Type: Task
>Reporter: Attila Magyar
>Assignee: Attila Magyar
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Fedramp mandates this to be 15 minutes 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [knox] pzampino commented on a diff in pull request #714: KNOX-2862 - Setup idle timeout for SSO cookie to 15 minutes

2023-01-17 Thread GitBox 


pzampino commented on code in PR #714:
URL: https://github.com/apache/knox/pull/714#discussion_r1072665671


##
gateway-service-knoxsso/src/main/java/org/apache/knox/gateway/service/knoxsso/WebSSOResource.java:
##
@@ -95,7 +95,7 @@ public class WebSSOResource {
   private static final String ORIGINAL_URL_COOKIE_NAME = "original-url";
   private static final String DEFAULT_SSO_COOKIE_NAME = "hadoop-jwt";
   private static final String SSO_COOKIE_SAMESITE_DEFAULT = "Strict";
-  private static final long TOKEN_TTL_DEFAULT = 3L;
+  private static final long TOKEN_TTL_DEFAULT = 15000 * 60;

Review Comment:
   This does seem to be a more reasonable default, so let's make this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org