[GitHub] [knox] moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox
moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox URL: https://github.com/apache/knox/pull/263#discussion_r384086345 ## File path: gateway-service-definitions/src/main/resources/services/ambari/0.2.2.0/service.xml ## @@ -15,6 +15,12 @@ limitations under the License. --> + +API +/ambari/api Review comment: Created a JIRA so we can use `context` in routes https://issues.apache.org/jira/browse/KNOX-2252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [knox] moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox
moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox URL: https://github.com/apache/knox/pull/263#discussion_r383988278 ## File path: gateway-service-definitions/src/main/resources/services/ambari/0.2.2.0/service.xml ## @@ -15,6 +15,12 @@ limitations under the License. --> + +API +/ambari/api Review comment: What is the use of context ? Looks like we are duplicating context here and in the routes elements. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [knox] moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox
moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox URL: https://github.com/apache/knox/pull/263#discussion_r384065726 ## File path: gateway-service-definitions/src/main/resources/services/cm-ui/1.0.0/rewrite.xml ## @@ -0,0 +1,33 @@ + + + + + + + + + + + + Review comment: Same as above. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [knox] moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox
moresandeep commented on a change in pull request #263: KNOX-2226 - Add home
page to Knox
URL: https://github.com/apache/knox/pull/263#discussion_r378351786
##
File path:
gateway-server/src/main/java/org/apache/knox/gateway/GatewayServer.java
##
@@ -923,6 +925,40 @@ private synchronized void internalActivateArchive(
Topology topology, File warDi
}
}
+ private synchronized void activateHomeApp() {
+try {
+ // UI
+ activateHomepageContext("/home", "homepage/%2Fhome");
+
+ // API
+ activateHomepageContext("/home/api", "homepage/%2F");
+} catch (Throwable e) {
+ e.printStackTrace();
Review comment:
This might be due to WIP, but we should not be throwing stack traces.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox
moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox URL: https://github.com/apache/knox/pull/263#discussion_r384065569 ## File path: gateway-service-definitions/src/main/resources/services/cm-ui/1.0.0/rewrite.xml ## @@ -0,0 +1,33 @@ + + + + + + + + + Review comment: why is the context path /static here shouldn't it be /cmf/static ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [knox] moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox
moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox URL: https://github.com/apache/knox/pull/263#discussion_r384066536 ## File path: gateway-service-definitions/src/main/resources/services/cm-ui/1.0.0/rewrite.xml ## @@ -0,0 +1,33 @@ + + + + + + + + + + + + + + + Review comment: same as above This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [knox] moresandeep commented on a change in pull request #263: KNOX-2226 - Add home page to Knox
moresandeep commented on a change in pull request #263: KNOX-2226 - Add home
page to Knox
URL: https://github.com/apache/knox/pull/263#discussion_r378357573
##
File path:
knox-homepage-backend/src/main/java/org/apache/knox/homepage/service/model/ServiceModel.java
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.homepage.service.model;
+
+import java.util.Locale;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.xml.bind.annotation.XmlAccessType;
+import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlElement;
+import javax.xml.bind.annotation.XmlRootElement;
+
+import org.apache.knox.gateway.topology.Service;
+
+@XmlRootElement(name = "service")
+@XmlAccessorType(XmlAccessType.NONE)
+public class ServiceModel {
+
+ public enum Type {
+API, UI, UNKNOWN
+ };
+
+ protected HttpServletRequest request;
+ protected String topologyName;
+ protected String gatewayPath;
+ protected Service service;
+
+ public void setRequest(HttpServletRequest request) {
+this.request = request;
+ }
+
+ public void setTopologyName(String topologyName) {
+this.topologyName = topologyName;
+ }
+
+ public void setGatewayPath(String gatewayPath) {
+this.gatewayPath = gatewayPath;
+ }
+
+ public void setService(Service service) {
+this.service = service;
+ }
+
Review comment:
We should also get display service version
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
