[jira] [Commented] (KNOX-1786) Use mocking to simplify DefaultRemoteConfigurationMonitorTest

2019-02-19 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/KNOX-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772316#comment-16772316
 ] 

ASF subversion and git services commented on KNOX-1786:
---

Commit 6aa1759d108250ffd93ba809e7106705c081e8a2 in knox's branch 
refs/heads/master from Kevin Risden
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=6aa1759 ]

KNOX-1786 - Use mocking to simplify DefaultRemoteConfigurationMonitorTest

Signed-off-by: Kevin Risden 


> Use mocking to simplify DefaultRemoteConfigurationMonitorTest
> -
>
> Key: KNOX-1786
> URL: https://issues.apache.org/jira/browse/KNOX-1786
> Project: Apache Knox
>  Issue Type: Test
>  Components: Tests
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
> Attachments: KNOX-1786.patch
>
>
> Currently DefaultRemoteConfigurationMonitorTest stubs out two classes to test 
> IllegalStateException. This is cleaner with mocking to avoid the big stub 
> classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KNOX-1786) Use mocking to simplify DefaultRemoteConfigurationMonitorTest

2019-02-19 Thread Kevin Risden (JIRA)


[ 
https://issues.apache.org/jira/browse/KNOX-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772309#comment-16772309
 ] 

Kevin Risden commented on KNOX-1786:


FYI [~pzampino] since you wrote this test in KNOX-1737

> Use mocking to simplify DefaultRemoteConfigurationMonitorTest
> -
>
> Key: KNOX-1786
> URL: https://issues.apache.org/jira/browse/KNOX-1786
> Project: Apache Knox
>  Issue Type: Test
>  Components: Tests
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
> Attachments: KNOX-1786.patch
>
>
> Currently DefaultRemoteConfigurationMonitorTest stubs out two classes to test 
> IllegalStateException. This is cleaner with mocking to avoid the big stub 
> classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (KNOX-1786) Use mocking to simplify DefaultRemoteConfigurationMonitorTest

2019-02-19 Thread Kevin Risden (JIRA)


[ 
https://issues.apache.org/jira/browse/KNOX-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772292#comment-16772292
 ] 

Kevin Risden commented on KNOX-1786:


This change ensures that changes to GatewayConfig interface don't need to be 
applied to this test.

> Use mocking to simplify DefaultRemoteConfigurationMonitorTest
> -
>
> Key: KNOX-1786
> URL: https://issues.apache.org/jira/browse/KNOX-1786
> Project: Apache Knox
>  Issue Type: Test
>  Components: Tests
>Reporter: Kevin Risden
>Assignee: Kevin Risden
>Priority: Minor
> Fix For: 1.3.0
>
> Attachments: KNOX-1786.patch
>
>
> Currently DefaultRemoteConfigurationMonitorTest stubs out two classes to test 
> IllegalStateException. This is cleaner with mocking to avoid the big stub 
> classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)