[jira] [Updated] (KNOX-720) Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop
[ https://issues.apache.org/jira/browse/KNOX-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated KNOX-720: -- Attachment: KNOX-720.patch Status: Patch Available (was: In Progress) > Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop > - > > Key: KNOX-720 > URL: https://issues.apache.org/jira/browse/KNOX-720 > Project: Apache Knox > Issue Type: Bug > Components: ClientDSL >Affects Versions: 0.7.0 >Reporter: Marco Battaglia >Assignee: Kevin Risden >Priority: Major > Fix For: 1.2.0 > > Attachments: KNOX-720.patch > > > The class org.apache.hadoop.gateway.shell.Hadoop used to connect to knox > doesn't close opened socket. > The "shutdown" method of org...shell.Hadoop doesn't call client.close() and > this produces too much permanent CLOSE_WAIT sockest. > Suggestion: > public void shutdown() throws InterruptedException { > -executor.shutdown(); > +closeClient(); > } > > public boolean shutdown( long timeout, TimeUnit unit ) throws > InterruptedException { > - executor.shutdown(); > +closeClient(); > return executor.awaitTermination( timeout, unit ); > } > + > + private void closeClient(){ > + executor.shutdownNow(); > +if(client!=null){ > + client.close(); > +} > + } -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KNOX-720) Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop
[ https://issues.apache.org/jira/browse/KNOX-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated KNOX-720: -- Fix Version/s: (was: Future) 1.2.0 > Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop > - > > Key: KNOX-720 > URL: https://issues.apache.org/jira/browse/KNOX-720 > Project: Apache Knox > Issue Type: Bug > Components: ClientDSL >Affects Versions: 0.7.0 >Reporter: Marco Battaglia >Priority: Major > Fix For: 1.2.0 > > > The class org.apache.hadoop.gateway.shell.Hadoop used to connect to knox > doesn't close opened socket. > The "shutdown" method of org...shell.Hadoop doesn't call client.close() and > this produces too much permanent CLOSE_WAIT sockest. > Suggestion: > public void shutdown() throws InterruptedException { > -executor.shutdown(); > +closeClient(); > } > > public boolean shutdown( long timeout, TimeUnit unit ) throws > InterruptedException { > - executor.shutdown(); > +closeClient(); > return executor.awaitTermination( timeout, unit ); > } > + > + private void closeClient(){ > + executor.shutdownNow(); > +if(client!=null){ > + client.close(); > +} > + } -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KNOX-720) Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop
[ https://issues.apache.org/jira/browse/KNOX-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Larry McCay updated KNOX-720: - Fix Version/s: (was: 0.15.0) Future > Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop > - > > Key: KNOX-720 > URL: https://issues.apache.org/jira/browse/KNOX-720 > Project: Apache Knox > Issue Type: Bug > Components: ClientDSL >Affects Versions: 0.7.0 >Reporter: Marco Battaglia >Priority: Major > Fix For: Future > > > The class org.apache.hadoop.gateway.shell.Hadoop used to connect to knox > doesn't close opened socket. > The "shutdown" method of org...shell.Hadoop doesn't call client.close() and > this produces too much permanent CLOSE_WAIT sockest. > Suggestion: > public void shutdown() throws InterruptedException { > -executor.shutdown(); > +closeClient(); > } > > public boolean shutdown( long timeout, TimeUnit unit ) throws > InterruptedException { > - executor.shutdown(); > +closeClient(); > return executor.awaitTermination( timeout, unit ); > } > + > + private void closeClient(){ > + executor.shutdownNow(); > +if(client!=null){ > + client.close(); > +} > + } -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (KNOX-720) Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop
[ https://issues.apache.org/jira/browse/KNOX-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Larry McCay updated KNOX-720: - Fix Version/s: (was: 0.14.0) 0.15.0 > Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop > - > > Key: KNOX-720 > URL: https://issues.apache.org/jira/browse/KNOX-720 > Project: Apache Knox > Issue Type: Bug > Components: ClientDSL >Affects Versions: 0.7.0 >Reporter: Marco Battaglia > Fix For: 0.15.0 > > > The class org.apache.hadoop.gateway.shell.Hadoop used to connect to knox > doesn't close opened socket. > The "shutdown" method of org...shell.Hadoop doesn't call client.close() and > this produces too much permanent CLOSE_WAIT sockest. > Suggestion: > public void shutdown() throws InterruptedException { > -executor.shutdown(); > +closeClient(); > } > > public boolean shutdown( long timeout, TimeUnit unit ) throws > InterruptedException { > - executor.shutdown(); > +closeClient(); > return executor.awaitTermination( timeout, unit ); > } > + > + private void closeClient(){ > + executor.shutdownNow(); > +if(client!=null){ > + client.close(); > +} > + } -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KNOX-720) Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop
[ https://issues.apache.org/jira/browse/KNOX-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Larry McCay updated KNOX-720: - Fix Version/s: 0.14.0 > Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop > - > > Key: KNOX-720 > URL: https://issues.apache.org/jira/browse/KNOX-720 > Project: Apache Knox > Issue Type: Bug > Components: ClientDSL >Affects Versions: 0.7.0 >Reporter: Marco Battaglia > Fix For: 0.14.0 > > > The class org.apache.hadoop.gateway.shell.Hadoop used to connect to knox > doesn't close opened socket. > The "shutdown" method of org...shell.Hadoop doesn't call client.close() and > this produces too much permanent CLOSE_WAIT sockest. > Suggestion: > public void shutdown() throws InterruptedException { > -executor.shutdown(); > +closeClient(); > } > > public boolean shutdown( long timeout, TimeUnit unit ) throws > InterruptedException { > - executor.shutdown(); > +closeClient(); > return executor.awaitTermination( timeout, unit ); > } > + > + private void closeClient(){ > + executor.shutdownNow(); > +if(client!=null){ > + client.close(); > +} > + } -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (KNOX-720) Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop
[ https://issues.apache.org/jira/browse/KNOX-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Battaglia updated KNOX-720: - Description: The class org.apache.hadoop.gateway.shell.Hadoop used to connect to knox doesn't close opened socket. The "shutdown" method of org...shell.Hadoop doesn't call client.close() and this produces too much permanent CLOSE_WAIT sockest. Suggestion: public void shutdown() throws InterruptedException { -executor.shutdown(); +closeClient(); } public boolean shutdown( long timeout, TimeUnit unit ) throws InterruptedException { - executor.shutdown(); +closeClient(); return executor.awaitTermination( timeout, unit ); } + + private void closeClient(){ + executor.shutdownNow(); +if(client!=null){ + client.close(); +} + } was: The class org.apache.hadoop.gateway.shell.Hadoop used to connect to knox doesn't close opened socket. The "shutdown" method of org...shell.Hadoop doesn't call client.close() and this produces too much permanent CLOSE_WAIT sockest. Suggestion: public void shutdown() throws InterruptedException { - +closeClient(); } public boolean shutdown( long timeout, TimeUnit unit ) throws InterruptedException { - executor.shutdown(); +closeClient(); return executor.awaitTermination( timeout, unit ); } + + private void closeClient(){ + executor.shutdownNow(); +if(client!=null){ + client.close(); +} + } > Sockets remain in CLOSE_WAIT using org.apache.hadoop.gateway.shell.Hadoop > - > > Key: KNOX-720 > URL: https://issues.apache.org/jira/browse/KNOX-720 > Project: Apache Knox > Issue Type: Bug > Components: ClientDSL >Affects Versions: 0.7.0 >Reporter: Marco Battaglia > > The class org.apache.hadoop.gateway.shell.Hadoop used to connect to knox > doesn't close opened socket. > The "shutdown" method of org...shell.Hadoop doesn't call client.close() and > this produces too much permanent CLOSE_WAIT sockest. > Suggestion: > public void shutdown() throws InterruptedException { > -executor.shutdown(); > +closeClient(); > } > > public boolean shutdown( long timeout, TimeUnit unit ) throws > InterruptedException { > - executor.shutdown(); > +closeClient(); > return executor.awaitTermination( timeout, unit ); > } > + > + private void closeClient(){ > + executor.shutdownNow(); > +if(client!=null){ > + client.close(); > +} > + } -- This message was sent by Atlassian JIRA (v6.3.4#6332)