[jira] [Work logged] (KNOX-1654) Ability to exclude global rewrite rules
[ https://issues.apache.org/jira/browse/KNOX-1654?focusedWorklogId=687838=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687838 ] ASF GitHub Bot logged work on KNOX-1654: Author: ASF GitHub Bot Created on: 30/Nov/21 08:26 Start Date: 30/Nov/21 08:26 Worklog Time Spent: 10m Work Description: smolnar82 commented on pull request #196: URL: https://github.com/apache/knox/pull/196#issuecomment-982395171 This PR has not been touched for over a year ago; closing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 687838) Time Spent: 50m (was: 40m) > Ability to exclude global rewrite rules > > > Key: KNOX-1654 > URL: https://issues.apache.org/jira/browse/KNOX-1654 > Project: Apache Knox > Issue Type: Bug > Components: Server >Reporter: Sandeep More >Assignee: Sandor Molnar >Priority: Major > Fix For: 2.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Currently we have some services whose rewrite rules are global, the > configuration is in gateway-site.xml. We need to be able to add a list of > services that can be excluded so that global rules do not affect them. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (KNOX-1654) Ability to exclude global rewrite rules
[ https://issues.apache.org/jira/browse/KNOX-1654?focusedWorklogId=687839=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687839 ] ASF GitHub Bot logged work on KNOX-1654: Author: ASF GitHub Bot Created on: 30/Nov/21 08:26 Start Date: 30/Nov/21 08:26 Worklog Time Spent: 10m Work Description: smolnar82 closed pull request #196: URL: https://github.com/apache/knox/pull/196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 687839) Time Spent: 1h (was: 50m) > Ability to exclude global rewrite rules > > > Key: KNOX-1654 > URL: https://issues.apache.org/jira/browse/KNOX-1654 > Project: Apache Knox > Issue Type: Bug > Components: Server >Reporter: Sandeep More >Assignee: Sandor Molnar >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Currently we have some services whose rewrite rules are global, the > configuration is in gateway-site.xml. We need to be able to add a list of > services that can be excluded so that global rules do not affect them. > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (KNOX-1654) Ability to exclude global rewrite rules
[ https://issues.apache.org/jira/browse/KNOX-1654?focusedWorklogId=392848=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392848 ] ASF GitHub Bot logged work on KNOX-1654: Author: ASF GitHub Bot Created on: 25/Feb/20 19:15 Start Date: 25/Feb/20 19:15 Worklog Time Spent: 10m Work Description: smolnar82 commented on issue #196: KNOX-1654 - Ability to exclude services to apply global rewrite rules URL: https://github.com/apache/knox/pull/196#issuecomment-591020280 @risdenk, last time I checked there was no common agreement on this feature in the JIRA (this is still true). I see the following two options: - either closing this one and the JIRA as `Won't do` - or merging this PR and resolve the JIRA Cc. @lmccay, @moresandeep This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 392848) Time Spent: 40m (was: 0.5h) > Ability to exclude global rewrite rules > > > Key: KNOX-1654 > URL: https://issues.apache.org/jira/browse/KNOX-1654 > Project: Apache Knox > Issue Type: Bug > Components: Server >Reporter: Sandeep More >Assignee: Sandor Molnar >Priority: Major > Fix For: 1.4.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Currently we have some services whose rewrite rules are global, the > configuration is in gateway-site.xml. We need to be able to add a list of > services that can be excluded so that global rules do not affect them. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (KNOX-1654) Ability to exclude global rewrite rules
[ https://issues.apache.org/jira/browse/KNOX-1654?focusedWorklogId=392594=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392594 ] ASF GitHub Bot logged work on KNOX-1654: Author: ASF GitHub Bot Created on: 25/Feb/20 14:44 Start Date: 25/Feb/20 14:44 Worklog Time Spent: 10m Work Description: risdenk commented on issue #196: KNOX-1654 - Ability to exclude services to apply global rewrite rules URL: https://github.com/apache/knox/pull/196#issuecomment-590901279 @smolnar82 what is the status of this change? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 392594) Time Spent: 0.5h (was: 20m) > Ability to exclude global rewrite rules > > > Key: KNOX-1654 > URL: https://issues.apache.org/jira/browse/KNOX-1654 > Project: Apache Knox > Issue Type: Bug > Components: Server >Reporter: Sandeep More >Assignee: Sandor Molnar >Priority: Major > Fix For: 1.4.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently we have some services whose rewrite rules are global, the > configuration is in gateway-site.xml. We need to be able to add a list of > services that can be excluded so that global rules do not affect them. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (KNOX-1654) Ability to exclude global rewrite rules
[ https://issues.apache.org/jira/browse/KNOX-1654?focusedWorklogId=344371=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344371 ] ASF GitHub Bot logged work on KNOX-1654: Author: ASF GitHub Bot Created on: 15/Nov/19 15:47 Start Date: 15/Nov/19 15:47 Worklog Time Spent: 10m Work Description: smolnar82 commented on issue #196: KNOX-1654 - Ability to exclude services to apply global rewrite rules URL: https://github.com/apache/knox/pull/196#issuecomment-554412379 @risdenk @moresandeep @pzampino @lmccay Could you please review my changes? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 344371) Time Spent: 20m (was: 10m) > Ability to exclude global rewrite rules > > > Key: KNOX-1654 > URL: https://issues.apache.org/jira/browse/KNOX-1654 > Project: Apache Knox > Issue Type: Bug > Components: Server >Reporter: Sandeep More >Assignee: Sandor Molnar >Priority: Major > Fix For: 1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently we have some services whose rewrite rules are global, the > configuration is in gateway-site.xml. We need to be able to add a list of > services that can be excluded so that global rules do not affect them. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (KNOX-1654) Ability to exclude global rewrite rules
[ https://issues.apache.org/jira/browse/KNOX-1654?focusedWorklogId=344370=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344370 ] ASF GitHub Bot logged work on KNOX-1654: Author: ASF GitHub Bot Created on: 15/Nov/19 15:46 Start Date: 15/Nov/19 15:46 Worklog Time Spent: 10m Work Description: smolnar82 commented on pull request #196: KNOX-1654 - Ability to exclude services to apply global rewrite rules URL: https://github.com/apache/knox/pull/196 ## What changes were proposed in this pull request? We need to allow end-users to declare certain service(s) which are not affected by global rules even if they would match by them. ## How was this patch tested? Added new uni tests; updated existing ones and ran them: ``` [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 18:23 min (Wall Clock) [INFO] Finished at: 2019-11-15T16:19:43+01:00 [INFO] Final Memory: 408M/1814M [INFO] ``` In addition to unit testing the following E2E test steps were executed: 1. started a local web server with `netcat` with the following content: ``` A webpage served by netcat http://localhost:1234/testLink;>test link ``` 2. Added two new service definitions: SERVICE 1 without any outboud rule: https://user-images.githubusercontent.com/34065904/68955435-4cb3eb00-07c6-11ea-840c-7ca23d4bd450.png;> SERVICE2 with an outbound rule which matches the above link in the test HTML: https://user-images.githubusercontent.com/34065904/68955449-53426280-07c6-11ea-860a-938eac4e3584.png;> 3. Added these services in `sandbox` topology https://user-images.githubusercontent.com/34065904/68955533-8edd2c80-07c6-11ea-8eb4-44273de1069a.png;> 4. Made SERVICE2 global in `gateway-site.xml` and re-started the gateway: ``` gateway.global.rules.services SERVICE2 ``` 5. Tested both services using `curl`: ``` $ curl -ku guest:guest-password 'https://localhost:8443/gateway/sandbox/service2/test' A webpage served by netcat test link ``` ``` $ curl -ku guest:guest-password 'https://localhost:8443/gateway/sandbox/service1/test' A webpage served by netcat test link ``` As expected, the global rule `SERVICE2/service2/outbound/links` defined in `SERVICE2` has been applied here too. 6. Marked `SERVICE1` as a service to exclude global rules in `gateway-site.xml` and re-started the gateway: ``` gateway.global.rules.excluded.services SERVICE1 ``` 7. Re-tested the services: ``` $ curl -ku guest:guest-password 'https://localhost:8443/gateway/sandbox/service2/test: A webpage served by netcat test link ``` ``` $ curl -ku guest:guest-password 'https://localhost:8443/gateway/sandbox/service1/test' A webpage served by netcat http://localhost:1234/testLink;>test link ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 344370) Remaining Estimate: 0h Time Spent: 10m > Ability to exclude global rewrite rules > > > Key: KNOX-1654 > URL: https://issues.apache.org/jira/browse/KNOX-1654 > Project: Apache Knox > Issue Type: Bug > Components: Server >Reporter: Sandeep More >Assignee: Sandor Molnar >Priority: Major > Fix For: 1.4.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Currently we have some services whose rewrite rules are global, the > configuration is in gateway-site.xml. We need to be able to add a list of > services that can be excluded so that global rules do not affect them. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
